From: Johannes Berg <johannes@sipsolutions.net>
To: Denis Kenzior <denkenz@gmail.com>,
James Prestwood <prestwoj@gmail.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: Support LIVE_ADDRESS_CHANGE feature
Date: Tue, 08 Oct 2019 22:16:38 +0200 [thread overview]
Message-ID: <9c49ec27489333d7f27831de19e9d1c9cd65eeee.camel@sipsolutions.net> (raw)
In-Reply-To: <193168d4-6466-60a4-bc89-c4a44e84ac46@gmail.com> (sfid-20191008_205058_831848_E2C7643E)
On Tue, 2019-10-08 at 13:50 -0500, Denis Kenzior wrote:
> Hi Johannes,
>
> > > But they shouldn't change due a mac address change? I wonder if we can
> > > further relax the requirements to allow mac change if
> > > NL80211_SCAN_FLAG_RANDOM_ADDR was used?
> >
> > No, at least with HW scan that would completely confuse the driver -
> > since from the driver's POV we'd remove the interface it's currently
> > managing the scan for.
>
> So help me understand this better.
include/net/mac80211.h:
int (*hw_scan)(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
struct ieee80211_scan_request *req);
How is it difficult to understand that with an API like that, it might
not be a good idea to remove the vif from the driver while it's
scanning?
> Just by virtue of copying the new
> mac into sdata->vif.addr
That's not what happens?
johannes
next prev parent reply other threads:[~2019-10-08 20:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 19:59 [PATCH 1/2] nl80211: Add LIVE_ADDR_CHANGE feature James Prestwood
2019-09-13 19:59 ` [PATCH 2/2] mac80211: Support LIVE_ADDRESS_CHANGE feature James Prestwood
2019-10-04 11:56 ` Johannes Berg
2019-10-04 16:25 ` James Prestwood
2019-10-04 16:42 ` James Prestwood
2019-10-07 21:16 ` Johannes Berg
2019-10-08 15:37 ` Denis Kenzior
2019-10-08 15:52 ` Johannes Berg
2019-10-08 15:53 ` Denis Kenzior
2019-10-08 16:24 ` Johannes Berg
2019-10-08 16:23 ` Denis Kenzior
2019-10-08 17:08 ` Johannes Berg
2019-10-08 18:50 ` Denis Kenzior
2019-10-08 20:16 ` Johannes Berg [this message]
2019-10-08 20:55 ` Denis Kenzior
2019-10-10 15:18 ` Johannes Berg
2019-10-07 21:11 ` Johannes Berg
2019-10-08 15:28 ` Denis Kenzior
2019-10-08 15:49 ` Johannes Berg
2019-09-13 20:48 ` [PATCH 1/2] nl80211: Add LIVE_ADDR_CHANGE feature Johannes Berg
2019-09-13 20:56 ` James Prestwood
2019-09-13 21:01 ` Johannes Berg
2019-09-13 21:14 ` James Prestwood
2019-09-17 20:09 ` James Prestwood
2019-10-01 9:14 ` Johannes Berg
2019-10-08 22:13 ` James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c49ec27489333d7f27831de19e9d1c9cd65eeee.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=denkenz@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=prestwoj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).