* [PATCH net 04/16] nl802154: add missing attribute validation [not found] <20200303050526.4088735-1-kuba@kernel.org> @ 2020-03-03 5:05 ` Jakub Kicinski 2020-03-03 15:38 ` Stefan Schmidt 2020-03-03 5:05 ` [PATCH net 05/16] nl802154: add missing attribute validation for dev_type Jakub Kicinski 1 sibling, 1 reply; 5+ messages in thread From: Jakub Kicinski @ 2020-03-03 5:05 UTC (permalink / raw) To: davem Cc: netdev, Jakub Kicinski, Alexander Aring, Stefan Schmidt, Dmitry Eremin-Solenikov, Sergey Lapin, linux-wpan Add missing attribute validation for several u8 types. Fixes: 2c21d11518b6 ("net: add NL802154 interface for configuration of 802.15.4 devices") Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- CC: Alexander Aring <alex.aring@gmail.com> CC: Stefan Schmidt <stefan@datenfreihafen.org> CC: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> CC: Sergey Lapin <slapin@ossfans.org> CC: linux-wpan@vger.kernel.org --- net/ieee802154/nl_policy.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/net/ieee802154/nl_policy.c b/net/ieee802154/nl_policy.c index 2c7a38d76a3a..824e7e84014c 100644 --- a/net/ieee802154/nl_policy.c +++ b/net/ieee802154/nl_policy.c @@ -21,6 +21,11 @@ const struct nla_policy ieee802154_policy[IEEE802154_ATTR_MAX + 1] = { [IEEE802154_ATTR_HW_ADDR] = { .type = NLA_HW_ADDR, }, [IEEE802154_ATTR_PAN_ID] = { .type = NLA_U16, }, [IEEE802154_ATTR_CHANNEL] = { .type = NLA_U8, }, + [IEEE802154_ATTR_BCN_ORD] = { .type = NLA_U8, }, + [IEEE802154_ATTR_SF_ORD] = { .type = NLA_U8, }, + [IEEE802154_ATTR_PAN_COORD] = { .type = NLA_U8, }, + [IEEE802154_ATTR_BAT_EXT] = { .type = NLA_U8, }, + [IEEE802154_ATTR_COORD_REALIGN] = { .type = NLA_U8, }, [IEEE802154_ATTR_PAGE] = { .type = NLA_U8, }, [IEEE802154_ATTR_COORD_SHORT_ADDR] = { .type = NLA_U16, }, [IEEE802154_ATTR_COORD_HW_ADDR] = { .type = NLA_HW_ADDR, }, -- 2.24.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net 04/16] nl802154: add missing attribute validation 2020-03-03 5:05 ` [PATCH net 04/16] nl802154: add missing attribute validation Jakub Kicinski @ 2020-03-03 15:38 ` Stefan Schmidt 0 siblings, 0 replies; 5+ messages in thread From: Stefan Schmidt @ 2020-03-03 15:38 UTC (permalink / raw) To: Jakub Kicinski, davem Cc: netdev, Alexander Aring, Dmitry Eremin-Solenikov, Sergey Lapin, linux-wpan Hello. On 03.03.20 06:05, Jakub Kicinski wrote: > Add missing attribute validation for several u8 types. > > Fixes: 2c21d11518b6 ("net: add NL802154 interface for configuration of 802.15.4 devices") > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > --- > CC: Alexander Aring <alex.aring@gmail.com> > CC: Stefan Schmidt <stefan@datenfreihafen.org> > CC: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> > CC: Sergey Lapin <slapin@ossfans.org> > CC: linux-wpan@vger.kernel.org > --- > net/ieee802154/nl_policy.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/net/ieee802154/nl_policy.c b/net/ieee802154/nl_policy.c > index 2c7a38d76a3a..824e7e84014c 100644 > --- a/net/ieee802154/nl_policy.c > +++ b/net/ieee802154/nl_policy.c > @@ -21,6 +21,11 @@ const struct nla_policy ieee802154_policy[IEEE802154_ATTR_MAX + 1] = { > [IEEE802154_ATTR_HW_ADDR] = { .type = NLA_HW_ADDR, }, > [IEEE802154_ATTR_PAN_ID] = { .type = NLA_U16, }, > [IEEE802154_ATTR_CHANNEL] = { .type = NLA_U8, }, > + [IEEE802154_ATTR_BCN_ORD] = { .type = NLA_U8, }, > + [IEEE802154_ATTR_SF_ORD] = { .type = NLA_U8, }, > + [IEEE802154_ATTR_PAN_COORD] = { .type = NLA_U8, }, > + [IEEE802154_ATTR_BAT_EXT] = { .type = NLA_U8, }, > + [IEEE802154_ATTR_COORD_REALIGN] = { .type = NLA_U8, }, > [IEEE802154_ATTR_PAGE] = { .type = NLA_U8, }, > [IEEE802154_ATTR_COORD_SHORT_ADDR] = { .type = NLA_U16, }, > [IEEE802154_ATTR_COORD_HW_ADDR] = { .type = NLA_HW_ADDR, }, > Acked-by: Stefan Schmidt <stefan@datenfreihafen.org> regards Stefan Schmidt ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH net 05/16] nl802154: add missing attribute validation for dev_type [not found] <20200303050526.4088735-1-kuba@kernel.org> 2020-03-03 5:05 ` [PATCH net 04/16] nl802154: add missing attribute validation Jakub Kicinski @ 2020-03-03 5:05 ` Jakub Kicinski 2020-03-03 15:39 ` Stefan Schmidt 1 sibling, 1 reply; 5+ messages in thread From: Jakub Kicinski @ 2020-03-03 5:05 UTC (permalink / raw) To: davem Cc: netdev, Jakub Kicinski, Alexander Aring, Stefan Schmidt, alex.bluesman.smirnov, linux-wpan Add missing attribute type validation for IEEE802154_ATTR_DEV_TYPE to the netlink policy. Fixes: 90c049b2c6ae ("ieee802154: interface type to be added") Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- CC: Alexander Aring <alex.aring@gmail.com> CC: Stefan Schmidt <stefan@datenfreihafen.org> CC: alex.bluesman.smirnov@gmail.com CC: linux-wpan@vger.kernel.org --- net/ieee802154/nl_policy.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ieee802154/nl_policy.c b/net/ieee802154/nl_policy.c index 824e7e84014c..0672b2f01586 100644 --- a/net/ieee802154/nl_policy.c +++ b/net/ieee802154/nl_policy.c @@ -27,6 +27,7 @@ const struct nla_policy ieee802154_policy[IEEE802154_ATTR_MAX + 1] = { [IEEE802154_ATTR_BAT_EXT] = { .type = NLA_U8, }, [IEEE802154_ATTR_COORD_REALIGN] = { .type = NLA_U8, }, [IEEE802154_ATTR_PAGE] = { .type = NLA_U8, }, + [IEEE802154_ATTR_DEV_TYPE] = { .type = NLA_U8, }, [IEEE802154_ATTR_COORD_SHORT_ADDR] = { .type = NLA_U16, }, [IEEE802154_ATTR_COORD_HW_ADDR] = { .type = NLA_HW_ADDR, }, [IEEE802154_ATTR_COORD_PAN_ID] = { .type = NLA_U16, }, -- 2.24.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net 05/16] nl802154: add missing attribute validation for dev_type 2020-03-03 5:05 ` [PATCH net 05/16] nl802154: add missing attribute validation for dev_type Jakub Kicinski @ 2020-03-03 15:39 ` Stefan Schmidt 2020-03-03 17:55 ` Jakub Kicinski 0 siblings, 1 reply; 5+ messages in thread From: Stefan Schmidt @ 2020-03-03 15:39 UTC (permalink / raw) To: Jakub Kicinski, davem Cc: netdev, Alexander Aring, alex.bluesman.smirnov, linux-wpan Hello. On 03.03.20 06:05, Jakub Kicinski wrote: > Add missing attribute type validation for IEEE802154_ATTR_DEV_TYPE > to the netlink policy. > > Fixes: 90c049b2c6ae ("ieee802154: interface type to be added") > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > --- > CC: Alexander Aring <alex.aring@gmail.com> > CC: Stefan Schmidt <stefan@datenfreihafen.org> > CC: alex.bluesman.smirnov@gmail.com > CC: linux-wpan@vger.kernel.org > --- > net/ieee802154/nl_policy.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/ieee802154/nl_policy.c b/net/ieee802154/nl_policy.c > index 824e7e84014c..0672b2f01586 100644 > --- a/net/ieee802154/nl_policy.c > +++ b/net/ieee802154/nl_policy.c > @@ -27,6 +27,7 @@ const struct nla_policy ieee802154_policy[IEEE802154_ATTR_MAX + 1] = { > [IEEE802154_ATTR_BAT_EXT] = { .type = NLA_U8, }, > [IEEE802154_ATTR_COORD_REALIGN] = { .type = NLA_U8, }, > [IEEE802154_ATTR_PAGE] = { .type = NLA_U8, }, > + [IEEE802154_ATTR_DEV_TYPE] = { .type = NLA_U8, }, > [IEEE802154_ATTR_COORD_SHORT_ADDR] = { .type = NLA_U16, }, > [IEEE802154_ATTR_COORD_HW_ADDR] = { .type = NLA_HW_ADDR, }, > [IEEE802154_ATTR_COORD_PAN_ID] = { .type = NLA_U16, }, > The reason to split this off from the patch before is to have the Fixes tag differently to point to its origin? Might be a bit to much work for this little subsystem, but you did it already, so: Acked-by: Stefan Schmidt <stefan@datenfreihafen.org> regards Stefan Schmidt ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net 05/16] nl802154: add missing attribute validation for dev_type 2020-03-03 15:39 ` Stefan Schmidt @ 2020-03-03 17:55 ` Jakub Kicinski 0 siblings, 0 replies; 5+ messages in thread From: Jakub Kicinski @ 2020-03-03 17:55 UTC (permalink / raw) To: Stefan Schmidt Cc: davem, netdev, Alexander Aring, alex.bluesman.smirnov, linux-wpan On Tue, 3 Mar 2020 16:39:55 +0100 Stefan Schmidt wrote: > On 03.03.20 06:05, Jakub Kicinski wrote: > > Add missing attribute type validation for IEEE802154_ATTR_DEV_TYPE > > to the netlink policy. > > > > Fixes: 90c049b2c6ae ("ieee802154: interface type to be added") > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > > diff --git a/net/ieee802154/nl_policy.c b/net/ieee802154/nl_policy.c > > index 824e7e84014c..0672b2f01586 100644 > > --- a/net/ieee802154/nl_policy.c > > +++ b/net/ieee802154/nl_policy.c > > @@ -27,6 +27,7 @@ const struct nla_policy ieee802154_policy[IEEE802154_ATTR_MAX + 1] = { > > [IEEE802154_ATTR_BAT_EXT] = { .type = NLA_U8, }, > > [IEEE802154_ATTR_COORD_REALIGN] = { .type = NLA_U8, }, > > [IEEE802154_ATTR_PAGE] = { .type = NLA_U8, }, > > + [IEEE802154_ATTR_DEV_TYPE] = { .type = NLA_U8, }, > > [IEEE802154_ATTR_COORD_SHORT_ADDR] = { .type = NLA_U16, }, > > [IEEE802154_ATTR_COORD_HW_ADDR] = { .type = NLA_HW_ADDR, }, > > [IEEE802154_ATTR_COORD_PAN_ID] = { .type = NLA_U16, }, > > > > The reason to split this off from the patch before is to have the Fixes > tag differently to point to its origin? Yup, plus they should hopefully be in chronological order to avoid conflicts :) > Might be a bit to much work for this little subsystem, but you did it > already, so: > > Acked-by: Stefan Schmidt <stefan@datenfreihafen.org> Thanks! ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-03 18:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200303050526.4088735-1-kuba@kernel.org>
2020-03-03 5:05 ` [PATCH net 04/16] nl802154: add missing attribute validation Jakub Kicinski
2020-03-03 15:38 ` Stefan Schmidt
2020-03-03 5:05 ` [PATCH net 05/16] nl802154: add missing attribute validation for dev_type Jakub Kicinski
2020-03-03 15:39 ` Stefan Schmidt
2020-03-03 17:55 ` Jakub Kicinski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).