From: Wei Yang <weiyang@linux.vnet.ibm.com>
To: Gavin Shan <gwshan@linux.vnet.ibm.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
Wei Yang <weiyang@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V3 6/9] powerpc/powernv: create/release eeh_dev for VF
Date: Tue, 12 May 2015 16:06:43 +0800 [thread overview]
Message-ID: <20150512080643.GC16788@richard> (raw)
In-Reply-To: <20150511024856.GB8816@gwshan>
On Mon, May 11, 2015 at 12:48:56PM +1000, Gavin Shan wrote:
>On Mon, May 04, 2015 at 03:07:35PM +0800, Wei Yang wrote:
>
>Please order this patch and PATCH[5] because EEH device is expected to
>be created before EEH PE.
>
>>EEH on powerpc platform needs eeh_dev structure to track the pci device
> ^^^
> PCI
>
>>status. Since VFs are created/released dynamically, VF's eeh_dev is also
>>dynamically created/released in system.
>>
>>This patch creates/removes eeh_dev when pci_dn is created/removed for VFs,
>>and marks it with EEH_DEV_VF type.
>>
>>Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com>
>>---
>> arch/powerpc/include/asm/eeh.h | 7 +++++++
>> arch/powerpc/kernel/eeh.c | 4 ++++
>> arch/powerpc/kernel/eeh_dev.c | 20 ++++++++++++++++++++
>> arch/powerpc/kernel/pci_dn.c | 7 +++++++
>> 4 files changed, 38 insertions(+)
>>
>>diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h
>>index 56e8cd9..2067de4 100644
>>--- a/arch/powerpc/include/asm/eeh.h
>>+++ b/arch/powerpc/include/asm/eeh.h
>>@@ -124,6 +124,7 @@ static inline bool eeh_pe_passed(struct eeh_pe *pe)
>> #define EEH_DEV_NO_HANDLER (1 << 8) /* No error handler */
>> #define EEH_DEV_SYSFS (1 << 9) /* Sysfs created */
>> #define EEH_DEV_REMOVED (1 << 10) /* Removed permanently */
>>+#define EEH_DEV_VF (1 << 11) /* VF port */
>>
>
>Why you need this flag? I guess "edev->physfn" can be used to distinguish
>it's a normal or VF eeh_dev.
>
Just like we have EEH_DEV_BRIDGE and EEH_DEV_DS_PORT, I use the flag
EEH_DEV_VF to mark it a VF eeh_dev.
--
Richard Yang
Help you, Help me
next prev parent reply other threads:[~2015-05-12 8:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 7:07 [PATCH V3 0/9] VF EEH on Power8 Wei Yang
2015-05-04 7:07 ` [PATCH V3 1/9] pci/iov: rename and export virtfn_add/virtfn_remove Wei Yang
2015-05-11 2:13 ` Gavin Shan
2015-05-04 7:07 ` [PATCH V3 2/9] powerpc/pci_dn: cache vf_index in pci_dn Wei Yang
2015-05-11 2:21 ` Gavin Shan
2015-05-11 5:54 ` Wei Yang
2015-05-12 6:15 ` Gavin Shan
2015-05-12 7:29 ` Wei Yang
2015-05-04 7:07 ` [PATCH V3 3/9] powerpc/pci: remove PCI devices in reverse order Wei Yang
2015-05-04 7:07 ` [PATCH V3 4/9] powerpc/eeh: cache address range just for normal device Wei Yang
2015-05-04 7:07 ` [PATCH V3 5/9] powerpc/eeh: create EEH_PE_VF for VF PE Wei Yang
2015-05-11 2:37 ` Gavin Shan
2015-05-11 6:25 ` Wei Yang
2015-05-12 6:28 ` Gavin Shan
2015-05-12 7:52 ` Wei Yang
2015-05-04 7:07 ` [PATCH V3 6/9] powerpc/powernv: create/release eeh_dev for VF Wei Yang
2015-05-11 2:48 ` Gavin Shan
2015-05-12 8:06 ` Wei Yang [this message]
2015-05-12 23:09 ` Gavin Shan
2015-05-04 7:07 ` [PATCH V3 7/9] powerpc/powernv: Support EEH reset for VFs Wei Yang
2015-05-11 3:03 ` Gavin Shan
2015-05-04 7:07 ` [PATCH V3 8/9] powerpc/powernv: Support PCI config restore " Wei Yang
2015-05-11 4:22 ` Gavin Shan
2015-05-12 1:31 ` Wei Yang
2015-05-12 6:34 ` Gavin Shan
2015-05-12 8:16 ` Wei Yang
2015-05-12 23:16 ` Gavin Shan
2015-05-04 7:07 ` [PATCH V3 9/9] powerpc/eeh: handle VF PE properly Wei Yang
2015-05-13 1:16 ` Gavin Shan
2015-05-14 9:35 ` Wei Yang
2015-05-14 12:15 ` Gavin Shan
2015-05-14 10:02 ` Wei Yang
2015-05-14 12:30 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150512080643.GC16788@richard \
--to=weiyang@linux.vnet.ibm.com \
--cc=bhelgaas@google.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).