From: Wei Yang <weiyang@linux.vnet.ibm.com>
To: Gavin Shan <gwshan@linux.vnet.ibm.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
Wei Yang <weiyang@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V3 9/9] powerpc/eeh: handle VF PE properly
Date: Thu, 14 May 2015 18:02:50 +0800 [thread overview]
Message-ID: <20150514100250.GB12847@richard> (raw)
In-Reply-To: <20150513011630.GA8973@gwshan>
On Wed, May 13, 2015 at 11:16:30AM +1000, Gavin Shan wrote:
>> * Actually, we should remove the PCI bridges as well.
>>@@ -416,7 +450,7 @@ static void *eeh_rmv_device(void *data, void *userdata)
>> driver = eeh_pcid_get(dev);
>> if (driver) {
>> eeh_pcid_put(dev);
>>- if (driver->err_handler)
>>+ if (removed && driver->err_handler)
>> return NULL;
>> }
>>
>>@@ -425,11 +459,21 @@ static void *eeh_rmv_device(void *data, void *userdata)
>> pci_name(dev));
>> edev->bus = dev->bus;
>> edev->mode |= EEH_DEV_DISCONNECTED;
>>- (*removed)++;
>>-
>>- pci_lock_rescan_remove();
>>- pci_stop_and_remove_bus_device(dev);
>>- pci_unlock_rescan_remove();
>>+ if (removed)
>>+ (*removed)++;
>>+
>>+#ifdef CONFIG_PCI_IOV
>>+ if (edev->mode & EEH_DEV_VF) {
>>+ pci_iov_virtfn_remove(edev->physfn, pdn->vf_index, 0);
>>+ edev->pdev = NULL;
>>+ pdn->pe_number = IODA_INVALID_PE;
>
>Setting the PE number to invalid one seems not correct because the PE
>is still consumed by the VF's RID.
>
In commit 781a868f3136, we introduce the check of pdn->pe_number in
pnv_pci_dma_dev_setup(). Since VFs are create/released dynamically, we need to
delay the bind between PE and the device. Then to avoid rebind it, we check
the pdn->pe_number. The WARN_ON() is what you suggested.
So if don't clear the pe_number here, we break that rule.
--
Richard Yang
Help you, Help me
next prev parent reply other threads:[~2015-05-14 10:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 7:07 [PATCH V3 0/9] VF EEH on Power8 Wei Yang
2015-05-04 7:07 ` [PATCH V3 1/9] pci/iov: rename and export virtfn_add/virtfn_remove Wei Yang
2015-05-11 2:13 ` Gavin Shan
2015-05-04 7:07 ` [PATCH V3 2/9] powerpc/pci_dn: cache vf_index in pci_dn Wei Yang
2015-05-11 2:21 ` Gavin Shan
2015-05-11 5:54 ` Wei Yang
2015-05-12 6:15 ` Gavin Shan
2015-05-12 7:29 ` Wei Yang
2015-05-04 7:07 ` [PATCH V3 3/9] powerpc/pci: remove PCI devices in reverse order Wei Yang
2015-05-04 7:07 ` [PATCH V3 4/9] powerpc/eeh: cache address range just for normal device Wei Yang
2015-05-04 7:07 ` [PATCH V3 5/9] powerpc/eeh: create EEH_PE_VF for VF PE Wei Yang
2015-05-11 2:37 ` Gavin Shan
2015-05-11 6:25 ` Wei Yang
2015-05-12 6:28 ` Gavin Shan
2015-05-12 7:52 ` Wei Yang
2015-05-04 7:07 ` [PATCH V3 6/9] powerpc/powernv: create/release eeh_dev for VF Wei Yang
2015-05-11 2:48 ` Gavin Shan
2015-05-12 8:06 ` Wei Yang
2015-05-12 23:09 ` Gavin Shan
2015-05-04 7:07 ` [PATCH V3 7/9] powerpc/powernv: Support EEH reset for VFs Wei Yang
2015-05-11 3:03 ` Gavin Shan
2015-05-04 7:07 ` [PATCH V3 8/9] powerpc/powernv: Support PCI config restore " Wei Yang
2015-05-11 4:22 ` Gavin Shan
2015-05-12 1:31 ` Wei Yang
2015-05-12 6:34 ` Gavin Shan
2015-05-12 8:16 ` Wei Yang
2015-05-12 23:16 ` Gavin Shan
2015-05-04 7:07 ` [PATCH V3 9/9] powerpc/eeh: handle VF PE properly Wei Yang
2015-05-13 1:16 ` Gavin Shan
2015-05-14 9:35 ` Wei Yang
2015-05-14 12:15 ` Gavin Shan
2015-05-14 10:02 ` Wei Yang [this message]
2015-05-14 12:30 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150514100250.GB12847@richard \
--to=weiyang@linux.vnet.ibm.com \
--cc=bhelgaas@google.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).