* [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board
@ 2013-07-08 7:16 Haijun Zhang
2013-07-08 7:16 ` [PATCH 3/4 V2] mmc: esdhc: Add quirks to support T4240QDS board Haijun Zhang
2013-07-08 17:14 ` [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board Scott Wood
0 siblings, 2 replies; 13+ messages in thread
From: Haijun Zhang @ 2013-07-08 7:16 UTC (permalink / raw)
To: linux-mmc, linuxppc-dev
Cc: r39252, AFLEMING, cbouatmailru, scottwood, cjb, Haijun Zhang
In order to make a difference between different T4240 board.
Specify T4240QDS board the unique compatible flags for t4240qds
eSDHC host.
Signed-off-by: Haijun Zhang <Haijun.Zhang@freescale.com>
---
arch/powerpc/boot/dts/fsl/t4240si-post.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi b/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
index bd611a9..08b47d0 100644
--- a/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
@@ -397,7 +397,7 @@
/include/ "qoriq-esdhc-0.dtsi"
sdhc@114000 {
- compatible = "fsl,t4240-esdhc", "fsl,esdhc";
+ compatible = "fsl,t4240qds-esdhc", "fsl,esdhc";
sdhci,auto-cmd12;
};
/include/ "qoriq-i2c-0.dtsi"
--
1.8.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 3/4 V2] mmc: esdhc: Add quirks to support T4240QDS board
2013-07-08 7:16 [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board Haijun Zhang
@ 2013-07-08 7:16 ` Haijun Zhang
2013-07-08 17:18 ` Scott Wood
2013-07-08 17:14 ` [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board Scott Wood
1 sibling, 1 reply; 13+ messages in thread
From: Haijun Zhang @ 2013-07-08 7:16 UTC (permalink / raw)
To: linux-mmc, linuxppc-dev
Cc: r39252, AFLEMING, cbouatmailru, scottwood, cjb, Haijun Zhang
On T4240QDS board controllers has an unusable ADMA engine, so use SDMA instead.
Also 3.0v is support on T4240QDS board even if the capacity detailed only 1.8v
support. Without this quirk SD card will declare voltage not support and
Signed-off-by: Haijun Zhang <haijun.zhang@freescale.com>
---
changes for v2:
- Change the compatible for t4240qds board
drivers/mmc/host/sdhci-pltfm.c | 7 ++++++-
drivers/mmc/host/sdhci.c | 3 +++
include/linux/mmc/sdhci.h | 2 ++
3 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
index e2065a4..800e82f 100644
--- a/drivers/mmc/host/sdhci-pltfm.c
+++ b/drivers/mmc/host/sdhci-pltfm.c
@@ -92,9 +92,14 @@ void sdhci_get_of_property(struct platform_device *pdev)
if (of_device_is_compatible(np, "fsl,p2020-rev1-esdhc"))
host->quirks |= SDHCI_QUIRK_BROKEN_DMA;
+ if (of_device_is_compatible(np, "fsl,t4240qds-esdhc")) {
+ host->quirks |= SDHCI_QUIRK_BROKEN_ADMA;
+ host->quirks2 |= SDHCI_QUIRK2_CIRCUIT_SUPPORT_VS30;
+ }
+
if (of_device_is_compatible(np, "fsl,p2020-esdhc") ||
of_device_is_compatible(np, "fsl,p1010-esdhc") ||
- of_device_is_compatible(np, "fsl,t4240-esdhc") ||
+ of_device_is_compatible(np, "fsl,t4240qds-esdhc") ||
of_device_is_compatible(np, "fsl,mpc8536-esdhc"))
host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index a78bd4f..de7fa81 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -2797,6 +2797,9 @@ int sdhci_add_host(struct sdhci_host *host)
host->caps1 :
sdhci_readl(host, SDHCI_CAPABILITIES_1);
+ if (host->quirks2 & SDHCI_QUIRK2_CIRCUIT_SUPPORT_VS30)
+ caps[0] = caps[0] | SDHCI_CAN_VDD_300;
+
if (host->quirks & SDHCI_QUIRK_FORCE_DMA)
host->flags |= SDHCI_USE_SDMA;
else if (!(caps[0] & SDHCI_CAN_DO_SDMA))
diff --git a/include/linux/mmc/sdhci.h b/include/linux/mmc/sdhci.h
index e3c6a74..dc608d7 100644
--- a/include/linux/mmc/sdhci.h
+++ b/include/linux/mmc/sdhci.h
@@ -98,6 +98,8 @@ struct sdhci_host {
#define SDHCI_QUIRK2_CARD_ON_NEEDS_BUS_ON (1<<4)
/* Controller has a non-standard host control register */
#define SDHCI_QUIRK2_BROKEN_HOST_CONTROL (1<<5)
+/* The host support VS300 even if the capacity detailed not */
+#define SDHCI_QUIRK2_CIRCUIT_SUPPORT_VS30 (1<<6)
int irq; /* Device IRQ */
void __iomem *ioaddr; /* Mapped address */
--
1.8.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board
2013-07-08 7:16 [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board Haijun Zhang
2013-07-08 7:16 ` [PATCH 3/4 V2] mmc: esdhc: Add quirks to support T4240QDS board Haijun Zhang
@ 2013-07-08 17:14 ` Scott Wood
2013-07-09 6:04 ` 答复: " Zhang Haijun-B42677
1 sibling, 1 reply; 13+ messages in thread
From: Scott Wood @ 2013-07-08 17:14 UTC (permalink / raw)
To: Haijun Zhang
Cc: linux-mmc, r39252, AFLEMING, cbouatmailru, cjb, linuxppc-dev,
Haijun Zhang
On 07/08/2013 02:16:03 AM, Haijun Zhang wrote:
> In order to make a difference between different T4240 board.
> Specify T4240QDS board the unique compatible flags for t4240qds
> eSDHC host.
>=20
> Signed-off-by: Haijun Zhang <Haijun.Zhang@freescale.com>
> ---
> arch/powerpc/boot/dts/fsl/t4240si-post.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi =20
> b/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
> index bd611a9..08b47d0 100644
> --- a/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
> @@ -397,7 +397,7 @@
>=20
> /include/ "qoriq-esdhc-0.dtsi"
> sdhc@114000 {
> - compatible =3D "fsl,t4240-esdhc", "fsl,esdhc";
> + compatible =3D "fsl,t4240qds-esdhc", "fsl,esdhc";
> sdhci,auto-cmd12;
> };
NACK. This node is describing the sdhc block of the t4240 SoC. What =20
board you stick it in doesn't change what it is.
Plus, what about users with old device trees?
-Scott=
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 3/4 V2] mmc: esdhc: Add quirks to support T4240QDS board
2013-07-08 7:16 ` [PATCH 3/4 V2] mmc: esdhc: Add quirks to support T4240QDS board Haijun Zhang
@ 2013-07-08 17:18 ` Scott Wood
2013-07-12 18:35 ` Anton Vorontsov
0 siblings, 1 reply; 13+ messages in thread
From: Scott Wood @ 2013-07-08 17:18 UTC (permalink / raw)
To: Haijun Zhang
Cc: linux-mmc, r39252, AFLEMING, cbouatmailru, cjb, linuxppc-dev,
Haijun Zhang
On 07/08/2013 02:16:04 AM, Haijun Zhang wrote:
> On T4240QDS board controllers has an unusable ADMA engine, so use =20
> SDMA instead.
> Also 3.0v is support on T4240QDS board even if the capacity detailed =20
> only 1.8v
> support. Without this quirk SD card will declare voltage not support =20
> and
>=20
> Signed-off-by: Haijun Zhang <haijun.zhang@freescale.com>
...and what?
Why is this board-specific? Isn't the controller part of the SoC, not =20
part of the board? If it really is board-specific, could you be more =20
detailed about why (ideally with an erratum number), and check the =20
toplevel board compatible (or get the information from platform code) =20
rather than modify the device tree?
-Scott=
^ permalink raw reply [flat|nested] 13+ messages in thread
* 答复: [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board
2013-07-08 17:14 ` [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board Scott Wood
@ 2013-07-09 6:04 ` Zhang Haijun-B42677
2013-07-09 20:04 ` Scott Wood
0 siblings, 1 reply; 13+ messages in thread
From: Zhang Haijun-B42677 @ 2013-07-09 6:04 UTC (permalink / raw)
To: Wood Scott-B07421
Cc: linux-mmc, Wrobel Heinz-R39252, Fleming Andy-AFLEMING,
cbouatmailru, cjb, linuxppc-dev
CgpSZWdhcmRzICYgVGhhbmtzCgpIYWlqdW4uCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fCreivP7IyzogV29vZCBTY290dC1CMDc0MjEKt6LLzcqxvOQ6IDIwMTPE6jfU
wjjI1SAxNzoxNArK1bz+yMs6IFpoYW5nIEhhaWp1bi1CNDI2NzcKs63LzTogbGludXgtbW1jQHZn
ZXIua2VybmVsLm9yZzsgbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7IGNib3VhdG1haWxy
dUBnbWFpbC5jb207IGNqYkBsYXB0b3Aub3JnOyBGbGVtaW5nIEFuZHktQUZMRU1JTkc7IFdyb2Jl
bCBIZWluei1SMzkyNTI7IFpoYW5nIEhhaWp1bi1CNDI2NzcK1vfM4jogUmU6IFtQQVRDSF0gUG93
ZXJwYy90NDI0MDogY2hhbmdlIHRoZSBjb21wYXRpYmxlIGZsYWdzIGZvciB0NDI0MHFkcyBib2Fy
ZAoKT24gMDcvMDgvMjAxMyAwMjoxNjowMyBBTSwgSGFpanVuIFpoYW5nIHdyb3RlOgo+IEluIG9y
ZGVyIHRvIG1ha2UgYSBkaWZmZXJlbmNlIGJldHdlZW4gZGlmZmVyZW50IFQ0MjQwIGJvYXJkLgo+
IFNwZWNpZnkgVDQyNDBRRFMgYm9hcmQgdGhlIHVuaXF1ZSBjb21wYXRpYmxlIGZsYWdzIGZvciB0
NDI0MHFkcwo+IGVTREhDIGhvc3QuCj4KPiBTaWduZWQtb2ZmLWJ5OiBIYWlqdW4gWmhhbmcgPEhh
aWp1bi5aaGFuZ0BmcmVlc2NhbGUuY29tPgo+IC0tLQo+ICBhcmNoL3Bvd2VycGMvYm9vdC9kdHMv
ZnNsL3Q0MjQwc2ktcG9zdC5kdHNpIHwgMiArLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRp
b24oKyksIDEgZGVsZXRpb24oLSkKPgo+IGRpZmYgLS1naXQgYS9hcmNoL3Bvd2VycGMvYm9vdC9k
dHMvZnNsL3Q0MjQwc2ktcG9zdC5kdHNpCj4gYi9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvZnNsL3Q0
MjQwc2ktcG9zdC5kdHNpCj4gaW5kZXggYmQ2MTFhOS4uMDhiNDdkMCAxMDA2NDQKPiAtLS0gYS9h
cmNoL3Bvd2VycGMvYm9vdC9kdHMvZnNsL3Q0MjQwc2ktcG9zdC5kdHNpCj4gKysrIGIvYXJjaC9w
b3dlcnBjL2Jvb3QvZHRzL2ZzbC90NDI0MHNpLXBvc3QuZHRzaQo+IEBAIC0zOTcsNyArMzk3LDcg
QEAKPgo+ICAvaW5jbHVkZS8gInFvcmlxLWVzZGhjLTAuZHRzaSIKPiAgICAgICBzZGhjQDExNDAw
MCB7Cj4gLSAgICAgICAgICAgICBjb21wYXRpYmxlID0gImZzbCx0NDI0MC1lc2RoYyIsICJmc2ws
ZXNkaGMiOwo+ICsgICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJmc2wsdDQyNDBxZHMtZXNkaGMi
LCAiZnNsLGVzZGhjIjsKPiAgICAgICAgICAgICAgIHNkaGNpLGF1dG8tY21kMTI7Cj4gICAgICAg
fTsKCk5BQ0suICBUaGlzIG5vZGUgaXMgZGVzY3JpYmluZyB0aGUgc2RoYyBibG9jayBvZiB0aGUg
dDQyNDAgU29DLiAgV2hhdApib2FyZCB5b3Ugc3RpY2sgaXQgaW4gZG9lc24ndCBjaGFuZ2Ugd2hh
dCBpdCBpcy4KClBsdXMsIHdoYXQgYWJvdXQgdXNlcnMgd2l0aCBvbGQgZGV2aWNlIHRyZWVzPwoK
Q3VycmVudGx5IG5vIHVzZXJzIHVzZSB0aGlzIGlwIGJsb2NrIGV4Y2VwdCBlc2RoYyBkcml2ZXIu
CgpIb3cgYWJvdXQgY2hhbmdlIHRoaXMgaW4gYXJjaC9wb3dlcnBjL2Jvb3QvZHRzL3Q0MjQwcWRz
LmR0cwoKKysrIGIvYXJjaC9wb3dlcnBjL2Jvb3QvZHRzL3Q0MjQwcWRzLmR0cwpAQCAtMTE3LDYg
KzExNywxMCBAQAogICAgICAgICAgICAgICAgICAgICAgICB9OwogICAgICAgICAgICAgICAgfTsK
IAogICAgICAgICAgICAgICBzZGhjQDExNDAwMCB7CiAgICAgICAgICAgICAgICAgICAgICBjb21w
YXRpYmxlID0gImZzbCx0NDI0MC1lc2RoYyIsICJmc2wsZXNkaGMiOwogICAgICAgICAgICAgICB9
OwoKICAgICAgICAgICAgICAgaTJjQDExODAwMCB7CiAgICAgICAgICAgIAoKKysrIGIvYXJjaC9w
b3dlcnBjL2Jvb3QvZHRzL3Q0MjQwcWRzLmR0cwpAQCAtMTE3LDYgKzExNywxMCBAQAogICAgICAg
ICAgICAgICAgICAgICAgICB9OwogICAgICAgICAgICAgICAgfTsKIAorICAgICAgICAgICAgICAg
c2RoY0AxMTQwMDAgeworICAgICAgICAgICAgICAgICAgICAgICBjb21wYXRpYmxlID0gImZzbCx0
NDI0MHFkcy1lc2RoYyIsICJmc2wsZXNkaGMiOworICAgICAgICAgICAgICAgfTsKKwogICAgICAg
ICAgICAgICAgaTJjQDExODAwMCB7CiAgICAgICAgICAgIAoKLVNjb3R0Cg==
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: 答复: [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board
2013-07-09 6:04 ` 答复: " Zhang Haijun-B42677
@ 2013-07-09 20:04 ` Scott Wood
2013-07-10 3:41 ` Zhang Haijun-B42677
0 siblings, 1 reply; 13+ messages in thread
From: Scott Wood @ 2013-07-09 20:04 UTC (permalink / raw)
To: Zhang Haijun-B42677
Cc: Wood Scott-B07421, linux-mmc, Wrobel Heinz-R39252,
Fleming Andy-AFLEMING, cbouatmailru, cjb, linuxppc-dev
On 07/09/2013 01:04:01 AM, Zhang Haijun-B42677 wrote:
>=20
>=20
> Regards & Thanks
>=20
> Haijun.
>=20
> ________________________________________
> =E5=8F=91=E4=BB=B6=E4=BA=BA: Wood Scott-B07421
> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2013=E5=B9=B47=E6=9C=888=E6=97=A5 1=
7:14
> =E6=94=B6=E4=BB=B6=E4=BA=BA: Zhang Haijun-B42677
> =E6=8A=84=E9=80=81: linux-mmc@vger.kernel.org; linuxppc-dev@lists.ozlabs.=
org; =20
> cbouatmailru@gmail.com; cjb@laptop.org; Fleming Andy-AFLEMING; Wrobel =20
> Heinz-R39252; Zhang Haijun-B42677
> =E4=B8=BB=E9=A2=98: Re: [PATCH] Powerpc/t4240: change the compatible flag=
s for =20
> t4240qds board
>=20
> On 07/08/2013 02:16:03 AM, Haijun Zhang wrote:
> > In order to make a difference between different T4240 board.
> > Specify T4240QDS board the unique compatible flags for t4240qds
> > eSDHC host.
> >
> > Signed-off-by: Haijun Zhang <Haijun.Zhang@freescale.com>
> > ---
> > arch/powerpc/boot/dts/fsl/t4240si-post.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
> > b/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
> > index bd611a9..08b47d0 100644
> > --- a/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
> > +++ b/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
> > @@ -397,7 +397,7 @@
> >
> > /include/ "qoriq-esdhc-0.dtsi"
> > sdhc@114000 {
> > - compatible =3D "fsl,t4240-esdhc", "fsl,esdhc";
> > + compatible =3D "fsl,t4240qds-esdhc", "fsl,esdhc";
> > sdhci,auto-cmd12;
> > };
>=20
> NACK. This node is describing the sdhc block of the t4240 SoC. What
> board you stick it in doesn't change what it is.
>=20
> Plus, what about users with old device trees?
>=20
> Currently no users use this ip block except esdhc driver.
I'm not talking about code users. I'm talking about people users.
> How about change this in arch/powerpc/boot/dts/t4240qds.dts
>=20
> +++ b/arch/powerpc/boot/dts/t4240qds.dts
> @@ -117,6 +117,10 @@
> };
> };
>=20
> sdhc@114000 {
> compatible =3D "fsl,t4240-esdhc", "fsl,esdhc";
> };
>=20
> i2c@118000 {
>=20
>=20
> +++ b/arch/powerpc/boot/dts/t4240qds.dts
> @@ -117,6 +117,10 @@
> };
> };
>=20
> + sdhc@114000 {
> + compatible =3D "fsl,t4240qds-esdhc", =20
> "fsl,esdhc";
> + };
> +
> i2c@118000 {
No. It's still supposed to be describing the sdhc block itself, not =20
the board -- and any workarounds that key off of this will still fail =20
to work with existing device trees.
-Scott=
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: 答复: [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board
2013-07-09 20:04 ` Scott Wood
@ 2013-07-10 3:41 ` Zhang Haijun-B42677
2013-07-10 20:30 ` Scott Wood
0 siblings, 1 reply; 13+ messages in thread
From: Zhang Haijun-B42677 @ 2013-07-10 3:41 UTC (permalink / raw)
To: Wood Scott-B07421
Cc: linux-mmc, Wrobel Heinz-R39252, Fleming Andy-AFLEMING,
cbouatmailru, cjb, linuxppc-dev
DQoNClRoYW5rcy4NCg0KUmVnYXJkcw0KSGFpanVuLg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2Fn
ZS0tLS0tDQo+IEZyb206IFdvb2QgU2NvdHQtQjA3NDIxDQo+IFNlbnQ6IFdlZG5lc2RheSwgSnVs
eSAxMCwgMjAxMyA0OjA0IEFNDQo+IFRvOiBaaGFuZyBIYWlqdW4tQjQyNjc3DQo+IENjOiBXb29k
IFNjb3R0LUIwNzQyMTsgbGludXgtbW1jQHZnZXIua2VybmVsLm9yZzsgbGludXhwcGMtDQo+IGRl
dkBsaXN0cy5vemxhYnMub3JnOyBjYm91YXRtYWlscnVAZ21haWwuY29tOyBjamJAbGFwdG9wLm9y
ZzsgRmxlbWluZw0KPiBBbmR5LUFGTEVNSU5HOyBXcm9iZWwgSGVpbnotUjM5MjUyDQo+IFN1Ympl
Y3Q6IFJlOiDnrZTlpI06IFtQQVRDSF0gUG93ZXJwYy90NDI0MDogY2hhbmdlIHRoZSBjb21wYXRp
YmxlIGZsYWdzIGZvcg0KPiB0NDI0MHFkcyBib2FyZA0KPiANCj4gT24gMDcvMDkvMjAxMyAwMTow
NDowMSBBTSwgWmhhbmcgSGFpanVuLUI0MjY3NyB3cm90ZToNCj4gPg0KPiA+DQo+ID4gUmVnYXJk
cyAmIFRoYW5rcw0KPiA+DQo+ID4gSGFpanVuLg0KPiA+DQo+ID4gX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fXw0KPiA+IOWPkeS7tuS6ujogV29vZCBTY290dC1CMDc0MjEN
Cj4gPiDlj5HpgIHml7bpl7Q6IDIwMTPlubQ35pyIOOaXpSAxNzoxNA0KPiA+IOaUtuS7tuS6ujog
WmhhbmcgSGFpanVuLUI0MjY3Nw0KPiA+IOaKhOmAgTogbGludXgtbW1jQHZnZXIua2VybmVsLm9y
ZzsgbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7DQo+ID4gY2JvdWF0bWFpbHJ1QGdtYWls
LmNvbTsgY2piQGxhcHRvcC5vcmc7IEZsZW1pbmcgQW5keS1BRkxFTUlORzsgV3JvYmVsDQo+ID4g
SGVpbnotUjM5MjUyOyBaaGFuZyBIYWlqdW4tQjQyNjc3DQo+ID4g5Li76aKYOiBSZTogW1BBVENI
XSBQb3dlcnBjL3Q0MjQwOiBjaGFuZ2UgdGhlIGNvbXBhdGlibGUgZmxhZ3MgZm9yDQo+ID4gdDQy
NDBxZHMgYm9hcmQNCj4gPg0KPiA+IE9uIDA3LzA4LzIwMTMgMDI6MTY6MDMgQU0sIEhhaWp1biBa
aGFuZyB3cm90ZToNCj4gPiA+IEluIG9yZGVyIHRvIG1ha2UgYSBkaWZmZXJlbmNlIGJldHdlZW4g
ZGlmZmVyZW50IFQ0MjQwIGJvYXJkLg0KPiA+ID4gU3BlY2lmeSBUNDI0MFFEUyBib2FyZCB0aGUg
dW5pcXVlIGNvbXBhdGlibGUgZmxhZ3MgZm9yIHQ0MjQwcWRzDQo+ID4gPiBlU0RIQyBob3N0Lg0K
PiA+ID4NCj4gPiA+IFNpZ25lZC1vZmYtYnk6IEhhaWp1biBaaGFuZyA8SGFpanVuLlpoYW5nQGZy
ZWVzY2FsZS5jb20+DQo+ID4gPiAtLS0NCj4gPiA+ICBhcmNoL3Bvd2VycGMvYm9vdC9kdHMvZnNs
L3Q0MjQwc2ktcG9zdC5kdHNpIHwgMiArLQ0KPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2Vy
dGlvbigrKSwgMSBkZWxldGlvbigtKQ0KPiA+ID4NCj4gPiA+IGRpZmYgLS1naXQgYS9hcmNoL3Bv
d2VycGMvYm9vdC9kdHMvZnNsL3Q0MjQwc2ktcG9zdC5kdHNpDQo+ID4gPiBiL2FyY2gvcG93ZXJw
Yy9ib290L2R0cy9mc2wvdDQyNDBzaS1wb3N0LmR0c2kNCj4gPiA+IGluZGV4IGJkNjExYTkuLjA4
YjQ3ZDAgMTAwNjQ0DQo+ID4gPiAtLS0gYS9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvZnNsL3Q0MjQw
c2ktcG9zdC5kdHNpDQo+ID4gPiArKysgYi9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvZnNsL3Q0MjQw
c2ktcG9zdC5kdHNpDQo+ID4gPiBAQCAtMzk3LDcgKzM5Nyw3IEBADQo+ID4gPg0KPiA+ID4gIC9p
bmNsdWRlLyAicW9yaXEtZXNkaGMtMC5kdHNpIg0KPiA+ID4gICAgICAgc2RoY0AxMTQwMDAgew0K
PiA+ID4gLSAgICAgICAgICAgICBjb21wYXRpYmxlID0gImZzbCx0NDI0MC1lc2RoYyIsICJmc2ws
ZXNkaGMiOw0KPiA+ID4gKyAgICAgICAgICAgICBjb21wYXRpYmxlID0gImZzbCx0NDI0MHFkcy1l
c2RoYyIsICJmc2wsZXNkaGMiOw0KPiA+ID4gICAgICAgICAgICAgICBzZGhjaSxhdXRvLWNtZDEy
Ow0KPiA+ID4gICAgICAgfTsNCj4gPg0KPiA+IE5BQ0suICBUaGlzIG5vZGUgaXMgZGVzY3JpYmlu
ZyB0aGUgc2RoYyBibG9jayBvZiB0aGUgdDQyNDAgU29DLiAgV2hhdA0KPiA+IGJvYXJkIHlvdSBz
dGljayBpdCBpbiBkb2Vzbid0IGNoYW5nZSB3aGF0IGl0IGlzLg0KPiA+DQo+ID4gUGx1cywgd2hh
dCBhYm91dCB1c2VycyB3aXRoIG9sZCBkZXZpY2UgdHJlZXM/DQo+ID4NCj4gPiBDdXJyZW50bHkg
bm8gdXNlcnMgdXNlIHRoaXMgaXAgYmxvY2sgZXhjZXB0IGVzZGhjIGRyaXZlci4NCj4gDQo+IEkn
bSBub3QgdGFsa2luZyBhYm91dCBjb2RlIHVzZXJzLiAgSSdtIHRhbGtpbmcgYWJvdXQgcGVvcGxl
IHVzZXJzLg0KPiANCj4gPiBIb3cgYWJvdXQgY2hhbmdlIHRoaXMgaW4gYXJjaC9wb3dlcnBjL2Jv
b3QvZHRzL3Q0MjQwcWRzLmR0cw0KPiA+DQo+ID4gKysrIGIvYXJjaC9wb3dlcnBjL2Jvb3QvZHRz
L3Q0MjQwcWRzLmR0cw0KPiA+IEBAIC0xMTcsNiArMTE3LDEwIEBADQo+ID4gICAgICAgICAgICAg
ICAgICAgICAgICAgfTsNCj4gPiAgICAgICAgICAgICAgICAgfTsNCj4gPg0KPiA+ICAgICAgICAg
ICAgICAgIHNkaGNAMTE0MDAwIHsNCj4gPiAgICAgICAgICAgICAgICAgICAgICAgY29tcGF0aWJs
ZSA9ICJmc2wsdDQyNDAtZXNkaGMiLCAiZnNsLGVzZGhjIjsNCj4gPiAgICAgICAgICAgICAgICB9
Ow0KPiA+DQo+ID4gICAgICAgICAgICAgICAgaTJjQDExODAwMCB7DQo+ID4NCj4gPg0KPiA+ICsr
KyBiL2FyY2gvcG93ZXJwYy9ib290L2R0cy90NDI0MHFkcy5kdHMNCj4gPiBAQCAtMTE3LDYgKzEx
NywxMCBAQA0KPiA+ICAgICAgICAgICAgICAgICAgICAgICAgIH07DQo+ID4gICAgICAgICAgICAg
ICAgIH07DQo+ID4NCj4gPiArICAgICAgICAgICAgICAgc2RoY0AxMTQwMDAgew0KPiA+ICsgICAg
ICAgICAgICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAiZnNsLHQ0MjQwcWRzLWVzZGhjIiwNCj4g
PiAiZnNsLGVzZGhjIjsNCj4gPiArICAgICAgICAgICAgICAgfTsNCj4gPiArDQo+ID4gICAgICAg
ICAgICAgICAgIGkyY0AxMTgwMDAgew0KPiANCj4gTm8uICBJdCdzIHN0aWxsIHN1cHBvc2VkIHRv
IGJlIGRlc2NyaWJpbmcgdGhlIHNkaGMgYmxvY2sgaXRzZWxmLCBub3QgdGhlDQo+IGJvYXJkIC0t
IGFuZCBhbnkgd29ya2Fyb3VuZHMgdGhhdCBrZXkgb2ZmIG9mIHRoaXMgd2lsbCBzdGlsbCBmYWls
IHRvIHdvcmsNCj4gd2l0aCBleGlzdGluZyBkZXZpY2UgdHJlZXMuDQpbSGFpanVuIFdyb3RlOl0g
U28sIGxlYXZlIGR0cyB1bmNoYW5nZWQgYW5kIHRvIGNoZWNrIGNvbXBpdGFibGUgZm9yIGJvYXJk
IGluIHNkaGNpLXBsdGZtLmMNCmUuZy46DQoJdW5zaWduZWQgbG9uZyByb290ID0gb2ZfZ2V0X2Zs
YXRfZHRfcm9vdCgpOw0KDQoJaWYgKG9mX2ZsYXRfZHRfaXNfY29tcGF0aWJsZShyb290LCAiZnNs
LFQ0MjQwUURTIikpDQoJCWhvc3QtPnF1aXJrcyB8PSBYWFg7DQoNCklzIHRoaXMgb2s/DQoJDQo+
IA0KPiAtU2NvdHQNCg==
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: 答复: [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board
2013-07-10 3:41 ` Zhang Haijun-B42677
@ 2013-07-10 20:30 ` Scott Wood
2013-07-11 1:02 ` Zhang Haijun-B42677
0 siblings, 1 reply; 13+ messages in thread
From: Scott Wood @ 2013-07-10 20:30 UTC (permalink / raw)
To: Zhang Haijun-B42677
Cc: Wood Scott-B07421, linux-mmc, Wrobel Heinz-R39252,
Fleming Andy-AFLEMING, cbouatmailru, cjb, linuxppc-dev
On 07/09/2013 10:41:22 PM, Zhang Haijun-B42677 wrote:
> > No. It's still supposed to be describing the sdhc block itself, =20
> not the
> > board -- and any workarounds that key off of this will still fail =20
> to work
> > with existing device trees.
> [Haijun Wrote:] So, leave dts unchanged and to check compitable for =20
> board in sdhci-pltfm.c
> e.g.:
> unsigned long root =3D of_get_flat_dt_root();
>=20
> if (of_flat_dt_is_compatible(root, "fsl,T4240QDS"))
> host->quirks |=3D XXX;
Why are you looking at the flat tree at this point? Use the normal OF =20
accessors. The flat stuff is only for early boot.
Also make sure that you only do this for quirks that are actually =20
board-specific. In your last patch you had two quirks keyed off of the =20
board, one of which is keyed off of the SoC for other chips.
-SCott=
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: 答复: [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board
2013-07-10 20:30 ` Scott Wood
@ 2013-07-11 1:02 ` Zhang Haijun-B42677
2013-07-11 14:35 ` Scott Wood
0 siblings, 1 reply; 13+ messages in thread
From: Zhang Haijun-B42677 @ 2013-07-11 1:02 UTC (permalink / raw)
To: Wood Scott-B07421
Cc: Xie Xiaobo-R63061, Wrobel Heinz-R39252, Fleming Andy-AFLEMING,
cbouatmailru, cjb, linuxppc-dev
DQoNClRoYW5rcy4NCg0KUmVnYXJkcw0KSGFpanVuLg0KDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNz
YWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0MjENCj4gU2VudDogVGh1cnNkYXksIEp1
bHkgMTEsIDIwMTMgNDozMCBBTQ0KPiBUbzogWmhhbmcgSGFpanVuLUI0MjY3Nw0KPiBDYzogV29v
ZCBTY290dC1CMDc0MjE7IGxpbnV4LW1tY0B2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4cHBjLQ0KPiBk
ZXZAbGlzdHMub3psYWJzLm9yZzsgY2JvdWF0bWFpbHJ1QGdtYWlsLmNvbTsgY2piQGxhcHRvcC5v
cmc7IEZsZW1pbmcNCj4gQW5keS1BRkxFTUlORzsgV3JvYmVsIEhlaW56LVIzOTI1Mg0KPiBTdWJq
ZWN0OiBSZTogtPC4tDogW1BBVENIXSBQb3dlcnBjL3Q0MjQwOiBjaGFuZ2UgdGhlIGNvbXBhdGli
bGUgZmxhZ3MgZm9yDQo+IHQ0MjQwcWRzIGJvYXJkDQo+IA0KPiBPbiAwNy8wOS8yMDEzIDEwOjQx
OjIyIFBNLCBaaGFuZyBIYWlqdW4tQjQyNjc3IHdyb3RlOg0KPiA+ID4gTm8uICBJdCdzIHN0aWxs
IHN1cHBvc2VkIHRvIGJlIGRlc2NyaWJpbmcgdGhlIHNkaGMgYmxvY2sgaXRzZWxmLA0KPiA+IG5v
dCB0aGUNCj4gPiA+IGJvYXJkIC0tIGFuZCBhbnkgd29ya2Fyb3VuZHMgdGhhdCBrZXkgb2ZmIG9m
IHRoaXMgd2lsbCBzdGlsbCBmYWlsDQo+ID4gdG8gd29yaw0KPiA+ID4gd2l0aCBleGlzdGluZyBk
ZXZpY2UgdHJlZXMuDQo+ID4gW0hhaWp1biBXcm90ZTpdIFNvLCBsZWF2ZSBkdHMgdW5jaGFuZ2Vk
IGFuZCB0byBjaGVjayBjb21waXRhYmxlIGZvcg0KPiA+IGJvYXJkIGluIHNkaGNpLXBsdGZtLmMN
Cj4gPiBlLmcuOg0KPiA+IAl1bnNpZ25lZCBsb25nIHJvb3QgPSBvZl9nZXRfZmxhdF9kdF9yb290
KCk7DQo+ID4NCj4gPiAJaWYgKG9mX2ZsYXRfZHRfaXNfY29tcGF0aWJsZShyb290LCAiZnNsLFQ0
MjQwUURTIikpDQo+ID4gCQlob3N0LT5xdWlya3MgfD0gWFhYOw0KPiANCj4gV2h5IGFyZSB5b3Ug
bG9va2luZyBhdCB0aGUgZmxhdCB0cmVlIGF0IHRoaXMgcG9pbnQ/ICBVc2UgdGhlIG5vcm1hbCBP
Rg0KPiBhY2Nlc3NvcnMuICBUaGUgZmxhdCBzdHVmZiBpcyBvbmx5IGZvciBlYXJseSBib290Lg0K
PiANCj4gQWxzbyBtYWtlIHN1cmUgdGhhdCB5b3Ugb25seSBkbyB0aGlzIGZvciBxdWlya3MgdGhh
dCBhcmUgYWN0dWFsbHkgYm9hcmQtDQo+IHNwZWNpZmljLiAgSW4geW91ciBsYXN0IHBhdGNoIHlv
dSBoYWQgdHdvIHF1aXJrcyBrZXllZCBvZmYgb2YgdGhlIGJvYXJkLA0KPiBvbmUgb2Ygd2hpY2gg
aXMga2V5ZWQgb2ZmIG9mIHRoZSBTb0MgZm9yIG90aGVyIGNoaXBzLg0KPiANCltIYWlqdW4gV3Jv
dGU6XSBBY3R1YWxseSB0aGVyZSBhcmUgb25seSBvbmUgYm9hcmQgd2l0aCBUNDI0MCBTb2MuIEkn
bGwgdHJ5IHRvIHZlcmlmeSB0aGVzZSB0d28gZGVmZWN0IHdpdGggaGFyZHdhcmUgdGVhbS4gSG9w
ZSBjYW4gc29tZSBoZWxwLg0KT25jZSBjbGVhciBJJ2xsIHJlc2VuZCB0aGUgcGF0Y2guIFRoYW5r
cyBmb3IgeW91ciBraW5kbHkgcmV2aWV3Lg0KPiAtU0NvdHQNCg==
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: 答复: [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board
2013-07-11 1:02 ` Zhang Haijun-B42677
@ 2013-07-11 14:35 ` Scott Wood
0 siblings, 0 replies; 13+ messages in thread
From: Scott Wood @ 2013-07-11 14:35 UTC (permalink / raw)
To: Zhang Haijun-B42677
Cc: Wood Scott-B07421, Xie Xiaobo-R63061, Wrobel Heinz-R39252,
Fleming Andy-AFLEMING, cbouatmailru, cjb, linuxppc-dev
On 07/10/2013 08:02:31 PM, Zhang Haijun-B42677 wrote:
> > Also make sure that you only do this for quirks that are actually =20
> board-
> > specific. In your last patch you had two quirks keyed off of the =20
> board,
> > one of which is keyed off of the SoC for other chips.
> >
> [Haijun Wrote:] Actually there are only one board with T4240 Soc.
What about customer boards? In any case, it's not a reason to look for =20
the wrong thing.
-Scott=
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 3/4 V2] mmc: esdhc: Add quirks to support T4240QDS board
2013-07-08 17:18 ` Scott Wood
@ 2013-07-12 18:35 ` Anton Vorontsov
2013-07-16 3:11 ` Zhang Haijun-B42677
0 siblings, 1 reply; 13+ messages in thread
From: Anton Vorontsov @ 2013-07-12 18:35 UTC (permalink / raw)
To: Scott Wood; +Cc: linux-mmc, r39252, AFLEMING, cjb, linuxppc-dev, Haijun Zhang
On Mon, Jul 08, 2013 at 12:18:39PM -0500, Scott Wood wrote:
> On 07/08/2013 02:16:04 AM, Haijun Zhang wrote:
> >On T4240QDS board controllers has an unusable ADMA engine, so use
> >SDMA instead.
> >Also 3.0v is support on T4240QDS board even if the capacity
> >detailed only 1.8v
> >support. Without this quirk SD card will declare voltage not
> >support and
> >
> >Signed-off-by: Haijun Zhang <haijun.zhang@freescale.com>
>
> ...and what?
>
> Why is this board-specific? Isn't the controller part of the SoC,
> not part of the board? If it really is board-specific, could you be
> more detailed about why (ideally with an erratum number), and check
> the toplevel board compatible (or get the information from platform
> code) rather than modify the device tree?
Yup, and if anything, I would recommend to reuse voltage-ranges property,
it is already implemented for mmc spi driver,
drivers/mmc/host/of_mmc_spi.c
Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt
Thanks,
Anton
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH 3/4 V2] mmc: esdhc: Add quirks to support T4240QDS board
2013-07-12 18:35 ` Anton Vorontsov
@ 2013-07-16 3:11 ` Zhang Haijun-B42677
2013-07-16 5:04 ` Anton Vorontsov
0 siblings, 1 reply; 13+ messages in thread
From: Zhang Haijun-B42677 @ 2013-07-16 3:11 UTC (permalink / raw)
To: Anton Vorontsov, Wood Scott-B07421
Cc: Wrobel Heinz-R39252, linuxppc-dev, cjb, linux-mmc, Fleming Andy-AFLEMING
SGksIEFudG9uDQoNCllvdSBtZWFuIGdldCB2b2x0YWdlIHN1cHBvcnQgZnJvbSBEVFM/DQpPciBn
ZXQgdm9sdGFnZSBib3RoIGZyb20gRFRTIGFuZCBob3N0IGNhcGFjaXR5IHJlZ2lzdGVyPw0KDQpU
aGFua3MuDQoNClJlZ2FyZHMNCkhhaWp1bi4NCg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0t
LS0tDQo+IEZyb206IGxpbnV4LW1tYy1vd25lckB2Z2VyLmtlcm5lbC5vcmcgW21haWx0bzpsaW51
eC1tbWMtDQo+IG93bmVyQHZnZXIua2VybmVsLm9yZ10gT24gQmVoYWxmIE9mIEFudG9uIFZvcm9u
dHNvdg0KPiBTZW50OiBTYXR1cmRheSwgSnVseSAxMywgMjAxMyAyOjM1IEFNDQo+IFRvOiBXb29k
IFNjb3R0LUIwNzQyMQ0KPiBDYzogWmhhbmcgSGFpanVuLUI0MjY3NzsgbGludXgtbW1jQHZnZXIu
a2VybmVsLm9yZzsgbGludXhwcGMtDQo+IGRldkBsaXN0cy5vemxhYnMub3JnOyBjamJAbGFwdG9w
Lm9yZzsgRmxlbWluZyBBbmR5LUFGTEVNSU5HOyBXcm9iZWwNCj4gSGVpbnotUjM5MjUyDQo+IFN1
YmplY3Q6IFJlOiBbUEFUQ0ggMy80IFYyXSBtbWM6IGVzZGhjOiBBZGQgcXVpcmtzIHRvIHN1cHBv
cnQgVDQyNDBRRFMNCj4gYm9hcmQNCj4gDQo+IE9uIE1vbiwgSnVsIDA4LCAyMDEzIGF0IDEyOjE4
OjM5UE0gLTA1MDAsIFNjb3R0IFdvb2Qgd3JvdGU6DQo+ID4gT24gMDcvMDgvMjAxMyAwMjoxNjow
NCBBTSwgSGFpanVuIFpoYW5nIHdyb3RlOg0KPiA+ID5PbiBUNDI0MFFEUyBib2FyZCBjb250cm9s
bGVycyBoYXMgYW4gdW51c2FibGUgQURNQSBlbmdpbmUsIHNvIHVzZQ0KPiA+ID5TRE1BIGluc3Rl
YWQuDQo+ID4gPkFsc28gMy4wdiBpcyBzdXBwb3J0IG9uIFQ0MjQwUURTIGJvYXJkIGV2ZW4gaWYg
dGhlIGNhcGFjaXR5IGRldGFpbGVkDQo+ID4gPm9ubHkgMS44diBzdXBwb3J0LiBXaXRob3V0IHRo
aXMgcXVpcmsgU0QgY2FyZCB3aWxsIGRlY2xhcmUgdm9sdGFnZQ0KPiA+ID5ub3Qgc3VwcG9ydCBh
bmQNCj4gPiA+DQo+ID4gPlNpZ25lZC1vZmYtYnk6IEhhaWp1biBaaGFuZyA8aGFpanVuLnpoYW5n
QGZyZWVzY2FsZS5jb20+DQo+ID4NCj4gPiAuLi5hbmQgd2hhdD8NCj4gPg0KPiA+IFdoeSBpcyB0
aGlzIGJvYXJkLXNwZWNpZmljPyAgSXNuJ3QgdGhlIGNvbnRyb2xsZXIgcGFydCBvZiB0aGUgU29D
LCBub3QNCj4gPiBwYXJ0IG9mIHRoZSBib2FyZD8gIElmIGl0IHJlYWxseSBpcyBib2FyZC1zcGVj
aWZpYywgY291bGQgeW91IGJlIG1vcmUNCj4gPiBkZXRhaWxlZCBhYm91dCB3aHkgKGlkZWFsbHkg
d2l0aCBhbiBlcnJhdHVtIG51bWJlciksIGFuZCBjaGVjayB0aGUNCj4gPiB0b3BsZXZlbCBib2Fy
ZCBjb21wYXRpYmxlIChvciBnZXQgdGhlIGluZm9ybWF0aW9uIGZyb20gcGxhdGZvcm0NCj4gPiBj
b2RlKSByYXRoZXIgdGhhbiBtb2RpZnkgdGhlIGRldmljZSB0cmVlPw0KPiANCj4gWXVwLCBhbmQg
aWYgYW55dGhpbmcsIEkgd291bGQgcmVjb21tZW5kIHRvIHJldXNlIHZvbHRhZ2UtcmFuZ2VzIHBy
b3BlcnR5LA0KPiBpdCBpcyBhbHJlYWR5IGltcGxlbWVudGVkIGZvciBtbWMgc3BpIGRyaXZlciwN
Cj4gDQo+IGRyaXZlcnMvbW1jL2hvc3Qvb2ZfbW1jX3NwaS5jDQo+IERvY3VtZW50YXRpb24vZGV2
aWNldHJlZS9iaW5kaW5ncy9tbWMvbW1jLXNwaS1zbG90LnR4dA0KPiANCj4gVGhhbmtzLA0KPiAN
Cj4gQW50b24NCj4gLS0NCj4gVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhl
IGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LW1tYyIgaW4NCj4gdGhlIGJvZHkgb2YgYSBtZXNzYWdl
IHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcgTW9yZSBtYWpvcmRvbW8gaW5mbyBhdA0KPiBo
dHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwNCg0K
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 3/4 V2] mmc: esdhc: Add quirks to support T4240QDS board
2013-07-16 3:11 ` Zhang Haijun-B42677
@ 2013-07-16 5:04 ` Anton Vorontsov
0 siblings, 0 replies; 13+ messages in thread
From: Anton Vorontsov @ 2013-07-16 5:04 UTC (permalink / raw)
To: Zhang Haijun-B42677
Cc: Wood Scott-B07421, linux-mmc, Wrobel Heinz-R39252,
Fleming Andy-AFLEMING, cjb, linuxppc-dev
On Tue, Jul 16, 2013 at 03:11:47AM +0000, Zhang Haijun-B42677 wrote:
> Hi, Anton
>
> You mean get voltage support from DTS?
> Or get voltage both from DTS and host capacity register?
The logic might be that you first check device-tree, if it specifies
voltage ranges, assume that DTS knows better, otherwise read capabilities
from the register.
Anton
> Thanks.
>
> Regards
> Haijun.
>
>
> > -----Original Message-----
> > From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc-
> > owner@vger.kernel.org] On Behalf Of Anton Vorontsov
> > Sent: Saturday, July 13, 2013 2:35 AM
> > To: Wood Scott-B07421
> > Cc: Zhang Haijun-B42677; linux-mmc@vger.kernel.org; linuxppc-
> > dev@lists.ozlabs.org; cjb@laptop.org; Fleming Andy-AFLEMING; Wrobel
> > Heinz-R39252
> > Subject: Re: [PATCH 3/4 V2] mmc: esdhc: Add quirks to support T4240QDS
> > board
> >
> > On Mon, Jul 08, 2013 at 12:18:39PM -0500, Scott Wood wrote:
> > > On 07/08/2013 02:16:04 AM, Haijun Zhang wrote:
> > > >On T4240QDS board controllers has an unusable ADMA engine, so use
> > > >SDMA instead.
> > > >Also 3.0v is support on T4240QDS board even if the capacity detailed
> > > >only 1.8v support. Without this quirk SD card will declare voltage
> > > >not support and
> > > >
> > > >Signed-off-by: Haijun Zhang <haijun.zhang@freescale.com>
> > >
> > > ...and what?
> > >
> > > Why is this board-specific? Isn't the controller part of the SoC, not
> > > part of the board? If it really is board-specific, could you be more
> > > detailed about why (ideally with an erratum number), and check the
> > > toplevel board compatible (or get the information from platform
> > > code) rather than modify the device tree?
> >
> > Yup, and if anything, I would recommend to reuse voltage-ranges property,
> > it is already implemented for mmc spi driver,
> >
> > drivers/mmc/host/of_mmc_spi.c
> > Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt
> >
> > Thanks,
> >
> > Anton
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> > the body of a message to majordomo@vger.kernel.org More majordomo info at
> > http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2013-07-16 5:04 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-08 7:16 [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board Haijun Zhang
2013-07-08 7:16 ` [PATCH 3/4 V2] mmc: esdhc: Add quirks to support T4240QDS board Haijun Zhang
2013-07-08 17:18 ` Scott Wood
2013-07-12 18:35 ` Anton Vorontsov
2013-07-16 3:11 ` Zhang Haijun-B42677
2013-07-16 5:04 ` Anton Vorontsov
2013-07-08 17:14 ` [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board Scott Wood
2013-07-09 6:04 ` 答复: " Zhang Haijun-B42677
2013-07-09 20:04 ` Scott Wood
2013-07-10 3:41 ` Zhang Haijun-B42677
2013-07-10 20:30 ` Scott Wood
2013-07-11 1:02 ` Zhang Haijun-B42677
2013-07-11 14:35 ` Scott Wood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).