From: Milosz Tanski <milosz@adfin.com>
To: linux-kernel@vger.kernel.org
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-aio@kvack.org,
Mel Gorman <mgorman@suse.de>,
Volker Lendecke <Volker.Lendecke@sernet.de>,
Tejun Heo <tj@kernel.org>, Jeff Moyer <jmoyer@redhat.com>
Subject: [PATCH 2/7] Define new syscalls readv2,preadv2,writev2,pwritev2
Date: Mon, 15 Sep 2014 16:20:37 -0400 [thread overview]
Message-ID: <057d758976db2fcce58e394abaa0d55e48cdeec1.1410810247.git.milosz@adfin.com> (raw)
In-Reply-To: <cover.1410810247.git.milosz@adfin.com>
New syscalls with an extra flag argument. For now all flags except for 0 are
not supported.
Signed-off-by: Milosz Tanski <milosz@adfin.com>
---
fs/read_write.c | 100 +++++++++++++++++++++++++++++++++++++
include/linux/syscalls.h | 12 +++++
include/uapi/asm-generic/unistd.h | 10 +++-
3 files changed, 121 insertions(+), 1 deletion(-)
diff --git a/fs/read_write.c b/fs/read_write.c
index 4747247..6c5030a 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -902,6 +902,29 @@ SYSCALL_DEFINE3(readv, unsigned long, fd, const struct iovec __user *, vec,
return ret;
}
+SYSCALL_DEFINE4(readv2, unsigned long, fd, const struct iovec __user *, vec,
+ unsigned long, vlen, int, flags)
+{
+ struct fd f = fdget_pos(fd);
+ ssize_t ret = -EBADF;
+
+ if (flags & ~0)
+ return -EINVAL;
+
+ if (f.file) {
+ loff_t pos = file_pos_read(f.file);
+ ret = vfs_readv(f.file, vec, vlen, &pos, flags);
+ if (ret >= 0)
+ file_pos_write(f.file, pos);
+ fdput_pos(f);
+ }
+
+ if (ret > 0)
+ add_rchar(current, ret);
+ inc_syscr(current);
+ return ret;
+}
+
SYSCALL_DEFINE3(writev, unsigned long, fd, const struct iovec __user *, vec,
unsigned long, vlen)
{
@@ -922,6 +945,29 @@ SYSCALL_DEFINE3(writev, unsigned long, fd, const struct iovec __user *, vec,
return ret;
}
+SYSCALL_DEFINE4(writev2, unsigned long, fd, const struct iovec __user *, vec,
+ unsigned long, vlen, int, flags)
+{
+ struct fd f = fdget_pos(fd);
+ ssize_t ret = -EBADF;
+
+ if (flags & ~0)
+ return -EINVAL;
+
+ if (f.file) {
+ loff_t pos = file_pos_read(f.file);
+ ret = vfs_writev(f.file, vec, vlen, &pos, flags);
+ if (ret >= 0)
+ file_pos_write(f.file, pos);
+ fdput_pos(f);
+ }
+
+ if (ret > 0)
+ add_wchar(current, ret);
+ inc_syscw(current);
+ return ret;
+}
+
static inline loff_t pos_from_hilo(unsigned long high, unsigned long low)
{
#define HALF_LONG_BITS (BITS_PER_LONG / 2)
@@ -952,6 +998,33 @@ SYSCALL_DEFINE5(preadv, unsigned long, fd, const struct iovec __user *, vec,
return ret;
}
+SYSCALL_DEFINE6(preadv2, unsigned long, fd, const struct iovec __user *, vec,
+ unsigned long, vlen, unsigned long, pos_l, unsigned long, pos_h,
+ int, flags)
+{
+ loff_t pos = pos_from_hilo(pos_h, pos_l);
+ struct fd f;
+ ssize_t ret = -EBADF;
+
+ if (flags & ~0)
+ return -EINVAL;
+ if (pos < 0)
+ return -EINVAL;
+
+ f = fdget(fd);
+ if (f.file) {
+ ret = -ESPIPE;
+ if (f.file->f_mode & FMODE_PREAD)
+ ret = vfs_readv(f.file, vec, vlen, &pos, flags);
+ fdput(f);
+ }
+
+ if (ret > 0)
+ add_rchar(current, ret);
+ inc_syscr(current);
+ return ret;
+}
+
SYSCALL_DEFINE5(pwritev, unsigned long, fd, const struct iovec __user *, vec,
unsigned long, vlen, unsigned long, pos_l, unsigned long, pos_h)
{
@@ -976,6 +1049,33 @@ SYSCALL_DEFINE5(pwritev, unsigned long, fd, const struct iovec __user *, vec,
return ret;
}
+SYSCALL_DEFINE6(pwritev2, unsigned long, fd, const struct iovec __user *, vec,
+ unsigned long, vlen, unsigned long, pos_l, unsigned long, pos_h,
+ int, flags)
+{
+ loff_t pos = pos_from_hilo(pos_h, pos_l);
+ struct fd f;
+ ssize_t ret = -EBADF;
+
+ if (flags & ~0)
+ return -EINVAL;
+ if (pos < 0)
+ return -EINVAL;
+
+ f = fdget(fd);
+ if (f.file) {
+ ret = -ESPIPE;
+ if (f.file->f_mode & FMODE_PWRITE)
+ ret = vfs_writev(f.file, vec, vlen, &pos, flags);
+ fdput(f);
+ }
+
+ if (ret > 0)
+ add_wchar(current, ret);
+ inc_syscw(current);
+ return ret;
+}
+
#ifdef CONFIG_COMPAT
static ssize_t compat_do_readv_writev(int type, struct file *file,
diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
index 0f86d85..0c49ae4 100644
--- a/include/linux/syscalls.h
+++ b/include/linux/syscalls.h
@@ -559,19 +559,31 @@ asmlinkage long sys_readahead(int fd, loff_t offset, size_t count);
asmlinkage long sys_readv(unsigned long fd,
const struct iovec __user *vec,
unsigned long vlen);
+asmlinkage long sys_readv2(unsigned long fd,
+ const struct iovec __user *vec,
+ unsigned long vlen, int flags);
asmlinkage long sys_write(unsigned int fd, const char __user *buf,
size_t count);
asmlinkage long sys_writev(unsigned long fd,
const struct iovec __user *vec,
unsigned long vlen);
+asmlinkage long sys_writev2(unsigned long fd,
+ const struct iovec __user *vec,
+ unsigned long vlen, int flags);
asmlinkage long sys_pread64(unsigned int fd, char __user *buf,
size_t count, loff_t pos);
asmlinkage long sys_pwrite64(unsigned int fd, const char __user *buf,
size_t count, loff_t pos);
asmlinkage long sys_preadv(unsigned long fd, const struct iovec __user *vec,
unsigned long vlen, unsigned long pos_l, unsigned long pos_h);
+asmlinkage long sys_preadv2(unsigned long fd, const struct iovec __user *vec,
+ unsigned long vlen, unsigned long pos_l, unsigned long pos_h,
+ int flags);
asmlinkage long sys_pwritev(unsigned long fd, const struct iovec __user *vec,
unsigned long vlen, unsigned long pos_l, unsigned long pos_h);
+asmlinkage long sys_pwritev2(unsigned long fd, const struct iovec __user *vec,
+ unsigned long vlen, unsigned long pos_l, unsigned long pos_h,
+ int flags);
asmlinkage long sys_getcwd(char __user *buf, unsigned long size);
asmlinkage long sys_mkdir(const char __user *pathname, umode_t mode);
asmlinkage long sys_chdir(const char __user *filename);
diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h
index 11d11bc..75ad687 100644
--- a/include/uapi/asm-generic/unistd.h
+++ b/include/uapi/asm-generic/unistd.h
@@ -213,6 +213,14 @@ __SC_COMP(__NR_pwrite64, sys_pwrite64, compat_sys_pwrite64)
__SC_COMP(__NR_preadv, sys_preadv, compat_sys_preadv)
#define __NR_pwritev 70
__SC_COMP(__NR_pwritev, sys_pwritev, compat_sys_pwritev)
+#define __NR_readv2 280
+__SC_COMP(__NR_readv2, sys_readv2)
+#define __NR_writev2 281
+__SC_COMP(__NR_writev2, sys_writev2)
+#define __NR_preadv2 282
+__SC_COMP(__NR_preadv2, sys_preadv2)
+#define __NR_pwritev2 283
+__SC_COMP(__NR_pwritev2, sys_pwritev2)
/* fs/sendfile.c */
#define __NR3264_sendfile 71
@@ -707,7 +715,7 @@ __SYSCALL(__NR_getrandom, sys_getrandom)
__SYSCALL(__NR_memfd_create, sys_memfd_create)
#undef __NR_syscalls
-#define __NR_syscalls 280
+#define __NR_syscalls 284
/*
* All syscalls below here should go away really,
--
1.7.9.5
next prev parent reply other threads:[~2014-09-15 20:20 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 20:20 [RFC PATCH 0/7] Non-blockling buffered fs read (page cache only) Milosz Tanski
2014-09-15 20:20 ` [PATCH 1/7] Prepare for adding a new readv/writev with user flags Milosz Tanski
2014-09-15 20:28 ` Al Viro
2014-09-15 21:15 ` Christoph Hellwig
2014-09-15 21:44 ` Milosz Tanski
2014-09-15 20:20 ` Milosz Tanski [this message]
2014-09-16 19:20 ` [PATCH 2/7] Define new syscalls readv2,preadv2,writev2,pwritev2 Jeff Moyer
2014-09-16 19:54 ` Milosz Tanski
2014-09-16 21:03 ` Christoph Hellwig
2014-09-17 15:43 ` Theodore Ts'o
2014-09-17 16:05 ` Milosz Tanski
2014-09-17 16:59 ` Theodore Ts'o
2014-09-17 17:24 ` Zach Brown
2014-09-15 20:20 ` [PATCH 3/7] Export new vector IO (with flags) to userland Milosz Tanski
2014-09-15 20:21 ` [PATCH 4/7] O_NONBLOCK flag for readv2/preadv2 Milosz Tanski
2014-09-16 19:19 ` Jeff Moyer
2014-09-16 19:44 ` Milosz Tanski
2014-09-16 19:53 ` Jeff Moyer
2014-09-15 20:21 ` [PATCH 5/7] documentation updates Christoph Hellwig
2014-09-15 20:21 ` [PATCH 6/7] move flags enforcement to vfs_preadv/vfs_pwritev Christoph Hellwig
2014-09-15 21:15 ` Christoph Hellwig
2014-09-15 21:45 ` Milosz Tanski
2014-09-15 20:22 ` [PATCH 7/7] check for O_NONBLOCK in all read_iter instances Christoph Hellwig
2014-09-16 19:27 ` Jeff Moyer
2014-09-16 19:45 ` Milosz Tanski
2014-09-16 21:42 ` Dave Chinner
2014-09-17 12:24 ` Benjamin LaHaise
2014-09-17 13:47 ` Theodore Ts'o
2014-09-17 13:56 ` Benjamin LaHaise
2014-09-17 15:33 ` Milosz Tanski
2014-09-17 15:49 ` Theodore Ts'o
2014-09-17 15:52 ` Zach Brown
2014-09-16 21:04 ` Christoph Hellwig
2014-09-16 21:24 ` Jeff Moyer
2014-09-15 20:27 ` [RFC PATCH 0/7] Non-blockling buffered fs read (page cache only) Milosz Tanski
2014-09-15 21:33 ` Andreas Dilger
2014-09-15 22:13 ` Milosz Tanski
2014-09-15 22:36 ` Elliott, Robert (Server Storage)
2014-09-16 18:24 ` Zach Brown
2014-09-19 11:21 ` Christoph Hellwig
2014-09-22 15:48 ` Jeff Moyer
2014-09-22 16:32 ` Milosz Tanski
2014-09-22 16:42 ` Christoph Hellwig
2014-09-22 17:02 ` Milosz Tanski
2014-09-22 16:25 ` Elliott, Robert (Server Storage)
2014-09-15 21:58 ` Jeff Moyer
2014-09-15 22:27 ` Milosz Tanski
2014-09-16 13:44 ` Jeff Moyer
2014-09-19 11:23 ` Christoph Hellwig
2014-09-16 19:30 ` Jeff Moyer
2014-09-16 20:34 ` Milosz Tanski
2014-09-16 20:49 ` Jeff Moyer
2014-09-17 14:49 ` [RFC 1/2] aio: async readahead Benjamin LaHaise
2014-09-17 15:26 ` [RFC 2/2] ext4: async readpage for indirect style inodes Benjamin LaHaise
2014-09-19 11:26 ` [RFC 1/2] aio: async readahead Christoph Hellwig
2014-09-19 16:01 ` Benjamin LaHaise
2014-09-17 22:20 ` [RFC v2 0/5] Non-blockling buffered fs read (page cache only) Milosz Tanski
2014-09-17 22:20 ` [RFC v2 1/5] Prepare for adding a new readv/writev with user flags Milosz Tanski
2014-09-17 22:20 ` [RFC v2 2/5] Define new syscalls readv2,preadv2,writev2,pwritev2 Milosz Tanski
2014-09-18 18:48 ` Darrick J. Wong
2014-09-19 10:52 ` Christoph Hellwig
2014-09-20 0:19 ` Darrick J. Wong
2014-09-17 22:20 ` [RFC v2 3/5] Export new vector IO (with flags) to userland Milosz Tanski
2014-09-17 22:20 ` [RFC v2 4/5] O_NONBLOCK flag for readv2/preadv2 Milosz Tanski
2014-09-19 11:27 ` Christoph Hellwig
2014-09-19 11:59 ` Milosz Tanski
2014-09-22 17:12 ` Jeff Moyer
2014-09-17 22:20 ` [RFC v2 5/5] Check for O_NONBLOCK in all read_iter instances Milosz Tanski
2014-09-19 11:26 ` Christoph Hellwig
2014-09-19 14:42 ` [RFC v2 0/5] Non-blockling buffered fs read (page cache only) Jonathan Corbet
2014-09-19 16:13 ` Volker Lendecke
2014-09-19 17:19 ` Milosz Tanski
2014-09-19 17:33 ` Milosz Tanski
2014-09-22 14:12 ` Jonathan Corbet
2014-09-22 14:24 ` Jeff Moyer
2014-09-22 14:25 ` Christoph Hellwig
2014-09-22 14:30 ` Milosz Tanski
2014-09-24 21:46 ` [RFC v3 0/4] vfs: " Milosz Tanski
2014-09-24 21:46 ` [RFC v3 1/4] vfs: Prepare for adding a new preadv/pwritev with user flags Milosz Tanski
2014-09-24 21:46 ` [RFC v3 2/4] vfs: Define new syscalls preadv2,pwritev2 Milosz Tanski
2014-09-24 21:46 ` [RFC v3 3/4] vfs: Export new vector IO syscalls (with flags) to userland Milosz Tanski
2014-09-24 21:46 ` [RFC v3 4/4] vfs: RWF_NONBLOCK flag for preadv2 Milosz Tanski
2014-09-25 4:06 ` [RFC v3 0/4] vfs: Non-blockling buffered fs read (page cache only) Michael Kerrisk
2014-09-25 11:16 ` Jan Kara
2014-09-25 15:48 ` Milosz Tanski
2014-10-08 2:53 ` Milosz Tanski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=057d758976db2fcce58e394abaa0d55e48cdeec1.1410810247.git.milosz@adfin.com \
--to=milosz@adfin.com \
--cc=Volker.Lendecke@sernet.de \
--cc=hch@infradead.org \
--cc=jmoyer@redhat.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).