Re: [PATCH 7/7] check for O_NONBLOCK in all read_iter instances

From: "Theodore Ts'o" <tytso@mit.edu>
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: Dave Chinner <david@fromorbit.com>,
	Milosz Tanski <milosz@adfin.com>, Jeff Moyer <jmoyer@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@infradead.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	linux-aio@kvack.org, Mel Gorman <mgorman@suse.de>,
	Volker Lendecke <Volker.Lendecke@sernet.de>,
	Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH 7/7] check for O_NONBLOCK in all read_iter instances
Date: Wed, 17 Sep 2014 09:47:02 -0400	[thread overview]
Message-ID: <20140917134702.GB10720@thunk.org> (raw)
In-Reply-To: <20140917122448.GR24821@kvack.org>

On Wed, Sep 17, 2014 at 08:24:48AM -0400, Benjamin LaHaise wrote:
> 
> Linus flamed me for that a few weeks ago.  The problem is that if one 
> uses "git format-patch" to prepare a series of emails to post, that it 
> users the patch's author for the From: entry.  I think that is a bug 
> in git since multiple people have encountered this issue.  It's not 
> like git doesn't know what one's email address is....

That's true, but "git send-email" takes care of doing the rewrite so
that your e-mail address is on the from line and the original author's
from: line is moved into the body of the e-mail:

% git log -1
commit 1419b5ae0b3bf093bd694dd592ebfdb58ac92d10
Author: Michael Forney <forney@google.com>
Date:   Mon Sep 15 14:30:00 2014 -0400

    Don't clear BUILD_CFLAGS and BUILD_LDFLAGS when cross-compiling

    Signed-off-by: Michael Forney <forney@google.com>
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
% git format-patch -o /tmp/p -1
/tmp/p/0001-Don-t-clear-BUILD_CFLAGS-and-BUILD_LDFLAGS-when-cros.patch
% head -5 /tmp/p/0001-Don-t-clear-BUILD_CFLAGS-and-BUILD_LDFLAGS-when-cros.patch 
>From 1419b5ae0b3bf093bd694dd592ebfdb58ac92d10 Mon Sep 17 00:00:00 2001
From: Michael Forney <forney@google.com>
Date: Mon, 15 Sep 2014 14:30:00 -0400
Subject: [PATCH] Don't clear BUILD_CFLAGS and BUILD_LDFLAGS when
 cross-compiling
% git send-email /tmp/p --to tytso@mit.edu
/tmp/p/0001-Don-t-clear-BUILD_CFLAGS-and-BUILD_LDFLAGS-when-cros.patch
(mbox) Adding cc: Michael Forney <forney@google.com> from line 'From: Michael Forney <forney@google.com>'
(body) Adding cc: Michael Forney <forney@google.com> from line 'Signed-off-by: Michael Forney <forney@google.com>'
(body) Adding cc: Theodore Ts'o <tytso@mit.edu> from line 'Signed-off-by: Theodore Ts'o <tytso@mit.edu>'

From: Theodore Ts'o <tytso@mit.edu>
To: tytso@mit.edu
Cc: Michael Forney <forney@google.com>
Subject: [PATCH] Don't clear BUILD_CFLAGS and BUILD_LDFLAGS when cross-compiling
Date: Wed, 17 Sep 2014 09:45:09 -0400
Message-Id: <1410961509-10620-1-git-send-email-tytso@mit.edu>
X-Mailer: git-send-email 2.1.0

Send this email? ([y]es|[n]o|[q]uit|[a]ll): ^C

% git version
git version 2.1.0

Perhaps you and other people are using your own scripts, and not using
git send-email?

							- Ted