Re: [PATCH 7/7] check for O_NONBLOCK in all read_iter instances

From: Milosz Tanski <milosz@adfin.com>
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
	Dave Chinner <david@fromorbit.com>,
	Jeff Moyer <jmoyer@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@infradead.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	linux-aio@kvack.org, Mel Gorman <mgorman@suse.de>,
	Volker Lendecke <Volker.Lendecke@sernet.de>,
	Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH 7/7] check for O_NONBLOCK in all read_iter instances
Date: Wed, 17 Sep 2014 11:33:35 -0400	[thread overview]
Message-ID: <CANP1eJHS_AeZutYbt3+qOeg3a0a7hdiqoyJEEYBssMTb+M=OtQ@mail.gmail.com> (raw)
In-Reply-To: <20140917135611.GT24821@kvack.org>

On Wed, Sep 17, 2014 at 9:56 AM, Benjamin LaHaise <bcrl@kvack.org> wrote:
> On Wed, Sep 17, 2014 at 09:47:02AM -0400, Theodore Ts'o wrote:
> ...
>> % git version
>> git version 2.1.0
>>
>> Perhaps you and other people are using your own scripts, and not using
>> git send-email?
>
> That would be because none of my systems have git 2.1.0 on them.  Fedora
> (and EPEL) appear to still be back on git 1.9.3 which does not have git
> send-email.  Until that command is more widely propagated, I expect we'll
> see people making this mistake every once in a while.
>
>                 -ben
> --
> "Thought is the essence of where you are now."

My workflow has been to use git format-patch (1.7.9.5 was shipped with
my distro), edit the cover letter then use and mutt to send the
generated emails. Before that I used git apply to import the patches
that Christoph sent me. I thought about it too, but hand editing the
email generated by format-patch to essentially having me take credit
for this sounded like a shady thing to do. The updated version of
git's (2.1.0) format-patch doesn't change the from email address field
either.

The submitting patches document doesn't really describe what to do if
you take patches / collaborate with somebody else or how to credit the
original author. It only deals with the case of a subsystem
maintainers editing the submitters code to fix it up.

All that aside, if somebody has a clear workflow that ensures this
doesn't happen I'm more then willing to follow it.

-- 
Milosz Tanski
CTO
16 East 34th Street, 15th floor
New York, NY 10016

p: 646-253-9055
e: milosz@adfin.com