From: Zach Brown <zab@zabbo.net>
To: "Theodore Ts'o" <tytso@mit.edu>, Milosz Tanski <milosz@adfin.com>,
LKML <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
linux-aio@kvack.org, Mel Gorman <mgorman@suse.de>,
Volker Lendecke <Volker.Lendecke@sernet.de>,
Tejun Heo <tj@kernel.org>, Jeff Moyer <jmoyer@redhat.com>
Subject: Re: [PATCH 2/7] Define new syscalls readv2,preadv2,writev2,pwritev2
Date: Wed, 17 Sep 2014 10:24:17 -0700 [thread overview]
Message-ID: <20140917172417.GD20887@lenny.home.zabbo.net> (raw)
In-Reply-To: <20140917165930.GA24887@thunk.org>
On Wed, Sep 17, 2014 at 12:59:30PM -0400, Theodore Ts'o wrote:
> On Wed, Sep 17, 2014 at 12:05:23PM -0400, Milosz Tanski wrote:
> > Theodore,
> >
> > I might be missing understanding something, but... I already omitted
> > read2 and write2 which can be implemented in userspace by libc (as you
> > pointed out). In the case of readv vs. preadv there's an extra
> > positional argument (file offset) and preadv version doesn't change
> > the file location. I didn't want to overload the meaning of preadv2 to
> > take a special negative offset value that uses the current file
> > position but also changes the file position.
>
> off_t has to be signed, so having a magic negative value doesn't
> bother me that much. Or you could use a flag bitvalue which means to
> use the fd's offset and to ignore the positional value. (More
> bike-shedding :-)
splice has already set the precedent for an optionally specified offset
that falls back to the files's position.
static long do_splice(struct file *in, loff_t __user *off_in,
struct file *out, loff_t __user *off_out,
size_t len, unsigned int flags)
{
...
if (off_out) {
if (copy_from_user(&offset, off_out, sizeof(loff_t)))
return -EFAULT;
} else {
offset = out->f_pos;
}
...
if (!off_out)
out->f_pos = offset;
else if (copy_to_user(off_out, &offset, sizeof(loff_t)))
ret = -EFAULT;
It's nice and simple and lets you update the user's offset.
> So the suggestion was one of trying to (probably fruitlessly) trying
> to stem the expnoential increase in read/write system calls. :-)
I support this windmill tilting :).
- z
next prev parent reply other threads:[~2014-09-17 17:24 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 20:20 [RFC PATCH 0/7] Non-blockling buffered fs read (page cache only) Milosz Tanski
2014-09-15 20:20 ` [PATCH 1/7] Prepare for adding a new readv/writev with user flags Milosz Tanski
2014-09-15 20:28 ` Al Viro
2014-09-15 21:15 ` Christoph Hellwig
2014-09-15 21:44 ` Milosz Tanski
2014-09-15 20:20 ` [PATCH 2/7] Define new syscalls readv2,preadv2,writev2,pwritev2 Milosz Tanski
2014-09-16 19:20 ` Jeff Moyer
2014-09-16 19:54 ` Milosz Tanski
2014-09-16 21:03 ` Christoph Hellwig
2014-09-17 15:43 ` Theodore Ts'o
2014-09-17 16:05 ` Milosz Tanski
2014-09-17 16:59 ` Theodore Ts'o
2014-09-17 17:24 ` Zach Brown [this message]
2014-09-15 20:20 ` [PATCH 3/7] Export new vector IO (with flags) to userland Milosz Tanski
2014-09-15 20:21 ` [PATCH 4/7] O_NONBLOCK flag for readv2/preadv2 Milosz Tanski
2014-09-16 19:19 ` Jeff Moyer
2014-09-16 19:44 ` Milosz Tanski
2014-09-16 19:53 ` Jeff Moyer
2014-09-15 20:21 ` [PATCH 5/7] documentation updates Christoph Hellwig
2014-09-15 20:21 ` [PATCH 6/7] move flags enforcement to vfs_preadv/vfs_pwritev Christoph Hellwig
2014-09-15 21:15 ` Christoph Hellwig
2014-09-15 21:45 ` Milosz Tanski
2014-09-15 20:22 ` [PATCH 7/7] check for O_NONBLOCK in all read_iter instances Christoph Hellwig
2014-09-16 19:27 ` Jeff Moyer
2014-09-16 19:45 ` Milosz Tanski
2014-09-16 21:42 ` Dave Chinner
2014-09-17 12:24 ` Benjamin LaHaise
2014-09-17 13:47 ` Theodore Ts'o
2014-09-17 13:56 ` Benjamin LaHaise
2014-09-17 15:33 ` Milosz Tanski
2014-09-17 15:49 ` Theodore Ts'o
2014-09-17 15:52 ` Zach Brown
2014-09-16 21:04 ` Christoph Hellwig
2014-09-16 21:24 ` Jeff Moyer
2014-09-15 20:27 ` [RFC PATCH 0/7] Non-blockling buffered fs read (page cache only) Milosz Tanski
2014-09-15 21:33 ` Andreas Dilger
2014-09-15 22:13 ` Milosz Tanski
2014-09-15 22:36 ` Elliott, Robert (Server Storage)
2014-09-16 18:24 ` Zach Brown
2014-09-19 11:21 ` Christoph Hellwig
2014-09-22 15:48 ` Jeff Moyer
2014-09-22 16:32 ` Milosz Tanski
2014-09-22 16:42 ` Christoph Hellwig
2014-09-22 17:02 ` Milosz Tanski
2014-09-22 16:25 ` Elliott, Robert (Server Storage)
2014-09-15 21:58 ` Jeff Moyer
2014-09-15 22:27 ` Milosz Tanski
2014-09-16 13:44 ` Jeff Moyer
2014-09-19 11:23 ` Christoph Hellwig
2014-09-16 19:30 ` Jeff Moyer
2014-09-16 20:34 ` Milosz Tanski
2014-09-16 20:49 ` Jeff Moyer
2014-09-17 14:49 ` [RFC 1/2] aio: async readahead Benjamin LaHaise
2014-09-17 15:26 ` [RFC 2/2] ext4: async readpage for indirect style inodes Benjamin LaHaise
2014-09-19 11:26 ` [RFC 1/2] aio: async readahead Christoph Hellwig
2014-09-19 16:01 ` Benjamin LaHaise
2014-09-17 22:20 ` [RFC v2 0/5] Non-blockling buffered fs read (page cache only) Milosz Tanski
2014-09-17 22:20 ` [RFC v2 1/5] Prepare for adding a new readv/writev with user flags Milosz Tanski
2014-09-17 22:20 ` [RFC v2 2/5] Define new syscalls readv2,preadv2,writev2,pwritev2 Milosz Tanski
2014-09-18 18:48 ` Darrick J. Wong
2014-09-19 10:52 ` Christoph Hellwig
2014-09-20 0:19 ` Darrick J. Wong
2014-09-17 22:20 ` [RFC v2 3/5] Export new vector IO (with flags) to userland Milosz Tanski
2014-09-17 22:20 ` [RFC v2 4/5] O_NONBLOCK flag for readv2/preadv2 Milosz Tanski
2014-09-19 11:27 ` Christoph Hellwig
2014-09-19 11:59 ` Milosz Tanski
2014-09-22 17:12 ` Jeff Moyer
2014-09-17 22:20 ` [RFC v2 5/5] Check for O_NONBLOCK in all read_iter instances Milosz Tanski
2014-09-19 11:26 ` Christoph Hellwig
2014-09-19 14:42 ` [RFC v2 0/5] Non-blockling buffered fs read (page cache only) Jonathan Corbet
2014-09-19 16:13 ` Volker Lendecke
2014-09-19 17:19 ` Milosz Tanski
2014-09-19 17:33 ` Milosz Tanski
2014-09-22 14:12 ` Jonathan Corbet
2014-09-22 14:24 ` Jeff Moyer
2014-09-22 14:25 ` Christoph Hellwig
2014-09-22 14:30 ` Milosz Tanski
2014-09-24 21:46 ` [RFC v3 0/4] vfs: " Milosz Tanski
2014-09-24 21:46 ` [RFC v3 1/4] vfs: Prepare for adding a new preadv/pwritev with user flags Milosz Tanski
2014-09-24 21:46 ` [RFC v3 2/4] vfs: Define new syscalls preadv2,pwritev2 Milosz Tanski
2014-09-24 21:46 ` [RFC v3 3/4] vfs: Export new vector IO syscalls (with flags) to userland Milosz Tanski
2014-09-24 21:46 ` [RFC v3 4/4] vfs: RWF_NONBLOCK flag for preadv2 Milosz Tanski
2014-09-25 4:06 ` [RFC v3 0/4] vfs: Non-blockling buffered fs read (page cache only) Michael Kerrisk
2014-09-25 11:16 ` Jan Kara
2014-09-25 15:48 ` Milosz Tanski
2014-10-08 2:53 ` Milosz Tanski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917172417.GD20887@lenny.home.zabbo.net \
--to=zab@zabbo.net \
--cc=Volker.Lendecke@sernet.de \
--cc=hch@infradead.org \
--cc=jmoyer@redhat.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=milosz@adfin.com \
--cc=tj@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).