LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Sibi Sankar <sibis@codeaurora.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
	devicetree@vger.kernel.org,
	Rajendra Nayak <rnayak@codeaurora.org>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Andy Gross <agross@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 8/9] arm64: dts: qcom: sc7280: Add AOSS QMP node
Date: Wed, 24 Mar 2021 12:35:04 +0530
Message-ID: <0a8540993e6f59c3b03e44e6aee4f81b@codeaurora.org> (raw)
In-Reply-To: <161647068330.3012082.2910442813045392403@swboyd.mtv.corp.google.com>

On 2021-03-23 09:08, Stephen Boyd wrote:
> Quoting Sibi Sankar (2021-03-08 21:58:21)
>> On 2021-02-27 19:26, Sai Prakash Ranjan wrote:
>> > On 2021-02-27 00:16, Stephen Boyd wrote:
>> >> Quoting Sai Prakash Ranjan (2021-02-25 23:51:00)
>> >>> On 2021-02-26 01:11, Stephen Boyd wrote:
>> >>> > Quoting Sai Prakash Ranjan (2021-02-25 01:30:24)
>> >>> >> Add a DT node for the AOSS QMP on SC7280 SoC.
>> >>> >>
>> >>> >> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
>> >>> >> ---
>> >>> >>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 14 ++++++++++++++
>> >>> >>  1 file changed, 14 insertions(+)
>> >>> >>
>> >>> >> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> >>> >> b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> >>> >> index 65c1e0f2fb56..cbd567ccc04e 100644
>> >>> >> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> >>> >> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> >>> >> @@ -9,6 +9,7 @@
>> >>> >>  #include <dt-bindings/clock/qcom,rpmh.h>
>> >>> >>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>> >>> >>  #include <dt-bindings/mailbox/qcom-ipcc.h>
>> >>> >> +#include <dt-bindings/power/qcom-aoss-qmp.h>
>> >>> >>  #include <dt-bindings/soc/qcom,rpmh-rsc.h>
>> >>> >>
>> >>> >>  / {
>> >>> >> @@ -368,6 +369,19 @@ pdc: interrupt-controller@b220000 {
>> >>> >>                         interrupt-controller;
>> >>> >>                 };
>> >>> >>
>> >>> >> +               aoss_qmp: qmp@c300000 {
>> >>> >
>> >>> > power-domain-controller@c300000? power-controller@c300000?
>> >>> >
>> >>>
>> >>> Its an AOSS message RAM and all other SM* SoCs have as qmp@
>> >>> and the dt binding as well, I see only SM8150 with power-controller,
>> >>> that should probably be fixed?
>> >>
>> >> Node name should be generic while still being meaningful. Nobody knows
>> >> what qmp is, but power-controller makes sense. Can you fix this and
>> >> the
>> >> others to be power-controller?
>> >>
>> 
>> we probably would be changing them back
>> to qmp or something more generic soon
>> since the consensus was qmp wasn't a
>> power-controller. So not sure if its
>> worth the effort here.
>> 
> 
> Hmm alright. Maybe mailbox? qmp is not generic. What does it stand for?
> qualcomm messaging protocol?

It's documented as ^^ in the git log
but I guess it should be called qualcomm
mailbox protocol instead. I don't think
it can be called mailbox since it doesn't
have mbox cells in its bindings.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.

  reply index

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25  9:30 [PATCH 0/9] qcom/sc7280: Enable various hardware blocks on SC7280 SoC Sai Prakash Ranjan
2021-02-25  9:30 ` [PATCH 1/9] dt-bindings: arm: msm: Add LLCC for SC7280 Sai Prakash Ranjan
2021-02-25 19:35   ` Stephen Boyd
2021-03-06 20:47   ` Rob Herring
2021-02-25  9:30 ` [PATCH 2/9] soc: qcom: llcc: Add configuration data " Sai Prakash Ranjan
2021-02-25  9:30 ` [PATCH 3/9] arm64: dts: qcom: sc7280: Add device tree node for LLCC Sai Prakash Ranjan
2021-02-25 19:37   ` Stephen Boyd
2021-02-26  8:04     ` Sai Prakash Ranjan
2021-02-26 18:45       ` Stephen Boyd
2021-02-27 13:58         ` Sai Prakash Ranjan
2021-03-01  4:21           ` Stephen Boyd
2021-02-25  9:30 ` [PATCH 4/9] dt-bindings: mailbox: qcom-ipcc: Add compatible for SC7280 Sai Prakash Ranjan
2021-02-25 14:13   ` Manivannan Sadhasivam
2021-02-25 19:38   ` Stephen Boyd
2021-02-25  9:30 ` [PATCH 5/9] arm64: dts: qcom: sc7280: Add IPCC for SC7280 SoC Sai Prakash Ranjan
2021-02-25 14:12   ` Manivannan Sadhasivam
2021-02-25 19:38   ` Stephen Boyd
2021-02-25  9:30 ` [PATCH 6/9] dt-bindings: soc: qcom: aoss: Add SC7280 compatible Sai Prakash Ranjan
2021-02-25 19:40   ` Stephen Boyd
2021-03-06 20:53   ` Rob Herring
2021-02-25  9:30 ` [PATCH 7/9] soc: qcom: aoss: Add AOSS QMP support for SC7280 Sai Prakash Ranjan
2021-02-25 19:40   ` Stephen Boyd
2021-02-25  9:30 ` [PATCH 8/9] arm64: dts: qcom: sc7280: Add AOSS QMP node Sai Prakash Ranjan
2021-02-25 19:41   ` Stephen Boyd
2021-02-26  7:51     ` Sai Prakash Ranjan
2021-02-26 18:46       ` Stephen Boyd
2021-02-27 13:56         ` Sai Prakash Ranjan
2021-03-09  5:58           ` Sibi Sankar
2021-03-23  3:38             ` Stephen Boyd
2021-03-24  7:05               ` Sibi Sankar [this message]
2021-02-25  9:30 ` [PATCH 9/9] arm64: dts: qcom: sc7280: Add Coresight support Sai Prakash Ranjan
2021-03-11 23:14 ` [PATCH 0/9] qcom/sc7280: Enable various hardware blocks on SC7280 SoC Bjorn Andersson
2021-03-14 19:05   ` Sai Prakash Ranjan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a8540993e6f59c3b03e44e6aee4f81b@codeaurora.org \
    --to=sibis@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rnayak@codeaurora.org \
    --cc=saiprakash.ranjan@codeaurora.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git