* [PATCH] watchdog: smsc37b787_wdt: Mark expected switch fall-through
@ 2019-02-14 20:16 Gustavo A. R. Silva
2019-02-18 16:08 ` Guenter Roeck
0 siblings, 1 reply; 5+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-14 20:16 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck
Cc: linux-watchdog, linux-kernel, Gustavo A. R. Silva, Kees Cook
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/watchdog/smsc37b787_wdt.c: In function ‘wb_smsc_wdt_ioctl’:
drivers/watchdog/smsc37b787_wdt.c:480:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
wb_smsc_wdt_set_timeout(timeout);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/watchdog/smsc37b787_wdt.c:482:2: note: here
case WDIOC_GETTIMEOUT:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/watchdog/smsc37b787_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/smsc37b787_wdt.c b/drivers/watchdog/smsc37b787_wdt.c
index 445ea1ad1fa9..c768dcd53034 100644
--- a/drivers/watchdog/smsc37b787_wdt.c
+++ b/drivers/watchdog/smsc37b787_wdt.c
@@ -478,7 +478,7 @@ static long wb_smsc_wdt_ioctl(struct file *file,
return -EINVAL;
timeout = new_timeout;
wb_smsc_wdt_set_timeout(timeout);
- /* fall through and return the new timeout... */
+ /* fall through - and return the new timeout... */
case WDIOC_GETTIMEOUT:
new_timeout = timeout;
if (unit == UNIT_MINUTE)
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] watchdog: smsc37b787_wdt: Mark expected switch fall-through
2019-02-14 20:16 [PATCH] watchdog: smsc37b787_wdt: Mark expected switch fall-through Gustavo A. R. Silva
@ 2019-02-18 16:08 ` Guenter Roeck
2019-02-26 17:42 ` Gustavo A. R. Silva
0 siblings, 1 reply; 5+ messages in thread
From: Guenter Roeck @ 2019-02-18 16:08 UTC (permalink / raw)
To: Gustavo A. R. Silva, Wim Van Sebroeck
Cc: linux-watchdog, linux-kernel, Kees Cook
On 2/14/19 12:16 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/watchdog/smsc37b787_wdt.c: In function ‘wb_smsc_wdt_ioctl’:
> drivers/watchdog/smsc37b787_wdt.c:480:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> wb_smsc_wdt_set_timeout(timeout);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/watchdog/smsc37b787_wdt.c:482:2: note: here
> case WDIOC_GETTIMEOUT:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/smsc37b787_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/smsc37b787_wdt.c b/drivers/watchdog/smsc37b787_wdt.c
> index 445ea1ad1fa9..c768dcd53034 100644
> --- a/drivers/watchdog/smsc37b787_wdt.c
> +++ b/drivers/watchdog/smsc37b787_wdt.c
> @@ -478,7 +478,7 @@ static long wb_smsc_wdt_ioctl(struct file *file,
> return -EINVAL;
> timeout = new_timeout;
> wb_smsc_wdt_set_timeout(timeout);
> - /* fall through and return the new timeout... */
> + /* fall through - and return the new timeout... */
> case WDIOC_GETTIMEOUT:
> new_timeout = timeout;
> if (unit == UNIT_MINUTE)
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] watchdog: smsc37b787_wdt: Mark expected switch fall-through
2019-02-18 16:08 ` Guenter Roeck
@ 2019-02-26 17:42 ` Gustavo A. R. Silva
2019-02-26 17:45 ` Guenter Roeck
0 siblings, 1 reply; 5+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-26 17:42 UTC (permalink / raw)
To: Guenter Roeck, Wim Van Sebroeck; +Cc: linux-watchdog, linux-kernel, Kees Cook
On 2/18/19 10:08 AM, Guenter Roeck wrote:
> On 2/14/19 12:16 PM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/watchdog/smsc37b787_wdt.c: In function ‘wb_smsc_wdt_ioctl’:
>> drivers/watchdog/smsc37b787_wdt.c:480:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> wb_smsc_wdt_set_timeout(timeout);
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/watchdog/smsc37b787_wdt.c:482:2: note: here
>> case WDIOC_GETTIMEOUT:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
Thank you, Guenter.
Friendly ping:
Who can take this?
Thanks
--
Gustavo
>> ---
>> drivers/watchdog/smsc37b787_wdt.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/watchdog/smsc37b787_wdt.c b/drivers/watchdog/smsc37b787_wdt.c
>> index 445ea1ad1fa9..c768dcd53034 100644
>> --- a/drivers/watchdog/smsc37b787_wdt.c
>> +++ b/drivers/watchdog/smsc37b787_wdt.c
>> @@ -478,7 +478,7 @@ static long wb_smsc_wdt_ioctl(struct file *file,
>> return -EINVAL;
>> timeout = new_timeout;
>> wb_smsc_wdt_set_timeout(timeout);
>> - /* fall through and return the new timeout... */
>> + /* fall through - and return the new timeout... */
>> case WDIOC_GETTIMEOUT:
>> new_timeout = timeout;
>> if (unit == UNIT_MINUTE)
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] watchdog: smsc37b787_wdt: Mark expected switch fall-through
2019-02-26 17:42 ` Gustavo A. R. Silva
@ 2019-02-26 17:45 ` Guenter Roeck
2019-02-28 18:27 ` Gustavo A. R. Silva
0 siblings, 1 reply; 5+ messages in thread
From: Guenter Roeck @ 2019-02-26 17:45 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Wim Van Sebroeck, linux-watchdog, linux-kernel, Kees Cook
On Tue, Feb 26, 2019 at 11:42:06AM -0600, Gustavo A. R. Silva wrote:
>
>
> On 2/18/19 10:08 AM, Guenter Roeck wrote:
> > On 2/14/19 12:16 PM, Gustavo A. R. Silva wrote:
> >> In preparation to enabling -Wimplicit-fallthrough, mark switch
> >> cases where we are expecting to fall through.
> >>
> >> This patch fixes the following warning:
> >>
> >> drivers/watchdog/smsc37b787_wdt.c: In function ‘wb_smsc_wdt_ioctl’:
> >> drivers/watchdog/smsc37b787_wdt.c:480:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> >> wb_smsc_wdt_set_timeout(timeout);
> >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >> drivers/watchdog/smsc37b787_wdt.c:482:2: note: here
> >> case WDIOC_GETTIMEOUT:
> >> ^~~~
> >>
> >> Warning level 3 was used: -Wimplicit-fallthrough=3
> >>
> >> Notice that, in this particular case, the code comment is modified
> >> in accordance with what GCC is expecting to find.
> >>
> >> This patch is part of the ongoing efforts to enable
> >> -Wimplicit-fallthrough.
> >>
> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> >
> > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> >
>
> Thank you, Guenter.
>
>
> Friendly ping:
>
> Who can take this?
>
It is queued in my watchdog-next branch. Usually Wim will pick it up from there.
Guenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] watchdog: smsc37b787_wdt: Mark expected switch fall-through
2019-02-26 17:45 ` Guenter Roeck
@ 2019-02-28 18:27 ` Gustavo A. R. Silva
0 siblings, 0 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-28 18:27 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Wim Van Sebroeck, linux-watchdog, linux-kernel, Kees Cook
On 2/26/19 11:45 AM, Guenter Roeck wrote:
>>
>>
>> Friendly ping:
>>
>> Who can take this?
>>
>
> It is queued in my watchdog-next branch. Usually Wim will pick it up from there.
>
> Guenter
>
Awesome. :)
Thanks!
--
Gustavo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-02-28 18:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-14 20:16 [PATCH] watchdog: smsc37b787_wdt: Mark expected switch fall-through Gustavo A. R. Silva
2019-02-18 16:08 ` Guenter Roeck
2019-02-26 17:42 ` Gustavo A. R. Silva
2019-02-26 17:45 ` Guenter Roeck
2019-02-28 18:27 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).