From: James Stevenson <james@stev.org>
To: Philippe Troin <phil@fifi.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.4.19: oops in ide-scsi
Date: 24 Sep 2002 22:41:46 +0100 [thread overview]
Message-ID: <1032903706.2445.4.camel@god.stev.org> (raw)
In-Reply-To: <87smzzksri.fsf@ceramic.fifi.org>
On Tue, 2002-09-24 at 22:00, Philippe Troin wrote:
> James Stevenson <james@stev.org> writes:
>
> > Hi
> >
> > i am glad somebody else sees the same crash as me the
> > request Q gets set to NULL for some reson then tries to
> > increment a stats counter in the null pointer.
> > i know what the bug is i just dont know how to fix it :>
>
> I'm not sure which Q you're talking about.
> Is that rq (in idescsi_pc_intr())?
the crash happens on
if (status & ERR_STAT)
rq->errors++;
because
struct request *rq = pc->rq;
is NULL
from ide-scsi.c
static ide_startstop_t idescsi_pc_intr (ide_drive_t *drive)
{
idescsi_scsi_t *scsi = drive->driver_data;
byte status, ireason;
int bcount;
idescsi_pc_t *pc=scsi->pc;
struct request *rq = pc->rq;
unsigned int temp;
// SNIPED some code
if ((status & DRQ_STAT) == 0) { /* No more interrupts */
if (test_bit(IDESCSI_LOG_CMD, &scsi->log))
printk (KERN_INFO "Packet command completed, %d bytes transferred\n",
pc->actually_transferred);
ide__sti();
if (status & ERR_STAT)
rq->errors++;
idescsi_end_request (1, HWGROUP(drive));
return ide_stopped;
}
bcount = IN_BYTE (IDE_BCOUNT
next prev parent reply other threads:[~2002-09-24 21:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-24 1:08 2.4.19: oops in ide-scsi Philippe Troin
2002-09-24 18:26 ` James Stevenson
2002-09-24 21:00 ` Philippe Troin
2002-09-24 21:41 ` James Stevenson [this message]
2002-09-25 16:46 ` Philippe Troin
2002-09-25 18:18 ` James Stevenson
2002-09-25 22:30 ` Philippe Troin
2002-09-26 8:51 ` James Stevenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1032903706.2445.4.camel@god.stev.org \
--to=james@stev.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phil@fifi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).