From: Robert Love <rml@tech9.net>
To: Patrick Mansfield <patmans@us.ibm.com>
Cc: Gert Vervoort <gert.vervoort@hccnet.nl>,
tconnors@astro.swin.edu.au, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Re: 2.5.67: ppa driver & preempt == oops
Date: 15 Apr 2003 17:37:56 -0400 [thread overview]
Message-ID: <1050442676.3664.162.camel@localhost> (raw)
In-Reply-To: <20030415120000.A30422@beaverton.ibm.com>
On Tue, 2003-04-15 at 15:00, Patrick Mansfield wrote:
> We never hold the host_lock while calling the detect function (unlike the
> io_request_lock, see the bizzare 2.4 code), so acquiring it inside
> ppa_detect is very wrong. I don't know why your scsi scan did not hang.
I do not have this device so I cannot test it, but your logic seems
correct.
This is a much nicer fix for the preempt-related issues than others
proposed, too.
Anyone out there who _can_ mount the device? Can you test this? It
ought to be merged if it works. We need to get device drivers in 2.5 up
to par..
Robert Love
next prev parent reply other threads:[~2003-04-15 21:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-12 15:03 2.5.67: ppa driver & preempt == oops Gert Vervoort
2003-04-12 18:28 ` Robert Love
2003-04-13 10:30 ` Gert Vervoort
2003-04-13 17:32 ` Robert Love
2003-04-13 17:44 ` Gert Vervoort
2003-04-15 19:00 ` [PATCH] " Patrick Mansfield
2003-04-15 20:44 ` Gert Vervoort
2003-04-15 21:40 ` Patrick Mansfield
2003-04-16 17:52 ` Gert Vervoort
2003-04-16 18:05 ` Patrick Mansfield
2003-04-16 19:45 ` Gert Vervoort
2003-04-16 20:07 ` Mike Anderson
2003-04-16 18:03 ` Gert Vervoort
2003-04-15 21:37 ` Robert Love [this message]
2003-04-15 21:51 ` Randy.Dunlap
2003-04-15 22:07 ` Patrick Mansfield
2003-04-15 22:29 ` Randy.Dunlap
2003-04-15 22:35 ` Patrick Mansfield
2003-04-12 21:12 ` Andrew Morton
2003-04-13 11:45 ` Gert Vervoort
2003-04-13 20:44 ` Andrew Morton
[not found] <fa.chdor2j.u72387@ifi.uio.no>
[not found] ` <fa.gs8uudl.196640l@ifi.uio.no>
2003-04-15 23:04 ` [PATCH] " walt
2003-04-15 23:25 ` Patrick Mansfield
2003-04-16 3:30 ` walt
[not found] <fa.hdvi4hc.152sj34@ifi.uio.no>
[not found] ` <fa.fnhqqrs.ok0028@ifi.uio.no>
2003-04-15 23:51 ` walt
2003-04-16 0:07 ` Randy.Dunlap
[not found] <fa.fo1ils5.o4kt21@ifi.uio.no>
[not found] ` <fa.jt2b7k8.20qj0c@ifi.uio.no>
2003-04-16 3:19 ` walt
2003-04-16 9:45 Chuck Ebbert
[not found] <fa.cde0mrb.127uv05@ifi.uio.no>
[not found] ` <fa.i9on98t.1gg0toj@ifi.uio.no>
2003-04-17 19:37 ` walt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1050442676.3664.162.camel@localhost \
--to=rml@tech9.net \
--cc=gert.vervoort@hccnet.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=patmans@us.ibm.com \
--cc=tconnors@astro.swin.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).