[PATCH] Re: 2.5.67: ppa driver & preempt == oops

[Patrick Mansfield <patmans@us.ibm.com>]

On Sun, Apr 13, 2003 at 07:44:04PM +0200, Gert Vervoort wrote:

Here is a patch against 2.5.67, can you try it out?

I did not compile let alone run with this patch.

We never hold the host_lock while calling the detect function (unlike the
io_request_lock, see the bizzare 2.4 code), so acquiring it inside
ppa_detect is very wrong. I don't know why your scsi scan did not hang.

--- linux-2.5.67/drivers/scsi/ppa.c-orig	Mon Apr  7 10:31:47 2003
+++ linux-2.5.67/drivers/scsi/ppa.c	Tue Apr 15 11:54:34 2003
@@ -219,15 +219,12 @@
 	    printk("  supported by the imm (ZIP Plus) driver. If the\n");
 	    printk("  cable is marked with \"AutoDetect\", this is what has\n");
 	    printk("  happened.\n");
-	    spin_lock_irq(hreg->host_lock);
 	    return 0;
 	}
 	try_again = 1;
 	goto retry_entry;
-    } else {
-	spin_lock_irq(hreg->host_lock);
+    } else
 	return 1;		/* return number of hosts detected */
-    }
 }
 
 /* This is to give the ppa driver a way to modify the timings (and other