From: Andrew Morton <akpm@digeo.com>
To: Gert Vervoort <gert.vervoort@hccnet.nl>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.5.67: ppa driver & preempt == oops
Date: Sat, 12 Apr 2003 14:12:48 -0700 [thread overview]
Message-ID: <20030412141248.47a487b0.akpm@digeo.com> (raw)
In-Reply-To: <3E982AAC.3060606@hccnet.nl>
Gert Vervoort <gert.vervoort@hccnet.nl> wrote:
>
> ppa: Version 2.07 (for Linux 2.4.x)
> ppa: Found device at ID 6, Attempting to use EPP 16 bit
> ppa: Communication established with ID 6 using EPP 16 bit
> scsi0 : Iomega VPI0 (ppa) interface
> bad: scheduling while atomic!
This patch should make the warnings go away.
I've been sitting on it for a while, waiting for someone to tell me if the
ppa driver actually works. Perhaps that person is you?
diff -puN drivers/scsi/ppa.c~ppa-null-pointer-fix drivers/scsi/ppa.c
--- 25/drivers/scsi/ppa.c~ppa-null-pointer-fix 2003-03-23 16:08:37.000000000 -0800
+++ 25-akpm/drivers/scsi/ppa.c 2003-03-23 16:09:14.000000000 -0800
@@ -219,13 +219,15 @@ int ppa_detect(Scsi_Host_Template * host
printk(" supported by the imm (ZIP Plus) driver. If the\n");
printk(" cable is marked with \"AutoDetect\", this is what has\n");
printk(" happened.\n");
- spin_lock_irq(hreg->host_lock);
+ if (hreg) /* This is silly */
+ spin_lock_irq(hreg->host_lock);
return 0;
}
try_again = 1;
goto retry_entry;
} else {
- spin_lock_irq(hreg->host_lock);
+ if (hreg) /* And this should be unnecessary */
+ spin_lock_irq(hreg->host_lock);
return 1; /* return number of hosts detected */
}
}
_
next prev parent reply other threads:[~2003-04-12 21:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-12 15:03 2.5.67: ppa driver & preempt == oops Gert Vervoort
2003-04-12 18:28 ` Robert Love
2003-04-13 10:30 ` Gert Vervoort
2003-04-13 17:32 ` Robert Love
2003-04-13 17:44 ` Gert Vervoort
2003-04-15 19:00 ` [PATCH] " Patrick Mansfield
2003-04-15 20:44 ` Gert Vervoort
2003-04-15 21:40 ` Patrick Mansfield
2003-04-16 17:52 ` Gert Vervoort
2003-04-16 18:05 ` Patrick Mansfield
2003-04-16 19:45 ` Gert Vervoort
2003-04-16 20:07 ` Mike Anderson
2003-04-16 18:03 ` Gert Vervoort
2003-04-15 21:37 ` Robert Love
2003-04-15 21:51 ` Randy.Dunlap
2003-04-15 22:07 ` Patrick Mansfield
2003-04-15 22:29 ` Randy.Dunlap
2003-04-15 22:35 ` Patrick Mansfield
2003-04-12 21:12 ` Andrew Morton [this message]
2003-04-13 11:45 ` Gert Vervoort
2003-04-13 20:44 ` Andrew Morton
[not found] <fa.e0puan3.1f34a3p@ifi.uio.no>
[not found] ` <fa.h6rb9ej.ml8qhn@ifi.uio.no>
2003-04-13 19:52 ` walt
[not found] <20030413201011$1026@gated-at.bofh.it>
[not found] ` <20030413201011$250d@gated-at.bofh.it>
[not found] ` <20030413201011$5dde@gated-at.bofh.it>
2003-04-14 4:17 ` Tim Connors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030412141248.47a487b0.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=gert.vervoort@hccnet.nl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).