From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: adaplas@pol.net
Cc: Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>,
Linus Torvalds <torvalds@osdl.org>,
Guido Guenther <agx@sigxcpu.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [Linux-fbdev-devel] Re: [PATCH] fbdev: Fix IO access in rivafb
Date: Sun, 14 Nov 2004 10:52:00 +1100 [thread overview]
Message-ID: <1100389920.20511.133.camel@gaston> (raw)
In-Reply-To: <200411140529.48977.adaplas@hotpop.com>
On Sun, 2004-11-14 at 05:29 +0800, Antonino A. Daplas wrote:
> On Sunday 14 November 2004 02:00, Linus Torvalds wrote:
> > On Sat, 13 Nov 2004, Antonino A. Daplas wrote:
> > > Why not use in_be* and out_be* for __raw_read and raw_write?
> >
> > Please don't start using some stupid magic ppc-specific macros for a
> > driver that has no reason to be PPC-specific. It then only causes bugs
> > that show on one platform and not another.
>
> I'm not. I'm just wondering that if the other approach was taken (keep the
> hardware in little endian mode), then the write/read* macros, which are just
> wrappers for in_le*/out_le*, would have been used. Would it help fix (or
> cover up) bugs that are in PPC but not x86?
If you switch the HW to LE, I'm afraid you'll lockup when VT switching
back & forth with X ...
Ben.
next prev parent reply other threads:[~2004-11-13 23:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200411080521.iA85LbG6025914@hera.kernel.org>
2004-11-08 5:57 ` [PATCH] fbdev: Fix IO access in rivafb Benjamin Herrenschmidt
2004-11-08 8:33 ` [Linux-fbdev-devel] " Antonino A. Daplas
2004-11-08 21:50 ` Benjamin Herrenschmidt
2004-11-08 22:18 ` Antonino A. Daplas
2004-11-08 9:06 ` Antonino A. Daplas
2004-11-08 9:55 ` Geert Uytterhoeven
2004-11-08 15:21 ` Linus Torvalds
2004-11-08 20:02 ` Antonino A. Daplas
2004-11-08 20:13 ` Linus Torvalds
2004-11-08 22:08 ` Antonino A. Daplas
2004-11-08 22:25 ` Linus Torvalds
2004-11-12 12:51 ` Guido Guenther
2004-11-12 16:01 ` Linus Torvalds
2004-11-12 19:18 ` Guido Guenther
2004-11-12 19:32 ` Linus Torvalds
2004-11-13 12:57 ` Guido Guenther
2004-11-13 1:39 ` Benjamin Herrenschmidt
2004-11-13 11:22 ` Guido Guenther
2004-11-13 12:00 ` Antonino A. Daplas
2004-11-13 13:02 ` Guido Guenther
2004-11-13 18:00 ` Linus Torvalds
2004-11-13 21:29 ` Antonino A. Daplas
2004-11-13 22:54 ` Guido Guenther
2004-11-13 23:52 ` Benjamin Herrenschmidt [this message]
2004-11-13 23:49 ` Benjamin Herrenschmidt
2004-11-13 12:20 ` Yasushi SHOJI
2004-11-19 1:48 ` readl/writel: swap or not to swap (was: [PATCH] fbdev: Fix IO access in rivafb) Yasushi SHOJI
2004-11-19 4:09 ` readl/writel: swap or not to swap Jeff Garzik
2004-11-19 7:24 ` Yasushi SHOJI
2004-11-08 21:52 ` [Linux-fbdev-devel] Re: [PATCH] fbdev: Fix IO access in rivafb Benjamin Herrenschmidt
2004-11-08 23:07 ` Giuseppe Bilotta
2004-11-13 23:22 ` Guido Guenther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1100389920.20511.133.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=adaplas@pol.net \
--cc=agx@sigxcpu.org \
--cc=akpm@osdl.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).