From: Guido Guenther <agx@sigxcpu.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: adaplas@pol.net,
Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [Linux-fbdev-devel] Re: [PATCH] fbdev: Fix IO access in rivafb
Date: Sat, 13 Nov 2004 13:57:53 +0100 [thread overview]
Message-ID: <20041113125753.GA4763@bogon.ms20.nix> (raw)
In-Reply-To: <Pine.LNX.4.58.0411121130550.2301@ppc970.osdl.org>
On Fri, Nov 12, 2004 at 11:32:07AM -0800, Linus Torvalds wrote:
>
>
> On Fri, 12 Nov 2004, Guido Guenther wrote:
> >
> > O.k., it was the __raw_{write,read}b which broke things, not the
> > "alignment". This one works:
>
> All right, that's as expected. However, it does seem to point out that the
> riva driver depends on _different_ memory ordering guarantees for the
> 8-bit accesses as opposed to the other ones. Whee. Can you say "UGGLEE"?
Aglie. This scared me too, so I had another look. It seems P{V,C}IO
areas are only accessed using VGA_{RD,WR}8 macros. NV_{RW,WR}08 are
never actually used directly. So this patch makes at least usage
consistent. VGA_{RD,WR}8 to access "I/O areas" in an ordered way. NV_*
for the rest. Please apply.
Cheers,
-- Guido
--- linux-2.6.10-rc1-mm5/drivers/video/riva/riva_hw.orig.2 2004-11-13 12:24:48.000000000 +0100
+++ linux-2.6.10-rc1-mm5/drivers/video/riva/riva_hw.h 2004-11-13 12:24:56.000000000 +0100
@@ -75,15 +75,15 @@
*/
#include <asm/io.h>
-#define NV_WR08(p,i,d) (writeb((d), (void __iomem *)(p) + (i)))
-#define NV_RD08(p,i) (readb((void __iomem *)(p) + (i)))
+#define NV_WR08(p,i,d) (__raw_writeb((d), (void __iomem *)(p) + (i)))
+#define NV_RD08(p,i) (__raw_readb((void __iomem *)(p) + (i)))
#define NV_WR16(p,i,d) (__raw_writew((d), (void __iomem *)(p) + (i)))
#define NV_RD16(p,i) (__raw_readw((void __iomem *)(p) + (i)))
#define NV_WR32(p,i,d) (__raw_writel((d), (void __iomem *)(p) + (i)))
#define NV_RD32(p,i) (__raw_readl((void __iomem *)(p) + (i)))
-#define VGA_WR08(p,i,d) NV_WR08(p,i,d)
-#define VGA_RD08(p,i) NV_RD08(p,i)
+#define VGA_WR08(p,i,d) (writeb((d), (void __iomem *)(p) + (i)))
+#define VGA_RD08(p,i) (readb((void __iomem *)(p) + (i)))
/*
* Define different architectures.
Signed-Off-By: Guido Guenther <agx@sigxcpu.org>
next prev parent reply other threads:[~2004-11-13 13:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200411080521.iA85LbG6025914@hera.kernel.org>
2004-11-08 5:57 ` [PATCH] fbdev: Fix IO access in rivafb Benjamin Herrenschmidt
2004-11-08 8:33 ` [Linux-fbdev-devel] " Antonino A. Daplas
2004-11-08 21:50 ` Benjamin Herrenschmidt
2004-11-08 22:18 ` Antonino A. Daplas
2004-11-08 9:06 ` Antonino A. Daplas
2004-11-08 9:55 ` Geert Uytterhoeven
2004-11-08 15:21 ` Linus Torvalds
2004-11-08 20:02 ` Antonino A. Daplas
2004-11-08 20:13 ` Linus Torvalds
2004-11-08 22:08 ` Antonino A. Daplas
2004-11-08 22:25 ` Linus Torvalds
2004-11-12 12:51 ` Guido Guenther
2004-11-12 16:01 ` Linus Torvalds
2004-11-12 19:18 ` Guido Guenther
2004-11-12 19:32 ` Linus Torvalds
2004-11-13 12:57 ` Guido Guenther [this message]
2004-11-13 1:39 ` Benjamin Herrenschmidt
2004-11-13 11:22 ` Guido Guenther
2004-11-13 12:00 ` Antonino A. Daplas
2004-11-13 13:02 ` Guido Guenther
2004-11-13 18:00 ` Linus Torvalds
2004-11-13 21:29 ` Antonino A. Daplas
2004-11-13 22:54 ` Guido Guenther
2004-11-13 23:52 ` Benjamin Herrenschmidt
2004-11-13 23:49 ` Benjamin Herrenschmidt
2004-11-13 12:20 ` Yasushi SHOJI
2004-11-19 1:48 ` readl/writel: swap or not to swap (was: [PATCH] fbdev: Fix IO access in rivafb) Yasushi SHOJI
2004-11-19 4:09 ` readl/writel: swap or not to swap Jeff Garzik
2004-11-19 7:24 ` Yasushi SHOJI
2004-11-08 21:52 ` [Linux-fbdev-devel] Re: [PATCH] fbdev: Fix IO access in rivafb Benjamin Herrenschmidt
2004-11-08 23:07 ` Giuseppe Bilotta
2004-11-13 23:22 ` Guido Guenther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041113125753.GA4763@bogon.ms20.nix \
--to=agx@sigxcpu.org \
--cc=adaplas@pol.net \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).