From: Guido Guenther <agx@sigxcpu.org>
To: Giuseppe Bilotta <bilotta78@hotpop.com>
Cc: linux-kernel@vger.kernel.org, linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [Linux-fbdev-devel] Re: [PATCH] fbdev: Fix IO access in rivafb
Date: Sun, 14 Nov 2004 00:22:55 +0100 [thread overview]
Message-ID: <20041113232255.GA25845@bogon.ms20.nix> (raw)
In-Reply-To: <MPG.1bfa1abaf653d37c98970a@news.gmane.org>
On Tue, Nov 09, 2004 at 12:07:58AM +0100, Giuseppe Bilotta wrote:
> Benjamin Herrenschmidt wrote:
> > On Mon, 2004-11-08 at 17:06 +0800, Antonino A. Daplas wrote:
> >
> > >
> > > How about this patch? This is almost the original macro in riva_hw.h,
> > > with the __force annotation.
> >
> > I don't like it neither. It lacks barriers. the rivafb driver
> > notoriously lacks barriers, except in a few places where it was so bad
> > that it actually broke all the time, where we added some. This
> > originates from the X "nv" driver written by Mark Vojkovich who didn't
> > want to hear about barriers for perfs reasons I think.
>
> Could this be the reason why in 2.6.7 I get solid lockups when
> switching to nv-driven X and rivafb-driven console? Is there
> something I could test to see if this is the reason?
Please try 2.6.10-rc1-mm5. It should work there.
-- Guido
prev parent reply other threads:[~2004-11-13 23:29 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200411080521.iA85LbG6025914@hera.kernel.org>
2004-11-08 5:57 ` [PATCH] fbdev: Fix IO access in rivafb Benjamin Herrenschmidt
2004-11-08 8:33 ` [Linux-fbdev-devel] " Antonino A. Daplas
2004-11-08 21:50 ` Benjamin Herrenschmidt
2004-11-08 22:18 ` Antonino A. Daplas
2004-11-08 9:06 ` Antonino A. Daplas
2004-11-08 9:55 ` Geert Uytterhoeven
2004-11-08 15:21 ` Linus Torvalds
2004-11-08 20:02 ` Antonino A. Daplas
2004-11-08 20:13 ` Linus Torvalds
2004-11-08 22:08 ` Antonino A. Daplas
2004-11-08 22:25 ` Linus Torvalds
2004-11-12 12:51 ` Guido Guenther
2004-11-12 16:01 ` Linus Torvalds
2004-11-12 19:18 ` Guido Guenther
2004-11-12 19:32 ` Linus Torvalds
2004-11-13 12:57 ` Guido Guenther
2004-11-13 1:39 ` Benjamin Herrenschmidt
2004-11-13 11:22 ` Guido Guenther
2004-11-13 12:00 ` Antonino A. Daplas
2004-11-13 13:02 ` Guido Guenther
2004-11-13 18:00 ` Linus Torvalds
2004-11-13 21:29 ` Antonino A. Daplas
2004-11-13 22:54 ` Guido Guenther
2004-11-13 23:52 ` Benjamin Herrenschmidt
2004-11-13 23:49 ` Benjamin Herrenschmidt
2004-11-13 12:20 ` Yasushi SHOJI
2004-11-19 1:48 ` readl/writel: swap or not to swap (was: [PATCH] fbdev: Fix IO access in rivafb) Yasushi SHOJI
2004-11-19 4:09 ` readl/writel: swap or not to swap Jeff Garzik
2004-11-19 7:24 ` Yasushi SHOJI
2004-11-08 21:52 ` [Linux-fbdev-devel] Re: [PATCH] fbdev: Fix IO access in rivafb Benjamin Herrenschmidt
2004-11-08 23:07 ` Giuseppe Bilotta
2004-11-13 23:22 ` Guido Guenther [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041113232255.GA25845@bogon.ms20.nix \
--to=agx@sigxcpu.org \
--cc=bilotta78@hotpop.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).