From: Mingming Cao <cmm@us.ibm.com>
To: Jens Axboe <axboe@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
seelam@cs.utep.edu, linux-kernel@vger.kernel.org,
ext2-devel@lists.sourceforge.net
Subject: [PATCH] Fall back io scheduler ( Re: [Ext2-devel] Re: Fall back io scheduler for 2.6.15?)
Date: Mon, 16 Jan 2006 11:45:35 -0800 [thread overview]
Message-ID: <1137440735.3724.17.camel@dyn9047017067.beaverton.ibm.com> (raw)
In-Reply-To: <20060116084309.GN3945@suse.de>
On Mon, 2006-01-16 at 09:43 +0100, Jens Axboe wrote:
> On Fri, Jan 13 2006, Andrew Morton wrote:
> > Mingming Cao <cmm@us.ibm.com> wrote:
> > >
> > > On 2.6.14, the
> > > fall back io scheduler (if the chosen io scheduler is not found) is set
> > > to the default io scheduler (anticipatory, in this case), but since
> > > 2.6.15-rc1, this semanistic is changed to fall back to noop.
> >
> > OK. And I assume that AS wasn't compiled, so that's why it fell back?
> >
> > I actually thought that elevator= got removed, now we have
> > /sys/block/sda/queue/scheduler. But I guess that's not very useful with
> > CONFIG_SYSFS=n.
> >
> > > Is there any reason to fall back to noop instead of as? It seems
> > > anticipatory is much better than noop for ext3 with large sequential
> > > write tests (i.e, 1G dd test) ...
> >
> > I suspect that was an accident. Jens?
>
> It is, it makes more sense to fallback to the default of course.
>
How about this one?
In the case the chosen io scheduler (elevator = "xxx") is not on the
registered list, fall back to default scheduler makes more sense.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
---
linux-2.6.15-ming/block/elevator.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -puN block/elevator.c~default-fall-back-scheduler-fix
block/elevator.c
--- linux-2.6.15/block/elevator.c~default-fall-back-scheduler-fix
2006-01-16 11:42:04.000446588 -0800
+++ linux-2.6.15-ming/block/elevator.c 2006-01-16 11:42:41.145131615
-0800
@@ -151,12 +151,12 @@ static void elevator_setup_default(void)
strcpy(chosen_elevator, CONFIG_DEFAULT_IOSCHED);
/*
- * If the given scheduler is not available, fall back to no-op.
+ * If the given scheduler is not available, fall back to default.
*/
if ((e = elevator_find(chosen_elevator)))
elevator_put(e);
else
- strcpy(chosen_elevator, "noop");
+ strcpy(chosen_elevator, CONFIG_DEFAULT_IOSCHED);
}
static int __init elevator_setup(char *str)
_
next prev parent reply other threads:[~2006-01-16 19:45 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-05 3:51 ext3 allocate-with-reservation latencies Lee Revell
2005-04-05 4:13 ` Ingo Molnar
2005-04-05 6:10 ` Mingming Cao
2005-04-05 16:38 ` Lee Revell
2005-04-06 5:35 ` Mingming Cao
2005-04-06 9:51 ` Stephen C. Tweedie
2005-04-06 16:53 ` Mingming Cao
2005-04-06 18:22 ` Stephen C. Tweedie
2005-04-06 19:03 ` Mingming Cao
2005-04-07 8:14 ` Ingo Molnar
2005-04-07 13:08 ` Stephen C. Tweedie
2005-04-07 19:16 ` Mingming Cao
2005-04-07 23:37 ` Mingming Cao
2005-04-08 14:40 ` Stephen C. Tweedie
2005-04-08 16:06 ` Arjan van de Ven
2005-04-08 18:10 ` Mingming Cao
2005-04-08 18:12 ` Lee Revell
2005-04-11 11:48 ` Stephen C. Tweedie
2005-04-11 18:38 ` Mingming Cao
2005-04-11 19:12 ` Lee Revell
2005-04-11 19:22 ` Lee Revell
2005-04-11 19:57 ` Stephen C. Tweedie
2005-04-12 6:41 ` Mingming Cao
2005-04-12 11:18 ` Stephen C. Tweedie
2005-04-12 23:27 ` Mingming Cao
2005-04-13 10:29 ` Stephen C. Tweedie
[not found] ` <1113597161.3899.80.camel@localhost.localdomain>
2005-04-18 18:00 ` Stephen C. Tweedie
2005-04-18 21:56 ` [Ext2-devel] " Mingming Cao
2005-04-22 22:10 ` [RFC][PATCH] Reduce ext3 allocate-with-reservation lock latencies Mingming Cao
2005-04-28 3:45 ` Lee Revell
2005-04-28 7:37 ` Mingming Cao
2005-04-28 16:12 ` Lee Revell
2005-04-28 18:34 ` Mingming Cao
2005-04-29 6:18 ` Mingming Cao
2005-04-28 19:14 ` [RFC] Adding multiple block allocation to current ext3 Mingming Cao
2005-04-29 13:52 ` [Ext2-devel] [RFC] Adding multiple block allocation Suparna Bhattacharya
2005-04-29 17:10 ` Mingming Cao
2005-04-29 19:42 ` Mingming Cao
2005-04-29 20:57 ` Andrew Morton
2005-04-29 21:12 ` Mingming Cao
2005-04-29 21:34 ` Andrew Morton
2005-04-30 16:00 ` Suparna Bhattacharya
2005-04-29 18:45 ` Badari Pulavarty
2005-04-29 23:22 ` Mingming Cao
2005-04-30 16:10 ` Suparna Bhattacharya
2005-04-30 17:11 ` Suparna Bhattacharya
2005-04-30 18:07 ` Mingming Cao
2005-05-02 4:46 ` Suparna Bhattacharya
2005-04-30 16:52 ` Suparna Bhattacharya
2005-04-30 0:33 ` Mingming Cao
2005-04-30 0:44 ` Mingming Cao
2005-04-30 17:03 ` Suparna Bhattacharya
2006-01-10 23:26 ` [PATCH 0/5] multiple block allocation to current ext3 Mingming Cao
2006-01-11 5:25 ` Andrew Morton
2006-01-11 19:17 ` Mingming Cao
2006-01-11 19:43 ` Andrew Morton
2006-01-11 21:31 ` Mingming Cao
2006-01-14 1:12 ` Fall back io scheduler for 2.6.15? Mingming Cao
2006-01-14 1:49 ` Andrew Morton
2006-01-14 5:22 ` Dave Jones
2006-01-16 8:43 ` Jens Axboe
2006-01-16 19:45 ` Mingming Cao [this message]
2006-01-16 19:49 ` [PATCH] Fall back io scheduler ( Re: [Ext2-devel] Re: Fall back io scheduler for 2.6.15?) Jens Axboe
2006-01-16 19:57 ` Mingming Cao
2006-01-19 19:37 ` Fall back io scheduler for 2.6.15? Nate Diller
2006-01-20 8:10 ` Jens Axboe
2006-01-16 19:38 ` [Ext2-devel] " Mingming Cao
2005-04-29 6:28 ` [PATCH] Reduce ext3 allocate-with-reservation lock latencies Mingming Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1137440735.3724.17.camel@dyn9047017067.beaverton.ibm.com \
--to=cmm@us.ibm.com \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=seelam@cs.utep.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).