From: Suparna Bhattacharya <suparna@in.ibm.com>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: Mingming Cao <cmm@us.ibm.com>, Andrew Morton <akpm@osdl.org>,
"Stephen C. Tweedie" <sct@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
ext2-devel <ext2-devel@lists.sourceforge.net>,
linux-fsdevel@vger.kernel.org
Subject: Re: [Ext2-devel] [RFC] Adding multiple block allocation
Date: Sat, 30 Apr 2005 22:22:16 +0530 [thread overview]
Message-ID: <20050430165216.GD3941@in.ibm.com> (raw)
In-Reply-To: <427280C1.8090404@us.ibm.com>
On Fri, Apr 29, 2005 at 11:45:21AM -0700, Badari Pulavarty wrote:
> Suparna Bhattacharya wrote:
> >On Thu, Apr 28, 2005 at 12:14:24PM -0700, Mingming Cao wrote:
> >
> >>Currently ext3_get_block()/ext3_new_block() only allocate one block at a
> >>time. To allocate multiple blocks, the caller, for example, ext3 direct
> >>IO routine, has to invoke ext3_get_block() many times. This is quite
> >>inefficient for sequential IO workload.
> >>
> >>The benefit of a real get_blocks() include
> >>1) increase the possibility to get contiguous blocks, reduce possibility
> >>of fragmentation due to interleaved allocations from other threads.
> >>(should good for non reservation case)
> >>2) Reduces CPU cycles spent in repeated get_block() calls
> >>3) Batch meta data update and journaling in one short
> >>4) Could possibly speed up future get_blocks() look up by cache the last
> >>mapped blocks in inode.
> >>
> >
> >
> >And here is the patch to make mpage_writepages use get_blocks() for
> >multiple block lookup/allocation. It performs a radix-tree contiguous
> >pages lookup, and issues a get_blocks for the range together. It maintains
> >an mpageio structure to track intermediate mapping state, somewhat
> >like the DIO code.
> >
> >It does need some more testing, especially block_size < PAGE_SIZE.
> >The JFS workaround can be dropped if the JFS get_blocks fix from
> >Dave Kleikamp is integrated.
> >
> >Review feedback would be welcome.
> >
> >Mingming,
> >Let me know if you have a chance to try this out with your patch.
> >
> >Regards
> >Suparna
> >
>
> Suparna,
>
> I touch tested your patch earlier and seems to work fine. Lets integrate
> Mingming's getblocks() patches with this and see if we get any benifit
> from the whole effort.
>
> BTW, is it the plan to remove repeated calls to getblocks() and work
> with whatever getblocks() returned ? Or do you find the its better to
> repeatedly do getblocks() in a loop till you satisfy all the pages
> in the list (as long as blocks are contiguous) ?
The patch only loops through repeated get_blocks upto PAGE_SIZE, just
like the earlier mpage_writepage code - in this case if blocks aren't
contiguous at least upto PAGE_SIZE, it would fall back to confused case
(since it means multiple ios for the same page) just as before.
What is new now is just the numblocks specified to get_blocks, so in
case it gets more contiguous blocks it can remember that mapping and
avoid get_blocks calls for subsequent pages.
Does that clarify ?
Regards
Suparna
--
Suparna Bhattacharya (suparna@in.ibm.com)
Linux Technology Center
IBM Software Lab, India
next prev parent reply other threads:[~2005-04-30 16:43 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-05 3:51 ext3 allocate-with-reservation latencies Lee Revell
2005-04-05 4:13 ` Ingo Molnar
2005-04-05 6:10 ` Mingming Cao
2005-04-05 16:38 ` Lee Revell
2005-04-06 5:35 ` Mingming Cao
2005-04-06 9:51 ` Stephen C. Tweedie
2005-04-06 16:53 ` Mingming Cao
2005-04-06 18:22 ` Stephen C. Tweedie
2005-04-06 19:03 ` Mingming Cao
2005-04-07 8:14 ` Ingo Molnar
2005-04-07 13:08 ` Stephen C. Tweedie
2005-04-07 19:16 ` Mingming Cao
2005-04-07 23:37 ` Mingming Cao
2005-04-08 14:40 ` Stephen C. Tweedie
2005-04-08 16:06 ` Arjan van de Ven
2005-04-08 18:10 ` Mingming Cao
2005-04-08 18:12 ` Lee Revell
2005-04-11 11:48 ` Stephen C. Tweedie
2005-04-11 18:38 ` Mingming Cao
2005-04-11 19:12 ` Lee Revell
2005-04-11 19:22 ` Lee Revell
2005-04-11 19:57 ` Stephen C. Tweedie
2005-04-12 6:41 ` Mingming Cao
2005-04-12 11:18 ` Stephen C. Tweedie
2005-04-12 23:27 ` Mingming Cao
2005-04-13 10:29 ` Stephen C. Tweedie
[not found] ` <1113597161.3899.80.camel@localhost.localdomain>
2005-04-18 18:00 ` Stephen C. Tweedie
2005-04-18 21:56 ` [Ext2-devel] " Mingming Cao
2005-04-22 22:10 ` [RFC][PATCH] Reduce ext3 allocate-with-reservation lock latencies Mingming Cao
2005-04-28 3:45 ` Lee Revell
2005-04-28 7:37 ` Mingming Cao
2005-04-28 16:12 ` Lee Revell
2005-04-28 18:34 ` Mingming Cao
2005-04-29 6:18 ` Mingming Cao
2005-04-28 19:14 ` [RFC] Adding multiple block allocation to current ext3 Mingming Cao
2005-04-29 13:52 ` [Ext2-devel] [RFC] Adding multiple block allocation Suparna Bhattacharya
2005-04-29 17:10 ` Mingming Cao
2005-04-29 19:42 ` Mingming Cao
2005-04-29 20:57 ` Andrew Morton
2005-04-29 21:12 ` Mingming Cao
2005-04-29 21:34 ` Andrew Morton
2005-04-30 16:00 ` Suparna Bhattacharya
2005-04-29 18:45 ` Badari Pulavarty
2005-04-29 23:22 ` Mingming Cao
2005-04-30 16:10 ` Suparna Bhattacharya
2005-04-30 17:11 ` Suparna Bhattacharya
2005-04-30 18:07 ` Mingming Cao
2005-05-02 4:46 ` Suparna Bhattacharya
2005-04-30 16:52 ` Suparna Bhattacharya [this message]
2005-04-30 0:33 ` Mingming Cao
2005-04-30 0:44 ` Mingming Cao
2005-04-30 17:03 ` Suparna Bhattacharya
2006-01-10 23:26 ` [PATCH 0/5] multiple block allocation to current ext3 Mingming Cao
2006-01-11 5:25 ` Andrew Morton
2006-01-11 19:17 ` Mingming Cao
2006-01-11 19:43 ` Andrew Morton
2006-01-11 21:31 ` Mingming Cao
2006-01-14 1:12 ` Fall back io scheduler for 2.6.15? Mingming Cao
2006-01-14 1:49 ` Andrew Morton
2006-01-14 5:22 ` Dave Jones
2006-01-16 8:43 ` Jens Axboe
2006-01-16 19:45 ` [PATCH] Fall back io scheduler ( Re: [Ext2-devel] Re: Fall back io scheduler for 2.6.15?) Mingming Cao
2006-01-16 19:49 ` Jens Axboe
2006-01-16 19:57 ` Mingming Cao
2006-01-19 19:37 ` Fall back io scheduler for 2.6.15? Nate Diller
2006-01-20 8:10 ` Jens Axboe
2006-01-16 19:38 ` [Ext2-devel] " Mingming Cao
2005-04-29 6:28 ` [PATCH] Reduce ext3 allocate-with-reservation lock latencies Mingming Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050430165216.GD3941@in.ibm.com \
--to=suparna@in.ibm.com \
--cc=akpm@osdl.org \
--cc=cmm@us.ibm.com \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).