linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Frans Pop <elendil@planet.nl>,
	linux-kernel@vger.kernel.org, tglx@linutronix.de,
	trivial@kernel.org, Andy Whitcroft <apw@shadowen.org>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Joel Schopp <jschopp@austin.ibm.com>
Subject: Re: Trailing periods in kernel messages
Date: Thu, 29 Nov 2007 18:35:28 -0800	[thread overview]
Message-ID: <1196390128.22120.118.camel@localhost> (raw)
In-Reply-To: <474F6D4D.9010006@cn.fujitsu.com>

On Fri, 2007-11-30 at 09:54 +0800, Li Zefan wrote:
> So it doesn't deserve the effort to eliminate these periods, isn't it?

I hope these will eventually disappear.

> Or we can add a check to checkpatch.pl to prevent new ones.

Perhaps that's a good idea.

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index cbb4258..707f84c 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1390,6 +1390,10 @@ sub process {
 		if ($line =~ /\*\s*\)\s*k[czm]alloc\b/) {
 			WARN("unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr);
 		}
+
+		if ($rawline =~ /(print|pr_(emerg|alert|crit|err|warning|notice|info|debug)).*\.\\n\"/) {
+			WARN("unnecessary period before newline\n" . $herecurr);
+		}
 	}
 
 	if ($chk_patch && !$is_patch) {



  reply	other threads:[~2007-11-30  2:37 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-29  7:35 [PATCH 6/6] tick: add a missing dot in prink Li Zefan
2007-11-29  8:58 ` Frans Pop
2007-11-29  9:29   ` Li Zefan
2007-11-29 10:20     ` Trailing periods in kernel messages (was: [PATCH 6/6] tick: add a missing dot in prink) Frans Pop
2007-11-29 11:20       ` Andrew Morton
2007-11-30  1:12         ` Trailing periods in kernel messages Li Zefan
2007-11-30  1:30           ` Joe Perches
2007-11-30  1:54             ` Li Zefan
2007-11-30  2:35               ` Joe Perches [this message]
2007-12-20 16:29                 ` Andy Whitcroft
2007-12-20 21:07                   ` Alan Cox
2007-12-20 21:43                     ` Joe Perches
2007-12-20 21:54                       ` Alan Cox
2007-12-20 22:19                         ` Andrew Morton
2007-12-20 22:34                           ` Randy Dunlap
2007-12-20 23:40                           ` Alan Cox
2007-12-20 22:22                         ` Theodore Tso
2007-12-20 23:38                           ` Alan Cox
2007-12-21 15:54                       ` Lennart Sorensen
2007-12-20 21:51                     ` David Miller
2007-12-20 22:07                       ` Joe Perches
2007-12-20 22:08                         ` Alan Cox
2007-12-20 23:14                           ` J.A. Magallón
2007-12-21  0:04                           ` Joe Perches
2007-12-21  0:40                             ` Alan Cox
2007-12-21  9:56                           ` Herbert Xu
2007-12-21 10:10                             ` Jan Engelhardt
2007-12-21 10:12                               ` David Miller
2007-12-21 13:43                                 ` David Newall
2007-12-21 14:01                                   ` David Miller
2007-12-21 15:37                                     ` David Newall
2007-12-21 11:41                               ` Herbert Xu
2007-12-21 11:55                                 ` Jan Engelhardt
2007-12-21 16:01                                   ` Lennart Sorensen
2007-12-22 14:04                                     ` Benny Amorsen
2007-12-22 20:20                                       ` Radoslaw Szkodzinski
2007-12-21 12:06                               ` David Schwartz
2007-12-21 15:18                               ` Stefan Richter
2007-12-20 22:09                       ` Roland Dreier
2007-12-21  1:43                     ` Frans Pop
2007-12-21  2:15                       ` Andrew Morton
2007-12-21  3:12                         ` David Miller
2007-12-21 10:15                         ` Jan Engelhardt
2007-12-21 10:21                       ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1196390128.22120.118.camel@localhost \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@shadowen.org \
    --cc=elendil@planet.nl \
    --cc=jschopp@austin.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=rdunlap@xenotime.net \
    --cc=tglx@linutronix.de \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).