From: Randy Dunlap <rdunlap@xenotime.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
joe@perches.com, apw@shadowen.org, lizf@cn.fujitsu.com,
elendil@planet.nl, linux-kernel@vger.kernel.org,
tglx@linutronix.de, trivial@kernel.org, rdunlap@xenotime.net,
jschopp@austin.ibm.com
Subject: Re: Trailing periods in kernel messages
Date: Thu, 20 Dec 2007 14:34:18 -0800 [thread overview]
Message-ID: <20071220143418.03696d3e.rdunlap@xenotime.net> (raw)
In-Reply-To: <20071220141928.a49eba7b.akpm@linux-foundation.org>
On Thu, 20 Dec 2007 14:19:28 -0800 Andrew Morton wrote:
> On Thu, 20 Dec 2007 21:54:11 +0000
> Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
>
> > > Documentation/Coding Style
> > >
> > > Chapter 13: Printing kernel messages
> > >
> > > Kernel messages do not have to be terminated with a period.
> >
> >
> > This piece of the document is wrong. It should also be changed. I've no
> > idea how such a ludicrous statement ever got into the Coding Style but I
> > have never seen it discussed and an archive search suggests it just
> > sneaked in without any kind of approval and discussion the list.
> >
> > Kernel messages are in English. Let us keep it that way. Missing
> > punctuation is equated by many parts of the English speaking world with
> > poor quality, sloppy products and low levels of education. These are not
> > things with which we wish to be associated IMHO.
> >
> > NAK to the patch.
>
> akpm:/usr/src/linux-2.6.24-rc5> grep -r '[^\.]\\n"' . | wc -l
> 105297
> akpm:/usr/src/linux-2.6.24-rc5> grep -r '[\.]\\n"' . | wc -l
> 12743
>
> For the record, I won't be taking any "add period to printk" patches.
IMO if checkpatch contains a check for trailing periods, it should
only be part of the strict/pedantic checks.
But it's not needed.
> akpm:/usr/src/linux-2.6.24-rc5> grep -r '[^\.]\\n"' net | wc -l
> 4978
> akpm:/usr/src/linux-2.6.24-rc5> grep -r '[\.]\\n"' net | wc -l
> 493
>
> Send 'em to Dave!
---
~Randy
next prev parent reply other threads:[~2007-12-20 22:34 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-29 7:35 [PATCH 6/6] tick: add a missing dot in prink Li Zefan
2007-11-29 8:58 ` Frans Pop
2007-11-29 9:29 ` Li Zefan
2007-11-29 10:20 ` Trailing periods in kernel messages (was: [PATCH 6/6] tick: add a missing dot in prink) Frans Pop
2007-11-29 11:20 ` Andrew Morton
2007-11-30 1:12 ` Trailing periods in kernel messages Li Zefan
2007-11-30 1:30 ` Joe Perches
2007-11-30 1:54 ` Li Zefan
2007-11-30 2:35 ` Joe Perches
2007-12-20 16:29 ` Andy Whitcroft
2007-12-20 21:07 ` Alan Cox
2007-12-20 21:43 ` Joe Perches
2007-12-20 21:54 ` Alan Cox
2007-12-20 22:19 ` Andrew Morton
2007-12-20 22:34 ` Randy Dunlap [this message]
2007-12-20 23:40 ` Alan Cox
2007-12-20 22:22 ` Theodore Tso
2007-12-20 23:38 ` Alan Cox
2007-12-21 15:54 ` Lennart Sorensen
2007-12-20 21:51 ` David Miller
2007-12-20 22:07 ` Joe Perches
2007-12-20 22:08 ` Alan Cox
2007-12-20 23:14 ` J.A. Magallón
2007-12-21 0:04 ` Joe Perches
2007-12-21 0:40 ` Alan Cox
2007-12-21 9:56 ` Herbert Xu
2007-12-21 10:10 ` Jan Engelhardt
2007-12-21 10:12 ` David Miller
2007-12-21 13:43 ` David Newall
2007-12-21 14:01 ` David Miller
2007-12-21 15:37 ` David Newall
2007-12-21 11:41 ` Herbert Xu
2007-12-21 11:55 ` Jan Engelhardt
2007-12-21 16:01 ` Lennart Sorensen
2007-12-22 14:04 ` Benny Amorsen
2007-12-22 20:20 ` Radoslaw Szkodzinski
2007-12-21 12:06 ` David Schwartz
2007-12-21 15:18 ` Stefan Richter
2007-12-20 22:09 ` Roland Dreier
2007-12-21 1:43 ` Frans Pop
2007-12-21 2:15 ` Andrew Morton
2007-12-21 3:12 ` David Miller
2007-12-21 10:15 ` Jan Engelhardt
2007-12-21 10:21 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071220143418.03696d3e.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=apw@shadowen.org \
--cc=elendil@planet.nl \
--cc=joe@perches.com \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).