From: Li Zefan <lizf@cn.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Frans Pop <elendil@planet.nl>,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
trivial@kernel.org
Subject: Re: Trailing periods in kernel messages
Date: Fri, 30 Nov 2007 09:12:18 +0800 [thread overview]
Message-ID: <474F6372.70705@cn.fujitsu.com> (raw)
In-Reply-To: <20071129032036.4c021617.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Thu, 29 Nov 2007 11:20:18 +0100 Frans Pop <elendil@planet.nl> wrote:
>
>> Well, for one it needlessly increases the size of log files.
>> It also IMO just looks weird to have a trailing period only for some
>> messages and it certainly is completely inappropriate for messages like:
>
> I'll confess to stealthily deleting some of those periods when nobody is looking.
> I don't find them to have any value and they do have some cost, including screen
> real estate at the source-code level.
>
>
Just a roughly grep:
# grep -r -P --include=*.[ch] 'printk.*\.\\n' * | wc -l
6025
# grep -r -P --include=*.[ch] '\.\\n' * | wc -l
12723
:)
next prev parent reply other threads:[~2007-11-30 1:15 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-29 7:35 [PATCH 6/6] tick: add a missing dot in prink Li Zefan
2007-11-29 8:58 ` Frans Pop
2007-11-29 9:29 ` Li Zefan
2007-11-29 10:20 ` Trailing periods in kernel messages (was: [PATCH 6/6] tick: add a missing dot in prink) Frans Pop
2007-11-29 11:20 ` Andrew Morton
2007-11-30 1:12 ` Li Zefan [this message]
2007-11-30 1:30 ` Trailing periods in kernel messages Joe Perches
2007-11-30 1:54 ` Li Zefan
2007-11-30 2:35 ` Joe Perches
2007-12-20 16:29 ` Andy Whitcroft
2007-12-20 21:07 ` Alan Cox
2007-12-20 21:43 ` Joe Perches
2007-12-20 21:54 ` Alan Cox
2007-12-20 22:19 ` Andrew Morton
2007-12-20 22:34 ` Randy Dunlap
2007-12-20 23:40 ` Alan Cox
2007-12-20 22:22 ` Theodore Tso
2007-12-20 23:38 ` Alan Cox
2007-12-21 15:54 ` Lennart Sorensen
2007-12-20 21:51 ` David Miller
2007-12-20 22:07 ` Joe Perches
2007-12-20 22:08 ` Alan Cox
2007-12-20 23:14 ` J.A. Magallón
2007-12-21 0:04 ` Joe Perches
2007-12-21 0:40 ` Alan Cox
2007-12-21 9:56 ` Herbert Xu
2007-12-21 10:10 ` Jan Engelhardt
2007-12-21 10:12 ` David Miller
2007-12-21 13:43 ` David Newall
2007-12-21 14:01 ` David Miller
2007-12-21 15:37 ` David Newall
2007-12-21 11:41 ` Herbert Xu
2007-12-21 11:55 ` Jan Engelhardt
2007-12-21 16:01 ` Lennart Sorensen
2007-12-22 14:04 ` Benny Amorsen
2007-12-22 20:20 ` Radoslaw Szkodzinski
2007-12-21 12:06 ` David Schwartz
2007-12-21 15:18 ` Stefan Richter
2007-12-20 22:09 ` Roland Dreier
2007-12-21 1:43 ` Frans Pop
2007-12-21 2:15 ` Andrew Morton
2007-12-21 3:12 ` David Miller
2007-12-21 10:15 ` Jan Engelhardt
2007-12-21 10:21 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474F6372.70705@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=elendil@planet.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).