From: Vinod Koul <vinod.koul@intel.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-kernel@vger.kernel.org,
"'Jassi Brar'" <jassisinghbrar@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Magnus Damm <magnus.damm@gmail.com>,
Paul Mundt <lethal@linux-sh.org>
Subject: Re: [PATCH/RFC] dmaengine: add a slave parameter to __dma_request_channel()
Date: Thu, 08 Mar 2012 12:00:01 +0530 [thread overview]
Message-ID: <1331188201.4657.51.camel@vkoul-udesk3> (raw)
In-Reply-To: <Pine.LNX.4.64.1203071906040.19595@axis700.grange>
On Wed, 2012-03-07 at 19:21 +0100, Guennadi Liakhovetski wrote:
> >
> > Why are you thinking that the filter function implementation has to be
> > provided by the peripheral driver? That's just wrong and broken.
>
> Again: because I don't like adding private APIs to a generic one.
>
> > Think about it - how does the peripheral driver know what kind of dma
> > channel its filter function has been passed - to give an example, if
> > you built into your kernel support for the PL08x DMA engine, and lets
> > say you had PL08x DMA engine hardware, how would your filter function
> > decide whether it was one of your per-device channels or whether it
> > was a PL08x DMA engine channel?
>
> Sorry, there must be a confusion here: I was not proposing the above
> implementation for all hardware types, I don't have a good overview of all
> possible DMA engine scenarious and, fortunately, I don't have to implement
> anything that generic:-)
>
> Even though I did write above "arch/arm/mach-shmobile/board-*.c" it
> probably wasn't clear enough: I was only talking about the shdma DMA
> engine driver and its clients. And so far on all sh-mobile hardware, that
> I'm aware of, we haven't been mixing DMA engine types on the same
> hardware. This is going to change soon, as soon as we get USBHS?-DMAC
> support in the kernel, but even then, those controllers will not be
> interchangeable: only USBHS devices will be served by USBHS-DMAC
> controllers, the rest can be served by any other controller. So, matching
> on a DMA controller device would perfectly suffice.
>
> Of course, client drivers have no access to those device objects, that's
> why those lists have to be provided to them by the platform code.
We are trying to solve this problem by making it a client or dmac
problem rather than a platform problem. We *miss* the point here in
discussion that platform *knows* the channel mapping and *not* dmac or
client, so any solution not based on this would not work, so let the
platform provide this to dmaengine.
We can have the map as*
[*with due credit to Linus Walleij, whose idea I have extended a small
bit to have multiple channel and 1 to many mapping]
struct dmaengine_map {
char *ch_name;
char *client_name;
char *dmac_name;
unsigned int ch;
};
struct dmaengine_map[] = {
{
.name = "MMC-RX",
.client_name = "mmc.0",
.dmac_name = "pl08x.0",
.ch = 0;
},
/* mmc.0 device can use pl08x.0 controller ch 0 */
{
.name = "MMC-TX",
.client_name = "mmc.0",
.dmac_name = "pl08x.0",
.ch = 1;
},
/* mmc.0 device can use pl08x.0 controller ch 1 */
{
.name = "SSP-TX",
.client_name = "pl022.0",
.dmac_name = "pl022.0",
.ch = 1;
},
/* SSP-TX device can use pl022.0 controller ch 1 */
{
.name = "SSP-RX",
.client_name = "pl022.0",
.dmac_name = "pl022.0",
.ch = 2;
},
/* SSP-TX device can use pl022.0 controller ch 2 */
{
.name = "MMC-TX",
.client_name = "pl022.0",
.dmac_name = "pl022.0",
.ch = 2;
},
/* BTW I ahve ultra spl hardware where
* SSP-TX device can also use pl022.0 controller ch 2 */
...
};
This also takes care care of many to 1 mapping where a channel can talk
to multiple clients and dmaengine choose first in list.
If we do virtual channels (which I would advise) then we can have 1-1
mapping, even otherwise dmaengine can pick first channel, and client has
right to refuse (filter fn ofcourse!)
So we can add
int dmaengine_add_channel_map(struct dmaengine_map *map, unsigned int num_entries)
{
/* store this map into dmaengine and use for channle allocation */
}
This map can be given by device tree, board files, etc based on each
what the respective arch deems the best way.
And based on yesterday discussion, I like Russell's idea of hiding
dma_slave_config, so:
struct dma_chan *dma_request_channel_config(mask, fn, data, config)
{
struct dma_chan *c = dma_request_channel(mask, fn, data);
if (c) {
if (dmaengine_slave_config(c, config)) {
dma_release_channel(c);
c = NULL;
}
}
return c;
}
where
struct dma_chan *dma_request_channel(mask, fn, data)
{
for_each_match_in_map(c, map) {
if (fn && ! fn(c, data))
continue;
return chan;
}
return NULL;
}
At this point the client has the channel it needs to use .prepare_xxx
API without the need of anything else...
Does this model fit all?
--
~Vinod
next prev parent reply other threads:[~2012-03-08 6:25 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 15:26 [PATCH/RFC] dmaengine: add a slave parameter to __dma_request_channel() Guennadi Liakhovetski
2012-03-02 13:21 ` Guennadi Liakhovetski
2012-03-06 8:30 ` Vinod Koul
2012-03-06 8:53 ` Guennadi Liakhovetski
2012-03-06 12:08 ` Vinod Koul
2012-03-06 13:03 ` Guennadi Liakhovetski
2012-03-07 6:28 ` Vinod Koul
2012-03-07 9:18 ` Guennadi Liakhovetski
2012-03-07 9:30 ` Russell King - ARM Linux
2012-03-07 9:55 ` Linus Walleij
2012-03-07 10:02 ` Guennadi Liakhovetski
2012-03-07 10:31 ` Russell King - ARM Linux
2012-03-07 12:30 ` Guennadi Liakhovetski
2012-03-07 12:45 ` Guennadi Liakhovetski
2012-03-07 12:46 ` Russell King - ARM Linux
2012-03-07 13:49 ` Guennadi Liakhovetski
2012-03-07 14:26 ` Russell King - ARM Linux
2012-03-07 15:44 ` Guennadi Liakhovetski
2012-03-07 16:27 ` Russell King - ARM Linux
2012-03-07 18:21 ` Guennadi Liakhovetski
2012-03-08 6:30 ` Vinod Koul [this message]
2012-03-08 10:16 ` Guennadi Liakhovetski
2012-03-08 10:55 ` Vinod Koul
2012-03-08 11:22 ` Guennadi Liakhovetski
2012-03-08 11:34 ` Vinod Koul
2012-03-08 12:58 ` Vinod Koul
2012-03-08 13:18 ` Guennadi Liakhovetski
2012-03-09 9:21 ` Vinod Koul
2012-03-09 9:24 ` Guennadi Liakhovetski
2012-03-09 9:39 ` Vinod Koul
2012-03-09 12:20 ` Guennadi Liakhovetski
2012-03-09 14:07 ` Russell King - ARM Linux
2012-03-09 14:15 ` Guennadi Liakhovetski
2012-03-12 2:47 ` Vinod Koul
2012-03-12 19:47 ` Linus Walleij
2012-03-16 9:36 ` Guennadi Liakhovetski
2012-03-16 10:16 ` Linus Walleij
2012-03-16 10:31 ` Russell King - ARM Linux
2012-03-16 11:09 ` Guennadi Liakhovetski
2012-03-16 14:11 ` Linus Walleij
2012-03-16 14:28 ` Guennadi Liakhovetski
2012-03-30 5:44 ` Linus Walleij
2012-03-30 6:40 ` Guennadi Liakhovetski
2012-03-30 10:38 ` Russell King - ARM Linux
2012-04-03 20:36 ` Linus Walleij
2012-04-03 20:44 ` Linus Walleij
2012-04-12 21:33 ` Guennadi Liakhovetski
2012-04-12 23:48 ` Russell King - ARM Linux
2012-03-30 10:29 ` Russell King - ARM Linux
2012-03-30 10:40 ` Guennadi Liakhovetski
2012-03-30 10:43 ` Russell King - ARM Linux
2012-03-19 11:58 ` Vinod Koul
2012-03-30 10:25 ` Russell King - ARM Linux
2012-03-19 11:39 ` Vinod Koul
2012-03-19 11:37 ` Vinod Koul
2012-03-19 11:47 ` Guennadi Liakhovetski
2012-03-19 13:34 ` Vinod Koul
2012-03-19 13:38 ` Guennadi Liakhovetski
2012-03-19 14:00 ` Vinod Koul
2012-03-19 14:09 ` Guennadi Liakhovetski
2012-03-19 14:22 ` Vinod Koul
2012-03-19 14:45 ` Guennadi Liakhovetski
2012-03-19 16:20 ` Vinod Koul
2012-03-19 16:32 ` Guennadi Liakhovetski
2012-03-20 7:11 ` Vinod Koul
2012-03-08 11:46 ` Linus Walleij
2012-03-08 12:36 ` Guennadi Liakhovetski
2012-03-07 16:31 ` Linus Walleij
2012-03-07 16:20 ` Linus Walleij
2012-03-07 9:46 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331188201.4657.51.camel@vkoul-udesk3 \
--to=vinod.koul@intel.com \
--cc=g.liakhovetski@gmx.de \
--cc=jassisinghbrar@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).