From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Vinod Koul <vinod.koul@intel.com>,
linux-kernel@vger.kernel.org,
Jassi Brar <jassisinghbrar@gmail.com>,
Magnus Damm <magnus.damm@gmail.com>,
Paul Mundt <lethal@linux-sh.org>
Subject: Re: [PATCH/RFC] dmaengine: add a slave parameter to __dma_request_channel()
Date: Fri, 30 Mar 2012 11:43:54 +0100 [thread overview]
Message-ID: <20120330104354.GD22981@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.1203301236330.24548@axis700.grange>
On Fri, Mar 30, 2012 at 12:40:12PM +0200, Guennadi Liakhovetski wrote:
> On Fri, 30 Mar 2012, Russell King - ARM Linux wrote:
>
> > On Fri, Mar 16, 2012 at 03:28:39PM +0100, Guennadi Liakhovetski wrote:
> > > Yessss!!! Let's do that! :-D Now, you're proposing exactly the same, as
> > > what I was proposing! :-) Now you just have to remove the filter function
> > > parameter from dma_request_channel() - it is anyway the same for all and
> > > implemented in the dmaengine core - and you get
> > >
> > > dma_request_channel(mask, slave_desc)
> > >
> > > which is exactly what I was proposing! :-)
> >
> > Bollocks it is. You're wanting to use the peripheral address, width
> > and burst size to try to determine what channel to use. That's a
> > totally crackpot idea, and as I've already said several times it won't
> > work in many real life cases we have already.
>
> I'm afraid I'm just somehow failing to explain my thoughts to you,
> Russell. I don't think I ever said about using addresses, widths etc.
Not directly - what you said was about combining the request functionality
along with the slave_config functionality. The slave_config functionality
takes exactly what I said above: the addresses, widths, burst size of the
peripheral.
Therefore, you did _by implication of what the functions you have been
referring to do_ been talking exactly about using addresses, widths and
burst sizes to select the channel.
next prev parent reply other threads:[~2012-03-30 10:44 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 15:26 [PATCH/RFC] dmaengine: add a slave parameter to __dma_request_channel() Guennadi Liakhovetski
2012-03-02 13:21 ` Guennadi Liakhovetski
2012-03-06 8:30 ` Vinod Koul
2012-03-06 8:53 ` Guennadi Liakhovetski
2012-03-06 12:08 ` Vinod Koul
2012-03-06 13:03 ` Guennadi Liakhovetski
2012-03-07 6:28 ` Vinod Koul
2012-03-07 9:18 ` Guennadi Liakhovetski
2012-03-07 9:30 ` Russell King - ARM Linux
2012-03-07 9:55 ` Linus Walleij
2012-03-07 10:02 ` Guennadi Liakhovetski
2012-03-07 10:31 ` Russell King - ARM Linux
2012-03-07 12:30 ` Guennadi Liakhovetski
2012-03-07 12:45 ` Guennadi Liakhovetski
2012-03-07 12:46 ` Russell King - ARM Linux
2012-03-07 13:49 ` Guennadi Liakhovetski
2012-03-07 14:26 ` Russell King - ARM Linux
2012-03-07 15:44 ` Guennadi Liakhovetski
2012-03-07 16:27 ` Russell King - ARM Linux
2012-03-07 18:21 ` Guennadi Liakhovetski
2012-03-08 6:30 ` Vinod Koul
2012-03-08 10:16 ` Guennadi Liakhovetski
2012-03-08 10:55 ` Vinod Koul
2012-03-08 11:22 ` Guennadi Liakhovetski
2012-03-08 11:34 ` Vinod Koul
2012-03-08 12:58 ` Vinod Koul
2012-03-08 13:18 ` Guennadi Liakhovetski
2012-03-09 9:21 ` Vinod Koul
2012-03-09 9:24 ` Guennadi Liakhovetski
2012-03-09 9:39 ` Vinod Koul
2012-03-09 12:20 ` Guennadi Liakhovetski
2012-03-09 14:07 ` Russell King - ARM Linux
2012-03-09 14:15 ` Guennadi Liakhovetski
2012-03-12 2:47 ` Vinod Koul
2012-03-12 19:47 ` Linus Walleij
2012-03-16 9:36 ` Guennadi Liakhovetski
2012-03-16 10:16 ` Linus Walleij
2012-03-16 10:31 ` Russell King - ARM Linux
2012-03-16 11:09 ` Guennadi Liakhovetski
2012-03-16 14:11 ` Linus Walleij
2012-03-16 14:28 ` Guennadi Liakhovetski
2012-03-30 5:44 ` Linus Walleij
2012-03-30 6:40 ` Guennadi Liakhovetski
2012-03-30 10:38 ` Russell King - ARM Linux
2012-04-03 20:36 ` Linus Walleij
2012-04-03 20:44 ` Linus Walleij
2012-04-12 21:33 ` Guennadi Liakhovetski
2012-04-12 23:48 ` Russell King - ARM Linux
2012-03-30 10:29 ` Russell King - ARM Linux
2012-03-30 10:40 ` Guennadi Liakhovetski
2012-03-30 10:43 ` Russell King - ARM Linux [this message]
2012-03-19 11:58 ` Vinod Koul
2012-03-30 10:25 ` Russell King - ARM Linux
2012-03-19 11:39 ` Vinod Koul
2012-03-19 11:37 ` Vinod Koul
2012-03-19 11:47 ` Guennadi Liakhovetski
2012-03-19 13:34 ` Vinod Koul
2012-03-19 13:38 ` Guennadi Liakhovetski
2012-03-19 14:00 ` Vinod Koul
2012-03-19 14:09 ` Guennadi Liakhovetski
2012-03-19 14:22 ` Vinod Koul
2012-03-19 14:45 ` Guennadi Liakhovetski
2012-03-19 16:20 ` Vinod Koul
2012-03-19 16:32 ` Guennadi Liakhovetski
2012-03-20 7:11 ` Vinod Koul
2012-03-08 11:46 ` Linus Walleij
2012-03-08 12:36 ` Guennadi Liakhovetski
2012-03-07 16:31 ` Linus Walleij
2012-03-07 16:20 ` Linus Walleij
2012-03-07 9:46 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120330104354.GD22981@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=g.liakhovetski@gmx.de \
--cc=jassisinghbrar@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).