* [BUG] checkpatch.pl with commit 058806007450489bb8f457b275e5cb5c946320c1
@ 2012-10-24 11:00 Jeff Kirsher
2012-10-24 14:12 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Kirsher @ 2012-10-24 11:00 UTC (permalink / raw)
To: Joe Perches; +Cc: netdev, LKML
[-- Attachment #1: Type: text/plain, Size: 718 bytes --]
With the recent commit to checkpatch.pl:
commit 058806007450489bb8f457b275e5cb5c946320c1
Author: Joe Perches <joe@perches.com>
Date: Thu Oct 4 17:13:35 2012 -0700
checkpatch: check networking specific block comment style
We are seeing false positive warnings. Here is an example of the
code the would generate a false warning:
#define foo 0x0000 /* foo comment */
checkpatch.pl generates a warnings that the */ should be on a separate
line, which in this case is incorrect.
I apologize for not digging into the checkpatch.pl code to provide a
fix, I figure Joe (or anyone else with great checkpatch kung fu) can
figure out the issue and fix it faster than I could. :-)
Cheers,
Jeff
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [BUG] checkpatch.pl with commit 058806007450489bb8f457b275e5cb5c946320c1
2012-10-24 11:00 [BUG] checkpatch.pl with commit 058806007450489bb8f457b275e5cb5c946320c1 Jeff Kirsher
@ 2012-10-24 14:12 ` Joe Perches
2012-10-24 20:51 ` Jeff Kirsher
0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2012-10-24 14:12 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, LKML
On Wed, 2012-10-24 at 04:00 -0700, Jeff Kirsher wrote:
> With the recent commit to checkpatch.pl:
>
> commit 058806007450489bb8f457b275e5cb5c946320c1
> Author: Joe Perches <joe@perches.com>
> Date: Thu Oct 4 17:13:35 2012 -0700
>
> checkpatch: check networking specific block comment style
>
> We are seeing false positive warnings. Here is an example of the
> code the would generate a false warning:
>
> #define foo 0x0000 /* foo comment */
>
> checkpatch.pl generates a warnings that the */ should be on a separate
> line, which in this case is incorrect.
Sorry 'bout that. I believe it's fixed by:
https://lkml.org/lkml/2012/10/14/267
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [BUG] checkpatch.pl with commit 058806007450489bb8f457b275e5cb5c946320c1
2012-10-24 14:12 ` Joe Perches
@ 2012-10-24 20:51 ` Jeff Kirsher
2012-10-24 21:26 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Kirsher @ 2012-10-24 20:51 UTC (permalink / raw)
To: Joe Perches; +Cc: netdev, LKML
[-- Attachment #1: Type: text/plain, Size: 949 bytes --]
On Wed, 2012-10-24 at 07:12 -0700, Joe Perches wrote:
> On Wed, 2012-10-24 at 04:00 -0700, Jeff Kirsher wrote:
> > With the recent commit to checkpatch.pl:
> >
> > commit 058806007450489bb8f457b275e5cb5c946320c1
> > Author: Joe Perches <joe@perches.com>
> > Date: Thu Oct 4 17:13:35 2012 -0700
> >
> > checkpatch: check networking specific block comment style
> >
> > We are seeing false positive warnings. Here is an example of the
> > code the would generate a false warning:
> >
> > #define foo 0x0000 /* foo comment */
> >
> > checkpatch.pl generates a warnings that the */ should be on a separate
> > line, which in this case is incorrect.
>
> Sorry 'bout that. I believe it's fixed by:
> https://lkml.org/lkml/2012/10/14/267
>
Yes, I confirm that the patch in the link you provided solves the issue
I was seeing. Thanks, has the patch been accepted yet? I see it is not
in Dave's NET tree as of yet.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [BUG] checkpatch.pl with commit 058806007450489bb8f457b275e5cb5c946320c1
2012-10-24 20:51 ` Jeff Kirsher
@ 2012-10-24 21:26 ` Joe Perches
0 siblings, 0 replies; 4+ messages in thread
From: Joe Perches @ 2012-10-24 21:26 UTC (permalink / raw)
To: jeffrey.t.kirsher, Andrew Morton; +Cc: netdev, LKML
On Wed, 2012-10-24 at 13:51 -0700, Jeff Kirsher wrote:
> On Wed, 2012-10-24 at 07:12 -0700, Joe Perches wrote:
> > On Wed, 2012-10-24 at 04:00 -0700, Jeff Kirsher wrote:
> > > With the recent commit to checkpatch.pl:
> > >
> > > commit 058806007450489bb8f457b275e5cb5c946320c1
> > > Author: Joe Perches <joe@perches.com>
> > > Date: Thu Oct 4 17:13:35 2012 -0700
> > >
> > > checkpatch: check networking specific block comment style
> > >
> > > We are seeing false positive warnings. Here is an example of the
> > > code the would generate a false warning:
> > >
> > > #define foo 0x0000 /* foo comment */
> > >
> > > checkpatch.pl generates a warnings that the */ should be on a separate
> > > line, which in this case is incorrect.
> >
> > Sorry 'bout that. I believe it's fixed by:
> > https://lkml.org/lkml/2012/10/14/267
> >
>
> Yes, I confirm that the patch in the link you provided solves the issue
> I was seeing. Thanks, has the patch been accepted yet? I see it is not
> in Dave's NET tree as of yet.
Andrew Morton generally picks up my checkpatch twiddles.
It's in -next as of next-20121024.
commit db64ad0e6f55197bc3794bef007a25f2db4760fb
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-10-24 21:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-24 11:00 [BUG] checkpatch.pl with commit 058806007450489bb8f457b275e5cb5c946320c1 Jeff Kirsher
2012-10-24 14:12 ` Joe Perches
2012-10-24 20:51 ` Jeff Kirsher
2012-10-24 21:26 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).