From: Zhang Rui <rui.zhang@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Peter Feuerer <peter@piie.net>,
Alexander Lam <azl@andrew.cmu.edu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andreas Mohr <andi@lisas.de>
Subject: Re: thermal governor: does it actually work??
Date: Tue, 19 Feb 2013 23:27:55 +0800 [thread overview]
Message-ID: <1361287675.2323.26.camel@rzhang1-mobl4> (raw)
In-Reply-To: <20130219150551.GL26623@pd.tnic>
On Tue, 2013-02-19 at 16:05 +0100, Borislav Petkov wrote:
> On Tue, Feb 19, 2013 at 10:51:04PM +0800, Zhang Rui wrote:
> > Okay, here I see the problem, say you want to turn on the fan at 60C and
> > turn it off at 55C, is this what you want?
> > hmmm, is it possible to do some tricks in acerhdf driver?
> > say,
> > only one active trip point as before. but change acerhdf_get_trip_temp
> > to:
> > acerhdf_get_trip_temp()
> > {
> > if (fan is on)
> > return 55;
> > else
> > return 60;
> > }
> >
> > In this way, when the fan is off and the temperature is raising, the fan
> > will be turned on at 60C because we have an active trip point of 60C.
> > And when the fan is turned on and the temperature starts to drop, the
> > fan will be turned off at 55C.
>
> Makes a sense to me. I was questioning the need for 4 trip points too.
I do not understand why you need 4 trip points for the issue above,
unless I missed another gap here.
> We probably would need a second, critical trip point though, just in
> case.
>
yeah, it is okay to have a critical trip point.
thanks,
rui
next prev parent reply other threads:[~2013-02-19 15:28 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 15:32 thermal governor: does it actually work?? Andreas Mohr
2013-02-15 9:47 ` Zhang, Rui
2013-02-15 15:49 ` Andreas Mohr
2013-02-16 21:08 ` Alexander Lam
2013-02-16 21:47 ` Borislav Petkov
2013-02-17 2:43 ` Peter Feuerer
2013-02-17 14:09 ` Borislav Petkov
2013-02-17 15:41 ` Peter Feuerer
2013-02-18 13:50 ` Borislav Petkov
2013-02-18 16:47 ` Peter Feuerer
2013-02-19 14:51 ` Zhang Rui
2013-02-19 15:05 ` Borislav Petkov
2013-02-19 15:27 ` Zhang Rui [this message]
[not found] ` <CACWwPisqpmLjiqEh+J2DjnEtNObmmA0w=qMQYTgBsb6Ntad7Pw@mail.gmail.com>
[not found] ` <744357E9AAD1214791ACBA4B0B90926329F98E@SHSMSX101.ccr.corp.intel.com>
[not found] ` <CACWwPit=xxeeCW1+jfxE8eww+P545B5xebh3YT2yE78zcsqSMg@mail.gmail.com>
2013-02-18 20:33 ` Alexander Lam
2013-02-19 14:53 ` Zhang Rui
2013-02-19 15:35 ` Zhang Rui
2013-02-22 5:33 ` Peter Feuerer
2013-02-22 11:15 ` Borislav Petkov
2013-02-23 19:20 ` [PATCH] acerhdf: Fix fan activation with new thermal governor Borislav Petkov
2013-02-24 11:28 ` Borislav Petkov
2013-02-24 11:42 ` Peter Feuerer
2013-02-24 12:09 ` Borislav Petkov
2013-02-24 12:59 ` Borislav Petkov
2013-02-25 3:06 ` Zhang Rui
2013-02-25 10:20 ` Borislav Petkov
2013-02-25 10:36 ` Peter Feuerer
2013-02-24 14:34 ` Borislav Petkov
2013-02-25 3:21 ` Zhang Rui
2013-02-25 10:25 ` Borislav Petkov
2013-02-25 12:16 ` Borislav Petkov
2013-03-04 13:34 ` Borislav Petkov
2013-03-04 19:25 ` Andreas Mohr
2013-03-05 21:59 ` Andreas Mohr
2013-03-06 3:47 ` Zhang Rui
2013-03-06 7:00 ` Borislav Petkov
2013-03-06 7:30 ` Zhang Rui
2013-03-06 7:36 ` Borislav Petkov
2013-03-07 20:17 ` Peter Feuerer
2013-03-07 20:27 ` Borislav Petkov
2013-02-25 3:01 ` Zhang Rui
2013-02-25 2:58 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361287675.2323.26.camel@rzhang1-mobl4 \
--to=rui.zhang@intel.com \
--cc=andi@lisas.de \
--cc=azl@andrew.cmu.edu \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@piie.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).