linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zhang Rui <rui.zhang@intel.com>
To: Peter Feuerer <peter@piie.net>
Cc: Borislav Petkov <bp@alien8.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Durgadoss R <durgadoss.r@intel.com>, Borislav Petkov <bp@suse.de>,
	Andreas Mohr <andi@lisas.de>, Alexander Lam <azl@andrew.cmu.edu>
Subject: Re: [PATCH] acerhdf: Fix fan activation with new thermal governor
Date: Mon, 25 Feb 2013 11:01:54 +0800	[thread overview]
Message-ID: <1361761314.2303.9.camel@rzhang1-mobl4> (raw)
In-Reply-To: <cone.1361706175.908398.1806.1000@galar>

On Sun, 2013-02-24 at 12:42 +0100, Peter Feuerer wrote:
> Hi Boris,
> 
> thanks for your best wishes in the last mail, I'm feeling little better now.
> 
> Borislav Petkov writes:
> 
> > On Sat, Feb 23, 2013 at 08:20:10PM +0100, Borislav Petkov wrote:
> >> From: Borislav Petkov <bp@suse.de>
> >> 
> >> The new step_wise thermal governor wasn't able to handle the one-trip
> >> point design of acerhdf where we want to turn off the fan if we go under
> >> the 'fanoff' temperature and to turn it on only after exceeding the
> >> 'fanon' temperature.
> >> 
> >> Do that by looking at the current fan state and return the temperature
> >> accordingly.
> >> 
> >> Suggested-by: Zhang Rui <rui.zhang@intel.com>
> >> Cc: Peter Feuerer <peter@piie.net>
> >> Cc: Andreas Mohr <andi@lisas.de>
> >> Cc: Alexander Lam <azl@andrew.cmu.edu>
> >> Signed-off-by: Borislav Petkov <bp@suse.de>
> > 
> > Ok, ignore this one for now - the suspend/resume path doesn't pan out
> > somehow, need to do some more handholding here.
> 
> Please test my last patch with the 4 trip points ;) - even if you don't 
> really like it, it is working great! - And to be honest, I still prefer this 
> solution!
> 
well, the 4 trip points do not make sense, at least the passive trip
point is a no op as we have no passive cooling device binded with it.

thanks,
rui


  parent reply	other threads:[~2013-02-25  3:02 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-14 15:32 thermal governor: does it actually work?? Andreas Mohr
2013-02-15  9:47 ` Zhang, Rui
2013-02-15 15:49   ` Andreas Mohr
2013-02-16 21:08     ` Alexander Lam
2013-02-16 21:47       ` Borislav Petkov
2013-02-17  2:43         ` Peter Feuerer
2013-02-17 14:09           ` Borislav Petkov
2013-02-17 15:41             ` Peter Feuerer
2013-02-18 13:50               ` Borislav Petkov
2013-02-18 16:47                 ` Peter Feuerer
2013-02-19 14:51                   ` Zhang Rui
2013-02-19 15:05                     ` Borislav Petkov
2013-02-19 15:27                       ` Zhang Rui
     [not found]     ` <CACWwPisqpmLjiqEh+J2DjnEtNObmmA0w=qMQYTgBsb6Ntad7Pw@mail.gmail.com>
     [not found]       ` <744357E9AAD1214791ACBA4B0B90926329F98E@SHSMSX101.ccr.corp.intel.com>
     [not found]         ` <CACWwPit=xxeeCW1+jfxE8eww+P545B5xebh3YT2yE78zcsqSMg@mail.gmail.com>
2013-02-18 20:33           ` Alexander Lam
2013-02-19 14:53           ` Zhang Rui
2013-02-19 15:35 ` Zhang Rui
2013-02-22  5:33   ` Peter Feuerer
2013-02-22 11:15     ` Borislav Petkov
2013-02-23 19:20       ` [PATCH] acerhdf: Fix fan activation with new thermal governor Borislav Petkov
2013-02-24 11:28         ` Borislav Petkov
2013-02-24 11:42           ` Peter Feuerer
2013-02-24 12:09             ` Borislav Petkov
2013-02-24 12:59               ` Borislav Petkov
2013-02-25  3:06               ` Zhang Rui
2013-02-25 10:20                 ` Borislav Petkov
2013-02-25 10:36                   ` Peter Feuerer
2013-02-24 14:34             ` Borislav Petkov
2013-02-25  3:21               ` Zhang Rui
2013-02-25 10:25                 ` Borislav Petkov
2013-02-25 12:16                   ` Borislav Petkov
2013-03-04 13:34                     ` Borislav Petkov
2013-03-04 19:25                       ` Andreas Mohr
2013-03-05 21:59                       ` Andreas Mohr
2013-03-06  3:47                         ` Zhang Rui
2013-03-06  7:00                           ` Borislav Petkov
2013-03-06  7:30                             ` Zhang Rui
2013-03-06  7:36                               ` Borislav Petkov
2013-03-07 20:17                       ` Peter Feuerer
2013-03-07 20:27                         ` Borislav Petkov
2013-02-25  3:01             ` Zhang Rui [this message]
2013-02-25  2:58           ` Zhang Rui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1361761314.2303.9.camel@rzhang1-mobl4 \
    --to=rui.zhang@intel.com \
    --cc=andi@lisas.de \
    --cc=azl@andrew.cmu.edu \
    --cc=bp@alien8.de \
    --cc=bp@suse.de \
    --cc=durgadoss.r@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter@piie.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).