From: Zhang Rui <rui.zhang@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Peter Feuerer <peter@piie.net>,
LKML <linux-kernel@vger.kernel.org>,
Durgadoss R <durgadoss.r@intel.com>, Andreas Mohr <andi@lisas.de>,
Alexander Lam <azl@andrew.cmu.edu>,
bp@suse.de
Subject: Re: [PATCH] acerhdf: Fix fan activation with new thermal governor
Date: Mon, 25 Feb 2013 11:21:54 +0800 [thread overview]
Message-ID: <1361762514.2303.21.camel@rzhang1-mobl4> (raw)
In-Reply-To: <20130224143452.GE19609@pd.tnic>
On Sun, 2013-02-24 at 15:34 +0100, Borislav Petkov wrote:
> On Sun, Feb 24, 2013 at 12:42:55PM +0100, Peter Feuerer wrote:
> > Please test my last patch with the 4 trip points ;) - even if you
> > don't really like it, it is working great! - And to be honest, I still
> > prefer this solution!
>
> Ok, I remember everything now - had to add some debug output to see what
> the stepwise governor hands us down.
>
> Btw, Zhang, is there any way we can tell the upper layer to not
> poll trips and temps for this driver? I mean, ->get_trip_type and
> ->get_trip_temp get called every polling interval and the data it
> receives back each time is static and don't change so polling the same
> values each time for this driver doesn't make any sense.
>
the reason we keep on calling it because the thermal zone trip point
info may be changed at runtime.
> Can we pass trip points and temperature levels upon registration time
> instead?
>
no, but we can cache it in the thermal layer, and do update when
necessary.
> @Peter: I took your patch, removed one trip point and added comments so
> that we don't forget why we do what we do. Please take a look - it works
> fine here.
>
> --
> From 1827ed71ff1b73a83d81d21f9dd167fe8e0d4198 Mon Sep 17 00:00:00 2001
> From: Peter Feuerer <peter@piie.net>
> Date: Sun, 24 Feb 2013 15:04:17 +0100
> Subject: [PATCH] acerhdf: Fix fan activation with new thermal governor
>
> After recent thermal subsys rework, acerhdf couldn't cope with the
> stepwise governor since it had only one trip point and this didn't fit
> into the stepwise scheme.
why? I do not think the stepwise scheme will break it. If it happens, we
should fix stepwise governor instead.
> Therefore, add two more trip points - an
> active one where we turn on the fan, and a critical one.
>
I think you add a passive trip point and a critical one here.
> However, we still need to flatten out peaks of turning the fan on
> and off in acerhdf_set_cur_state because stepwise looks also at the
> direction the temperature is going and applies respective policy. This
> results in short bursts of interchanging on and off which are really
> annoying.
>
> So, we keep the old logic where we turn on the fan only if we exceed
> 'fanon' temperature and leave it on until we go under 'fanoff'. Document
> this behavior while at it.
>
has anybody checked if the patch at lkml.org/lkml/2012/12/30/47 fixes
the problem, without any other patch?
thanks,
rui
> Signed-off-by: Peter Feuerer <peter@piie.net>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> ---
> drivers/platform/x86/acerhdf.c | 30 ++++++++++++++++++++++++++----
> 1 file changed, 26 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
> index f94467c05225..b06cdb099e6a 100644
> --- a/drivers/platform/x86/acerhdf.c
> +++ b/drivers/platform/x86/acerhdf.c
> @@ -400,7 +400,13 @@ static int acerhdf_get_trip_type(struct thermal_zone_device *thermal, int trip,
> enum thermal_trip_type *type)
> {
> if (trip == 0)
> + *type = THERMAL_TRIP_PASSIVE;
> + else if (trip == 1)
> *type = THERMAL_TRIP_ACTIVE;
> + else if (trip == 2)
> + *type = THERMAL_TRIP_CRITICAL;
> + else
> + WARN_ONCE(1, "%s: Funny trip point %d\n", KBUILD_MODNAME, trip);
>
> return 0;
> }
> @@ -409,7 +415,13 @@ static int acerhdf_get_trip_temp(struct thermal_zone_device *thermal, int trip,
> unsigned long *temp)
> {
> if (trip == 0)
> + *temp = 0;
> + else if (trip == 1)
> *temp = fanon;
> + else if (trip == 2)
> + *temp = ACERHDF_TEMP_CRIT;
> + else
> + WARN_ONCE(1, "%s: Funny trip point %d\n", KBUILD_MODNAME, trip);
>
> return 0;
> }
> @@ -459,7 +471,9 @@ static int acerhdf_get_cur_state(struct thermal_cooling_device *cdev,
> return 0;
> }
>
> -/* change current fan state - is overwritten when running in kernel mode */
> +/*
> + * Change current fan state - is overwritten when running in kernel mode
> + */
> static int acerhdf_set_cur_state(struct thermal_cooling_device *cdev,
> unsigned long state)
> {
> @@ -480,15 +494,23 @@ static int acerhdf_set_cur_state(struct thermal_cooling_device *cdev,
> goto err_out;
> }
>
> + /*
> + * We need to flatten out the on-off peaks we get from the stepwise
> + * governor into the wider span between fanoff and fanon because
> + * otherwise we turn on/off the fan in short bursts, everytime the
> + * thermal zone decides to throttle and this is annoying.
> + */
> if (state == 0) {
> /* turn fan off only if below fanoff temperature */
> if ((cur_state == ACERHDF_FAN_AUTO) &&
> - (cur_temp < fanoff))
> + (cur_temp <= fanoff))
> acerhdf_change_fanstate(ACERHDF_FAN_OFF);
> } else {
> - if (cur_state == ACERHDF_FAN_OFF)
> + if ((cur_state == ACERHDF_FAN_OFF) &&
> + (cur_temp >= fanon))
> acerhdf_change_fanstate(ACERHDF_FAN_AUTO);
> }
> +
> return 0;
>
> err_out:
> @@ -661,7 +683,7 @@ static int acerhdf_register_thermal(void)
> if (IS_ERR(cl_dev))
> return -EINVAL;
>
> - thz_dev = thermal_zone_device_register("acerhdf", 1, 0, NULL,
> + thz_dev = thermal_zone_device_register("acerhdf", 3, 0, NULL,
> &acerhdf_dev_ops, NULL, 0,
> (kernelmode) ? interval*1000 : 0);
> if (IS_ERR(thz_dev))
> --
> 1.8.1.3.535.ga923c31
>
>
next prev parent reply other threads:[~2013-02-25 3:22 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 15:32 thermal governor: does it actually work?? Andreas Mohr
2013-02-15 9:47 ` Zhang, Rui
2013-02-15 15:49 ` Andreas Mohr
2013-02-16 21:08 ` Alexander Lam
2013-02-16 21:47 ` Borislav Petkov
2013-02-17 2:43 ` Peter Feuerer
2013-02-17 14:09 ` Borislav Petkov
2013-02-17 15:41 ` Peter Feuerer
2013-02-18 13:50 ` Borislav Petkov
2013-02-18 16:47 ` Peter Feuerer
2013-02-19 14:51 ` Zhang Rui
2013-02-19 15:05 ` Borislav Petkov
2013-02-19 15:27 ` Zhang Rui
[not found] ` <CACWwPisqpmLjiqEh+J2DjnEtNObmmA0w=qMQYTgBsb6Ntad7Pw@mail.gmail.com>
[not found] ` <744357E9AAD1214791ACBA4B0B90926329F98E@SHSMSX101.ccr.corp.intel.com>
[not found] ` <CACWwPit=xxeeCW1+jfxE8eww+P545B5xebh3YT2yE78zcsqSMg@mail.gmail.com>
2013-02-18 20:33 ` Alexander Lam
2013-02-19 14:53 ` Zhang Rui
2013-02-19 15:35 ` Zhang Rui
2013-02-22 5:33 ` Peter Feuerer
2013-02-22 11:15 ` Borislav Petkov
2013-02-23 19:20 ` [PATCH] acerhdf: Fix fan activation with new thermal governor Borislav Petkov
2013-02-24 11:28 ` Borislav Petkov
2013-02-24 11:42 ` Peter Feuerer
2013-02-24 12:09 ` Borislav Petkov
2013-02-24 12:59 ` Borislav Petkov
2013-02-25 3:06 ` Zhang Rui
2013-02-25 10:20 ` Borislav Petkov
2013-02-25 10:36 ` Peter Feuerer
2013-02-24 14:34 ` Borislav Petkov
2013-02-25 3:21 ` Zhang Rui [this message]
2013-02-25 10:25 ` Borislav Petkov
2013-02-25 12:16 ` Borislav Petkov
2013-03-04 13:34 ` Borislav Petkov
2013-03-04 19:25 ` Andreas Mohr
2013-03-05 21:59 ` Andreas Mohr
2013-03-06 3:47 ` Zhang Rui
2013-03-06 7:00 ` Borislav Petkov
2013-03-06 7:30 ` Zhang Rui
2013-03-06 7:36 ` Borislav Petkov
2013-03-07 20:17 ` Peter Feuerer
2013-03-07 20:27 ` Borislav Petkov
2013-02-25 3:01 ` Zhang Rui
2013-02-25 2:58 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361762514.2303.21.camel@rzhang1-mobl4 \
--to=rui.zhang@intel.com \
--cc=andi@lisas.de \
--cc=azl@andrew.cmu.edu \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=durgadoss.r@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@piie.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).