linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
To: <linville@tuxdriver.com>
Cc: will.deacon@arm.com, pali.rohar@gmail.com, pavel@ucw.cz,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Subject: [PATCH] wl1251: use skb_trim to make skb shorter
Date: Sat,  1 Mar 2014 14:52:06 +0200	[thread overview]
Message-ID: <1393678326-23535-1-git-send-email-ivo.g.dimitrov.75@gmail.com> (raw)
In-Reply-To: <20140225105756.GB22279@mudshark.cambridge.arm.com>

the current code is directly setting skb->len, which is not correct and
brings problems with HAVE_EFFICIENT_UNALIGNED_ACCESS enabled in config

Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
---
 drivers/net/wireless/ti/wl1251/rx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ti/wl1251/rx.c b/drivers/net/wireless/ti/wl1251/rx.c
index 123c4bb..cde0eaf 100644
--- a/drivers/net/wireless/ti/wl1251/rx.c
+++ b/drivers/net/wireless/ti/wl1251/rx.c
@@ -180,7 +180,7 @@ static void wl1251_rx_body(struct wl1251 *wl,
 	wl1251_mem_read(wl, rx_packet_ring_addr, rx_buffer, length);
 
 	/* The actual length doesn't include the target's alignment */
-	skb->len = desc->length  - PLCP_HEADER_LENGTH;
+	skb_trim(skb, desc->length - PLCP_HEADER_LENGTH);
 
 	fc = (u16 *)skb->data;
 
-- 
1.7.9.5


  reply	other threads:[~2014-03-01 12:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13 18:02 [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624 Ivaylo Dimitrov
2014-02-13 18:21 ` Will Deacon
2014-02-13 18:43   ` Ivaylo Dimitrov
2014-02-13 19:29     ` Will Deacon
2014-02-14 16:12       ` Ivaylo Dimitrov
2014-02-14 16:24         ` Will Deacon
2014-02-14 17:11           ` Ivaylo Dimitrov
2014-02-23 19:06             ` Ivaylo Dimitrov
2014-02-25 10:44               ` Pavel Machek
2014-02-25 10:55                 ` Will Deacon
2014-02-24 16:52           ` Kalle Valo
2014-02-25  7:56           ` Ivaylo Dimitrov
2014-02-25 10:57             ` Will Deacon
2014-03-01 12:52               ` Ivaylo Dimitrov [this message]
2014-03-04 14:26                 ` [PATCH] wl1251: use skb_trim to make skb shorter Will Deacon
2014-03-04 18:33                   ` John W. Linville
2014-03-05 10:06                     ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393678326-23535-1-git-send-email-ivo.g.dimitrov.75@gmail.com \
    --to=ivo.g.dimitrov.75@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=pali.rohar@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).