From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Will Deacon <will.deacon@arm.com>
Cc: "Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Pavel Machek" <pavel@ucw.cz>, "Sebastian Reichel" <sre@ring0.de>,
"Pali Rohár" <pali.rohar@gmail.com>,
linville@tuxdriver.com
Subject: Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624
Date: Mon, 24 Feb 2014 18:52:53 +0200 [thread overview]
Message-ID: <877g8ktpui.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20140214162458.GF21986@mudshark.cambridge.arm.com> (Will Deacon's message of "Fri, 14 Feb 2014 16:24:58 +0000")
Will Deacon <will.deacon@arm.com> writes:
> Well, we probably need a bit more to go on, because I doubt that this code
> is to blame. More likely, the issue is in the caller.
> Looking at drivers/net/wireless/ti/wl1251/rx.c:182
>
> /* The actual length doesn't include the target's alignment */
> skb->len = desc->length - PLCP_HEADER_LENGTH;
>
> fc = (u16 *)skb->data;
>
> if ((*fc & IEEE80211_FCTL_STYPE) == IEEE80211_STYPE_BEACON)
> beacon = 1;
>
> wl1251_rx_status(wl, desc, &status, beacon);
>
> wl1251_debug(DEBUG_RX, "rx skb 0x%p: %d B %s", skb, skb->len,
> beacon ? "beacon" : "");
>
> memcpy(IEEE80211_SKB_RXCB(skb), &status, sizeof(status));
> ieee80211_rx_ni(wl->hw, skb);
>
> I wonder whether that first line (with the comment about alignment) is
> assuming some behaviour from the mac80211 layer.
>
> You could try putting back the UNALIGNED_ACCESS in net/mac80211/rx.c and
> commenting out the skb->len = desc->length - PLCP_HEADER_LENGTH; line
> above.
>
> Adding the original author (I think) and John Linville, since I'm well out
> of my depth in this code!
I haven't touched wl1251 for years. You should send questions to
linux-wireless list and CC people who have worked on it recently.
--
Kalle Valo
next prev parent reply other threads:[~2014-02-24 16:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 18:02 [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624 Ivaylo Dimitrov
2014-02-13 18:21 ` Will Deacon
2014-02-13 18:43 ` Ivaylo Dimitrov
2014-02-13 19:29 ` Will Deacon
2014-02-14 16:12 ` Ivaylo Dimitrov
2014-02-14 16:24 ` Will Deacon
2014-02-14 17:11 ` Ivaylo Dimitrov
2014-02-23 19:06 ` Ivaylo Dimitrov
2014-02-25 10:44 ` Pavel Machek
2014-02-25 10:55 ` Will Deacon
2014-02-24 16:52 ` Kalle Valo [this message]
2014-02-25 7:56 ` Ivaylo Dimitrov
2014-02-25 10:57 ` Will Deacon
2014-03-01 12:52 ` [PATCH] wl1251: use skb_trim to make skb shorter Ivaylo Dimitrov
2014-03-04 14:26 ` Will Deacon
2014-03-04 18:33 ` John W. Linville
2014-03-05 10:06 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877g8ktpui.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linville@tuxdriver.com \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=sre@ring0.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).