linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
To: Will Deacon <will.deacon@arm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"Pavel Machek" <pavel@ucw.cz>, "Sebastian Reichel" <sre@ring0.de>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	kvalo@qca.qualcomm.com, linville@tuxdriver.com
Subject: Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624
Date: Tue, 25 Feb 2014 09:56:11 +0200	[thread overview]
Message-ID: <530C4C9B.7050104@gmail.com> (raw)
In-Reply-To: <20140214162458.GF21986@mudshark.cambridge.arm.com>

Hi,

On 14.02.2014 18:24, Will Deacon wrote:
> You could try putting back the UNALIGNED_ACCESS in net/mac80211/rx.c and
> commenting out the skb->len = desc->length  - PLCP_HEADER_LENGTH;  line
> above.
>

the following patch

diff --git a/drivers/net/wireless/ti/wl1251/rx.c 
b/drivers/net/wireless/ti/wl1251/rx.c
index 123c4bb..cde0eaf 100644
--- a/drivers/net/wireless/ti/wl1251/rx.c
+++ b/drivers/net/wireless/ti/wl1251/rx.c
@@ -180,7 +180,7 @@ static void wl1251_rx_body(struct wl1251 *wl,
         wl1251_mem_read(wl, rx_packet_ring_addr, rx_buffer, length);

         /* The actual length doesn't include the target's alignment */
-       skb->len = desc->length  - PLCP_HEADER_LENGTH;
+       skb_trim(skb, desc->length - PLCP_HEADER_LENGTH);

         fc = (u16 *)skb->data;

seems to fix the issue, including those "corrupt probe response" 
messages in dmesg log (I took that 'skb_trim' from the original Nokia 
kernel). Will send a properly formatted patch shortly.

Thanks,
Ivo

  parent reply	other threads:[~2014-02-25  7:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13 18:02 [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624 Ivaylo Dimitrov
2014-02-13 18:21 ` Will Deacon
2014-02-13 18:43   ` Ivaylo Dimitrov
2014-02-13 19:29     ` Will Deacon
2014-02-14 16:12       ` Ivaylo Dimitrov
2014-02-14 16:24         ` Will Deacon
2014-02-14 17:11           ` Ivaylo Dimitrov
2014-02-23 19:06             ` Ivaylo Dimitrov
2014-02-25 10:44               ` Pavel Machek
2014-02-25 10:55                 ` Will Deacon
2014-02-24 16:52           ` Kalle Valo
2014-02-25  7:56           ` Ivaylo Dimitrov [this message]
2014-02-25 10:57             ` Will Deacon
2014-03-01 12:52               ` [PATCH] wl1251: use skb_trim to make skb shorter Ivaylo Dimitrov
2014-03-04 14:26                 ` Will Deacon
2014-03-04 18:33                   ` John W. Linville
2014-03-05 10:06                     ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=530C4C9B.7050104@gmail.com \
    --to=ivo.g.dimitrov.75@gmail.com \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=linville@tuxdriver.com \
    --cc=pali.rohar@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=sre@ring0.de \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).