From: Will Deacon <will.deacon@arm.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Sebastian Reichel" <sre@ring0.de>,
"Pali Rohár" <pali.rohar@gmail.com>,
"kvalo@qca.qualcomm.com" <kvalo@qca.qualcomm.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>
Subject: Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624
Date: Tue, 25 Feb 2014 10:55:53 +0000 [thread overview]
Message-ID: <20140225105552.GA22279@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <20140225104444.GA5563@amd.pavel.ucw.cz>
On Tue, Feb 25, 2014 at 10:44:44AM +0000, Pavel Machek wrote:
> > >>You could try putting back the UNALIGNED_ACCESS in net/mac80211/rx.c and
> > >>commenting out the skb->len = desc->length - PLCP_HEADER_LENGTH; line
> > >>above.
> > >
> > >This seems to fix the issue too, but I am afraid there is more to be
> > >done, as I see
> > >
> > >Feb 14 18:33:46 Nokia-N900 kernel: [ 88.599853] wlan0: authenticate
> > >with 00:23:cd:17:86:d0
> > >Feb 14 18:33:46 Nokia-N900 kernel: [ 88.781860] wlan0: send auth to
> > >00:23:cd:17:86:d0 (try 1/3)
> > >Feb 14 18:33:46 Nokia-N900 kernel: [ 88.799804] wlan0: authenticated
> > >Feb 14 18:33:46 Nokia-N900 kernel: [ 88.806243] wlan0: associating
> > >with AP with corrupt probe response
> > >Feb 14 18:33:46 Nokia-N900 kernel: [ 88.814544] wlan0: associate with
> > >00:23:cd:17:86:d0 (try 1/3)
> > >Feb 14 18:33:46 Nokia-N900 kernel: [ 88.826416] wlan0: RX AssocResp
> > >from 00:23:cd:17:86:d0 (capab=0x431 status=0 aid=2)
> > >
> > >spit in dmesg log. AFAIR this is the first time I see "associating with
> > >AP with corrupt probe response" in dmesg, no matter of the kernel
> > >version. Despite of that error message, wlan seems to work as it should,
> > >so far. I guess we need the driver's author saying on the issue.
> >
> > ping?
>
> If Will does not respond, we should simply revert
> dce5c9e35bc4085bd33eccdb8c9ec5a643507a14 . Regressions are not
> acceptable.
Seriously Pavel, give me a break. I already responded pretty quickly to this
bug report, took a look at where the issue could be and proposed a fix
(which Ivaylo tested successfully). Now, wireless drivers are *waay* outside
my area of expertise, so I added some other folks to CC in the hope that
they could help turn my fix into something upstreamable. Meanwhile, Ivaylo
looks like he has something better than what I came up with already.
If you care about this driver, why don't you help us fix it rather than
making unhelpful suggestions from the sidelines?
Will
next prev parent reply other threads:[~2014-02-25 10:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 18:02 [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624 Ivaylo Dimitrov
2014-02-13 18:21 ` Will Deacon
2014-02-13 18:43 ` Ivaylo Dimitrov
2014-02-13 19:29 ` Will Deacon
2014-02-14 16:12 ` Ivaylo Dimitrov
2014-02-14 16:24 ` Will Deacon
2014-02-14 17:11 ` Ivaylo Dimitrov
2014-02-23 19:06 ` Ivaylo Dimitrov
2014-02-25 10:44 ` Pavel Machek
2014-02-25 10:55 ` Will Deacon [this message]
2014-02-24 16:52 ` Kalle Valo
2014-02-25 7:56 ` Ivaylo Dimitrov
2014-02-25 10:57 ` Will Deacon
2014-03-01 12:52 ` [PATCH] wl1251: use skb_trim to make skb shorter Ivaylo Dimitrov
2014-03-04 14:26 ` Will Deacon
2014-03-04 18:33 ` John W. Linville
2014-03-05 10:06 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225105552.GA22279@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linville@tuxdriver.com \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=sre@ring0.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).