linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Holler <holler@ahsoftware.de>
To: linux-kernel@vger.kernel.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Russell King <linux@arm.linux.org.uk>, Jon Loeliger <jdl@jdl.com>,
	Grant Likely <grant.likely@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Alexander Holler <holler@ahsoftware.de>
Subject: [RFC PATCH 11/9] dt: deps: dtc: introduce new (virtual) property no-dependencies
Date: Tue, 13 May 2014 21:27:17 +0200	[thread overview]
Message-ID: <1400009237-5012-1-git-send-email-holler@ahsoftware.de> (raw)
In-Reply-To: <1399913280-6915-1-git-send-email-holler@ahsoftware.de>

In some rare cases it might make sense for not wanting an automatic
dependency for some used phandles.

E.g. if a cpu depends on a regulator which depends on i2c which depends
on some bus and you want that the bus depends on the cpu. That would
end up in a cycle. Usually such doesn't make sense because the hw doesn't
support such circular dependencies too (you always have to start somewhere
with initializing things). But e.g. in the case of the regulator the cpu
depends on, it's very likely that the regulator was initialized
automatically (otherwise the cpu won't run), so there is no real need to
initialize the regulator before the cpu. But that's just an example for
one of such rare cases where it might make sense to avoid an otherwise
automatically added dependency.

The syntax is like

	bar: whatever {
		...
	};
	foo {
		my-option = <&bar 1 2 3>;
		no-dependencies = <&bar>;
	};

Without that 'no-dependencies' property dtc would automatically add a
dependency to bar to the property 'dependencies' of the node foo.
But with that 'no-dependencies' it will not automatically add the
listed dependencies.

The property 'no-dependencies' is virtual property and will not be added
to any output file.

Signed-off-by: Alexander Holler <holler@ahsoftware.de>
---
 scripts/dtc/dependencies.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/scripts/dtc/dependencies.c b/scripts/dtc/dependencies.c
index 4579f6f..06f447b 100644
--- a/scripts/dtc/dependencies.c
+++ b/scripts/dtc/dependencies.c
@@ -73,6 +73,16 @@ static void add_deps(struct node *dt, struct node *node, struct property *prop)
 				is_parent_of(target, source))
 			continue;
 		phandle = get_node_phandle(dt, target);
+		prop_deps = get_property(node, "no-dependencies");
+		if (prop_deps) {
+			/* avoid adding non-dependencies */
+			cell = (cell_t *)prop_deps->val.val;
+			for (i = 0; i < prop_deps->val.len/4; ++i)
+				if (*cell++ == cpu_to_fdt32(phandle))
+					break;
+			if (i < prop_deps->val.len/4)
+				continue;
+		}
 		prop_deps = get_property(source, "dependencies");
 		if (!prop_deps) {
 			add_property(source,
@@ -102,9 +112,21 @@ static void process_nodes_props(struct node *dt, struct node *node)
 		process_nodes_props(dt, child);
 }
 
+static void del_prop_no_dependencies(struct node *node)
+{
+	struct node *child;
+
+	if (!node)
+		return;
+	delete_property_by_name(node, "no-dependencies");
+	for_each_child(node, child)
+		del_prop_no_dependencies(child);
+}
+
 void add_dependencies(struct boot_info *bi)
 {
 	process_nodes_props(bi->dt, bi->dt);
+	del_prop_no_dependencies(bi->dt);
 }
 
 /*
-- 
1.8.3.1


  parent reply	other threads:[~2014-05-13 19:45 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-12 16:47 [RFC PATCH 0/9] dt: dependencies (for deterministic driver initialization order based on the DT) Alexander Holler
2014-05-12 16:47 ` [RFC PATCH 1/9] dt: deps: dtc: Automatically add new property 'dependencies' which contains a list of referenced phandles Alexander Holler
2014-05-17 12:16   ` Tomasz Figa
2014-05-19 12:35     ` Alexander Holler
     [not found]       ` <CAJgR-BhRtc1XGqk-TVOrf2y_pYS+nratkPrf+OenP4SFcyK3ng@mail.gmail.com>
2014-05-19 17:26         ` Alexander Holler
2014-05-27 20:02       ` Grant Likely
2014-05-27 20:31         ` Alexander Holler
2014-05-12 16:47 ` [RFC PATCH 2/9] dt: deps: dependency based device creation Alexander Holler
2014-05-14 14:05   ` Grant Likely
2014-05-14 14:49     ` Alexander Holler
2014-05-14 17:20       ` Alexander Holler
2014-05-14 20:06       ` Grant Likely
2014-05-14 21:10         ` Alexander Holler
2014-05-16 11:00           ` Grant Likely
2014-05-18  9:53             ` Alexander Holler
2014-05-16 17:31           ` Alexander Shiyan
2014-05-14 15:51     ` Alexander Holler
2014-05-17 14:24     ` Tomasz Figa
2014-05-18 14:59       ` Grant Likely
2014-05-19  8:41         ` Alexander Holler
2014-05-12 16:47 ` [RFC PATCH 3/9] dt: deps: dtc: Add option to print initialization order Alexander Holler
     [not found]   ` <CAJgR-BhnFngGr9qxa7NvF7GExiCAr1=HS16AtN20uj7nCmLcKQ@mail.gmail.com>
2014-05-12 22:58     ` Alexander Holler
2014-05-12 16:47 ` [RFC PATCH 4/9] dt: deps: dtc: Add option to print dependency graph as dot (Graphviz) Alexander Holler
2014-05-12 16:47 ` [RFC PATCH 5/9] dt: deps: register drivers based on the initialization order based on DT Alexander Holler
2014-05-14 14:13   ` Grant Likely
2014-05-14 14:58     ` Alexander Holler
2014-05-14 19:32       ` Grant Likely
2014-05-12 16:47 ` [RFC PATCH 6/9] dt: deps: WIP: well done drivers Alexander Holler
2014-05-12 16:47 ` [RFC PATCH 7/9] dt: deps: kirkwood: make it possible to use CONFIG_OF_DEPENDENCIES Alexander Holler
2014-05-12 16:47 ` [RFC PATCH 8/9] dt: deps: dts: kirkwood: dockstar: add dependency ehci -> usb power regulator Alexander Holler
2014-05-12 16:48 ` [RFC PATCH 9/9] dt: deps: omap2: make it possible to use CONFIG_OF_DEPENDENCIES Alexander Holler
2014-05-13 15:40 ` [PATCH 10/9] dt: deps: fix bug not registering late drivers when OF_DEPENDENCIES is disabled Alexander Holler
2014-05-13 19:27 ` Alexander Holler [this message]
2014-05-14  8:20 ` dt: deps: some tips about how to debug/evaluate this feature Alexander Holler
2014-05-14 14:19 ` [RFC PATCH 0/9] dt: dependencies (for deterministic driver initialization order based on the DT) Grant Likely
2014-05-14 15:02   ` Alexander Holler
2014-05-14 16:05     ` Grant Likely
2014-05-14 16:23       ` Alexander Holler
2014-05-14 17:30         ` Rob Herring
2014-05-14 17:45           ` Alexander Holler
2014-05-14 17:53             ` Alexander Holler
2014-05-14 18:16               ` Alexander Holler
2014-05-14 19:13                 ` Alexander Holler
2014-05-14 19:06             ` Rob Herring
2014-05-14 19:24               ` Alexander Holler
2014-05-15  1:46                 ` Alexander Holler
2014-05-14 23:00               ` Alexander Holler
2014-08-21 14:02   ` Thierry Reding
2014-08-21 19:19     ` Alexander Holler
2014-08-22 13:19       ` Mark Rutland
2014-08-22 15:45         ` Alexander Holler
2014-08-25  9:39         ` Thierry Reding
2014-08-25 13:08           ` Jon Loeliger
2014-08-25 13:37             ` Thierry Reding
2014-08-25 14:13               ` Jon Loeliger
2014-08-25 14:41                 ` Thierry Reding
2014-08-26  8:42               ` Grant Likely
2014-08-26  8:49                 ` Thierry Reding
2014-08-26  9:42                   ` Alexander Holler
2014-08-26 10:11                     ` Mark Rutland
2014-08-26 10:24                       ` Thierry Reding
2014-08-27 10:34                       ` Grant Likely
2014-08-27 14:44                         ` Catalin Marinas
2014-08-27 16:22                           ` Stephen Warren
2014-08-27 16:30                             ` Alexander Holler
2014-08-27 16:37                               ` Stephen Warren
2014-08-27 16:58                                 ` Alexander Holler
2014-08-27 17:52                                 ` Catalin Marinas
2014-08-27 18:14                                   ` Alexander Holler
2014-08-28  6:50                                 ` Alexander Holler
2014-08-28  9:23                                   ` Catalin Marinas
2014-08-29  1:43                                     ` Alexander Holler
2014-08-26 10:25                     ` Thierry Reding
2014-08-26 10:44                       ` Alexander Holler
2014-08-26 11:01                         ` Alexander Holler
2014-08-26 11:08                         ` Thierry Reding
2014-08-26 11:23                           ` Alexander Holler
2014-08-26 11:47                             ` Thierry Reding
2014-08-26 12:00                               ` Alexander Holler
2014-08-26 13:58                                 ` Jon Loeliger
2014-08-26 14:17                                   ` Thierry Reding
2014-08-27  7:16                                   ` Alexander Holler
2014-08-27  9:26                                     ` Alexander Holler
2014-08-26  7:56             ` Alexander Holler
2014-08-26  8:51             ` Grant Likely
2014-08-26  9:56               ` Alexander Holler
2014-08-26 10:18               ` Alexander Holler
2014-08-26  9:54           ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400009237-5012-1-git-send-email-holler@ahsoftware.de \
    --to=holler@ahsoftware.de \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jdl@jdl.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).