* [PATCH] platform/chrome: cros_ec_dev - Populate compat_ioctl
@ 2016-04-15 2:35 Guenter Roeck
2016-04-20 21:45 ` Brian Norris
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2016-04-15 2:35 UTC (permalink / raw)
To: Olof Johansson; +Cc: dianders, gwendal, linux-kernel, Guenter Roeck
compat_ioctl has to be populated for 32 bit userspace applications to work
with 64 bit kernels.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/platform/chrome/cros_ec_dev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/platform/chrome/cros_ec_dev.c b/drivers/platform/chrome/cros_ec_dev.c
index 6c45e0f5ba7b..903b1d8dcab7 100644
--- a/drivers/platform/chrome/cros_ec_dev.c
+++ b/drivers/platform/chrome/cros_ec_dev.c
@@ -208,6 +208,9 @@ static const struct file_operations fops = {
.release = ec_device_release,
.read = ec_device_read,
.unlocked_ioctl = ec_device_ioctl,
+#ifdef CONFIG_COMPAT
+ .compat_ioctl = ec_device_ioctl,
+#endif
};
static void __remove(struct device *dev)
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: platform/chrome: cros_ec_dev - Populate compat_ioctl
2016-04-15 2:35 [PATCH] platform/chrome: cros_ec_dev - Populate compat_ioctl Guenter Roeck
@ 2016-04-20 21:45 ` Brian Norris
2016-05-11 18:33 ` Olof Johansson
0 siblings, 1 reply; 3+ messages in thread
From: Brian Norris @ 2016-04-20 21:45 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Olof Johansson, dianders, gwendal, linux-kernel
On Thu, Apr 14, 2016 at 07:35:29PM -0700, Guenter Roeck wrote:
> compat_ioctl has to be populated for 32 bit userspace applications to work
> with 64 bit kernels.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Tested with 32-bit user space on ARM64:
Tested-by: Brian Norris <briannorris@chromium.org>
> ---
> drivers/platform/chrome/cros_ec_dev.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/platform/chrome/cros_ec_dev.c b/drivers/platform/chrome/cros_ec_dev.c
> index 6c45e0f5ba7b..903b1d8dcab7 100644
> --- a/drivers/platform/chrome/cros_ec_dev.c
> +++ b/drivers/platform/chrome/cros_ec_dev.c
> @@ -208,6 +208,9 @@ static const struct file_operations fops = {
> .release = ec_device_release,
> .read = ec_device_read,
> .unlocked_ioctl = ec_device_ioctl,
> +#ifdef CONFIG_COMPAT
> + .compat_ioctl = ec_device_ioctl,
> +#endif
> };
>
> static void __remove(struct device *dev)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: platform/chrome: cros_ec_dev - Populate compat_ioctl
2016-04-20 21:45 ` Brian Norris
@ 2016-05-11 18:33 ` Olof Johansson
0 siblings, 0 replies; 3+ messages in thread
From: Olof Johansson @ 2016-05-11 18:33 UTC (permalink / raw)
To: Brian Norris; +Cc: Guenter Roeck, dianders, gwendal, linux-kernel
On Wed, Apr 20, 2016 at 02:45:13PM -0700, Brian Norris wrote:
> On Thu, Apr 14, 2016 at 07:35:29PM -0700, Guenter Roeck wrote:
> > compat_ioctl has to be populated for 32 bit userspace applications to work
> > with 64 bit kernels.
> >
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> Tested with 32-bit user space on ARM64:
>
> Tested-by: Brian Norris <briannorris@chromium.org>
Applied, thanks.
-Olof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-11 19:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-15 2:35 [PATCH] platform/chrome: cros_ec_dev - Populate compat_ioctl Guenter Roeck
2016-04-20 21:45 ` Brian Norris
2016-05-11 18:33 ` Olof Johansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).