[PATCH] platform/chrome: cros_ec_dev - Populate compat_ioctl

[PATCH] platform/chrome: cros_ec_dev - Populate compat_ioctl

[Guenter Roeck]

compat_ioctl has to be populated for 32 bit userspace applications to work
with 64 bit kernels.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/platform/chrome/cros_ec_dev.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/platform/chrome/cros_ec_dev.c b/drivers/platform/chrome/cros_ec_dev.c
index 6c45e0f5ba7b..903b1d8dcab7 100644
--- a/drivers/platform/chrome/cros_ec_dev.c
+++ b/drivers/platform/chrome/cros_ec_dev.c
@@ -208,6 +208,9 @@ static const struct file_operations fops = {
 	.release = ec_device_release,
 	.read = ec_device_read,
 	.unlocked_ioctl = ec_device_ioctl,
+#ifdef CONFIG_COMPAT
+	.compat_ioctl = ec_device_ioctl,
+#endif
 };
 
 static void __remove(struct device *dev)
-- 
2.5.0

Re: platform/chrome: cros_ec_dev - Populate compat_ioctl

[Brian Norris]

On Thu, Apr 14, 2016 at 07:35:29PM -0700, Guenter Roeck wrote:
> compat_ioctl has to be populated for 32 bit userspace applications to work
> with 64 bit kernels.
> 
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Tested with 32-bit user space on ARM64:

Tested-by: Brian Norris <briannorris@chromium.org>

> ---
> drivers/platform/chrome/cros_ec_dev.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/platform/chrome/cros_ec_dev.c b/drivers/platform/chrome/cros_ec_dev.c
> index 6c45e0f5ba7b..903b1d8dcab7 100644
> --- a/drivers/platform/chrome/cros_ec_dev.c
> +++ b/drivers/platform/chrome/cros_ec_dev.c
> @@ -208,6 +208,9 @@ static const struct file_operations fops = {
>  	.release = ec_device_release,
>  	.read = ec_device_read,
>  	.unlocked_ioctl = ec_device_ioctl,
> +#ifdef CONFIG_COMPAT
> +	.compat_ioctl = ec_device_ioctl,
> +#endif
>  };
>  
>  static void __remove(struct device *dev)

Re: platform/chrome: cros_ec_dev - Populate compat_ioctl

[Olof Johansson]

On Wed, Apr 20, 2016 at 02:45:13PM -0700, Brian Norris wrote:
> On Thu, Apr 14, 2016 at 07:35:29PM -0700, Guenter Roeck wrote:
> > compat_ioctl has to be populated for 32 bit userspace applications to work
> > with 64 bit kernels.
> > 
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> 
> Tested with 32-bit user space on ARM64:
> 
> Tested-by: Brian Norris <briannorris@chromium.org>

Applied, thanks.


-Olof