* [PATCH] tpm_vtpm_proxy: fix sparse warning
@ 2016-06-16 10:37 Jarkko Sakkinen
2016-06-16 13:39 ` Stefan Berger
0 siblings, 1 reply; 3+ messages in thread
From: Jarkko Sakkinen @ 2016-06-16 10:37 UTC (permalink / raw)
To: Peter Huewe
Cc: linux-security-module, Stefan Berger, Jarkko Sakkinen,
Marcel Selhorst, Jason Gunthorpe,
moderated list:TPM DEVICE DRIVER, open list
When running make C=2 M=drivers/char/tpm/
CC [M] drivers/char/tpm//tpm_crb.o
CHECK drivers/char/tpm//tpm_vtpm_proxy.c
drivers/char/tpm//tpm_vtpm_proxy.c:552:32: warning: incorrect type in assignment (different address spaces)
drivers/char/tpm//tpm_vtpm_proxy.c:552:32: expected struct vtpm_proxy_new_dev *vtpm_new_dev_p
drivers/char/tpm//tpm_vtpm_proxy.c:552:32: got void [noderef] <asn:1>*argp
drivers/char/tpm//tpm_vtpm_proxy.c:553:51: warning: incorrect type in argument 2 (different address spaces)
drivers/char/tpm//tpm_vtpm_proxy.c:553:51: expected void const [noderef] <asn:1>*from
drivers/char/tpm//tpm_vtpm_proxy.c:553:51: got struct vtpm_proxy_new_dev *vtpm_new_dev_p
drivers/char/tpm//tpm_vtpm_proxy.c:559:34: warning: incorrect type in argument 1 (different address spaces)
drivers/char/tpm//tpm_vtpm_proxy.c:559:34: expected void [noderef] <asn:1>*to
drivers/char/tpm//tpm_vtpm_proxy.c:559:34: got struct vtpm_proxy_new_dev *vtpm_new_dev_p
The __user annotation was missing from the corresponding variable.
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
---
drivers/char/tpm/tpm_vtpm_proxy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/tpm/tpm_vtpm_proxy.c b/drivers/char/tpm/tpm_vtpm_proxy.c
index 4384042..86e27e8 100644
--- a/drivers/char/tpm/tpm_vtpm_proxy.c
+++ b/drivers/char/tpm/tpm_vtpm_proxy.c
@@ -541,7 +541,7 @@ static long vtpmx_fops_ioctl(struct file *f, unsigned int ioctl,
unsigned long arg)
{
void __user *argp = (void __user *)arg;
- struct vtpm_proxy_new_dev *vtpm_new_dev_p;
+ struct vtpm_proxy_new_dev __user *vtpm_new_dev_p;
struct vtpm_proxy_new_dev vtpm_new_dev;
struct file *file;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tpm_vtpm_proxy: fix sparse warning
2016-06-16 10:37 [PATCH] tpm_vtpm_proxy: fix sparse warning Jarkko Sakkinen
@ 2016-06-16 13:39 ` Stefan Berger
2016-06-16 20:34 ` Jarkko Sakkinen
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Berger @ 2016-06-16 13:39 UTC (permalink / raw)
To: Jarkko Sakkinen, Peter Huewe
Cc: linux-security-module, Marcel Selhorst, Jason Gunthorpe,
moderated list:TPM DEVICE DRIVER, open list
On 06/16/2016 06:37 AM, Jarkko Sakkinen wrote:
> When running make C=2 M=drivers/char/tpm/
>
> CC [M] drivers/char/tpm//tpm_crb.o
> CHECK drivers/char/tpm//tpm_vtpm_proxy.c
> drivers/char/tpm//tpm_vtpm_proxy.c:552:32: warning: incorrect type in assignment (different address spaces)
> drivers/char/tpm//tpm_vtpm_proxy.c:552:32: expected struct vtpm_proxy_new_dev *vtpm_new_dev_p
> drivers/char/tpm//tpm_vtpm_proxy.c:552:32: got void [noderef] <asn:1>*argp
> drivers/char/tpm//tpm_vtpm_proxy.c:553:51: warning: incorrect type in argument 2 (different address spaces)
> drivers/char/tpm//tpm_vtpm_proxy.c:553:51: expected void const [noderef] <asn:1>*from
> drivers/char/tpm//tpm_vtpm_proxy.c:553:51: got struct vtpm_proxy_new_dev *vtpm_new_dev_p
> drivers/char/tpm//tpm_vtpm_proxy.c:559:34: warning: incorrect type in argument 1 (different address spaces)
> drivers/char/tpm//tpm_vtpm_proxy.c:559:34: expected void [noderef] <asn:1>*to
> drivers/char/tpm//tpm_vtpm_proxy.c:559:34: got struct vtpm_proxy_new_dev *vtpm_new_dev_p
>
> The __user annotation was missing from the corresponding variable.
>
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Tested-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
PS: I get similar warnings for line 248 in tpm_crb.c.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tpm_vtpm_proxy: fix sparse warning
2016-06-16 13:39 ` Stefan Berger
@ 2016-06-16 20:34 ` Jarkko Sakkinen
0 siblings, 0 replies; 3+ messages in thread
From: Jarkko Sakkinen @ 2016-06-16 20:34 UTC (permalink / raw)
To: Stefan Berger
Cc: Peter Huewe, linux-security-module, Marcel Selhorst,
Jason Gunthorpe, moderated list:TPM DEVICE DRIVER, open list
On Thu, Jun 16, 2016 at 09:39:38AM -0400, Stefan Berger wrote:
> On 06/16/2016 06:37 AM, Jarkko Sakkinen wrote:
> >When running make C=2 M=drivers/char/tpm/
> >
> > CC [M] drivers/char/tpm//tpm_crb.o
> > CHECK drivers/char/tpm//tpm_vtpm_proxy.c
> >drivers/char/tpm//tpm_vtpm_proxy.c:552:32: warning: incorrect type in assignment (different address spaces)
> >drivers/char/tpm//tpm_vtpm_proxy.c:552:32: expected struct vtpm_proxy_new_dev *vtpm_new_dev_p
> >drivers/char/tpm//tpm_vtpm_proxy.c:552:32: got void [noderef] <asn:1>*argp
> >drivers/char/tpm//tpm_vtpm_proxy.c:553:51: warning: incorrect type in argument 2 (different address spaces)
> >drivers/char/tpm//tpm_vtpm_proxy.c:553:51: expected void const [noderef] <asn:1>*from
> >drivers/char/tpm//tpm_vtpm_proxy.c:553:51: got struct vtpm_proxy_new_dev *vtpm_new_dev_p
> >drivers/char/tpm//tpm_vtpm_proxy.c:559:34: warning: incorrect type in argument 1 (different address spaces)
> >drivers/char/tpm//tpm_vtpm_proxy.c:559:34: expected void [noderef] <asn:1>*to
> >drivers/char/tpm//tpm_vtpm_proxy.c:559:34: got struct vtpm_proxy_new_dev *vtpm_new_dev_p
> >
> >The __user annotation was missing from the corresponding variable.
> >
> >Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>
> Tested-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
>
> PS: I get similar warnings for line 248 in tpm_crb.c.
Yup, I'll proceed to that next. Thank you.
/Jarkko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-16 20:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-16 10:37 [PATCH] tpm_vtpm_proxy: fix sparse warning Jarkko Sakkinen
2016-06-16 13:39 ` Stefan Berger
2016-06-16 20:34 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).