* [PATCH linux] xen: change the type of xen_vcpu_id to uint32_t
@ 2016-07-28 16:24 Vitaly Kuznetsov
2016-07-28 17:18 ` [Xen-devel] " David Vrabel
0 siblings, 1 reply; 3+ messages in thread
From: Vitaly Kuznetsov @ 2016-07-28 16:24 UTC (permalink / raw)
To: xen-devel
Cc: linux-kernel, Boris Ostrovsky, David Vrabel, Juergen Gross,
Stefano Stabellini, Julien Grall
We pass xen_vcpu_id mapping information to hypercalls which require
uint32_t type so it would be cleaner to have it as uint32_t. The
initializer to -1 can be dropped as we always do the mapping before using
it and we never check the 'not set' value anyway.
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
arch/arm/xen/enlighten.c | 2 +-
arch/x86/xen/enlighten.c | 2 +-
include/xen/xen-ops.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
index 6d3a171..1752116 100644
--- a/arch/arm/xen/enlighten.c
+++ b/arch/arm/xen/enlighten.c
@@ -47,7 +47,7 @@ DEFINE_PER_CPU(struct vcpu_info *, xen_vcpu);
static struct vcpu_info __percpu *xen_vcpu_info;
/* Linux <-> Xen vCPU id mapping */
-DEFINE_PER_CPU(int, xen_vcpu_id) = -1;
+DEFINE_PER_CPU(uint32_t, xen_vcpu_id);
EXPORT_PER_CPU_SYMBOL(xen_vcpu_id);
/* These are unused until we support booting "pre-ballooned" */
diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
index 54eef1a..78a14a0 100644
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -120,7 +120,7 @@ DEFINE_PER_CPU(struct vcpu_info *, xen_vcpu);
DEFINE_PER_CPU(struct vcpu_info, xen_vcpu_info);
/* Linux <-> Xen vCPU id mapping */
-DEFINE_PER_CPU(int, xen_vcpu_id) = -1;
+DEFINE_PER_CPU(uint32_t, xen_vcpu_id);
EXPORT_PER_CPU_SYMBOL(xen_vcpu_id);
enum xen_domain_type xen_domain_type = XEN_NATIVE;
diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
index a4926f1..648ce814 100644
--- a/include/xen/xen-ops.h
+++ b/include/xen/xen-ops.h
@@ -9,7 +9,7 @@
DECLARE_PER_CPU(struct vcpu_info *, xen_vcpu);
-DECLARE_PER_CPU(int, xen_vcpu_id);
+DECLARE_PER_CPU(uint32_t, xen_vcpu_id);
static inline int xen_vcpu_nr(int cpu)
{
return per_cpu(xen_vcpu_id, cpu);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Xen-devel] [PATCH linux] xen: change the type of xen_vcpu_id to uint32_t
2016-07-28 16:24 [PATCH linux] xen: change the type of xen_vcpu_id to uint32_t Vitaly Kuznetsov
@ 2016-07-28 17:18 ` David Vrabel
2016-07-29 8:50 ` Vitaly Kuznetsov
0 siblings, 1 reply; 3+ messages in thread
From: David Vrabel @ 2016-07-28 17:18 UTC (permalink / raw)
To: Vitaly Kuznetsov, xen-devel
Cc: Juergen Gross, Stefano Stabellini, linux-kernel, Julien Grall,
David Vrabel, Boris Ostrovsky
On 28/07/16 17:24, Vitaly Kuznetsov wrote:
> We pass xen_vcpu_id mapping information to hypercalls which require
> uint32_t type so it would be cleaner to have it as uint32_t. The
> initializer to -1 can be dropped as we always do the mapping before using
> it and we never check the 'not set' value anyway.
[...]
> --- a/include/xen/xen-ops.h
> +++ b/include/xen/xen-ops.h
> @@ -9,7 +9,7 @@
>
> DECLARE_PER_CPU(struct vcpu_info *, xen_vcpu);
>
> -DECLARE_PER_CPU(int, xen_vcpu_id);
> +DECLARE_PER_CPU(uint32_t, xen_vcpu_id);
> static inline int xen_vcpu_nr(int cpu)
Should the return type of this change to uint32_t as well?
> {
> return per_cpu(xen_vcpu_id, cpu);
>
David
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Xen-devel] [PATCH linux] xen: change the type of xen_vcpu_id to uint32_t
2016-07-28 17:18 ` [Xen-devel] " David Vrabel
@ 2016-07-29 8:50 ` Vitaly Kuznetsov
0 siblings, 0 replies; 3+ messages in thread
From: Vitaly Kuznetsov @ 2016-07-29 8:50 UTC (permalink / raw)
To: David Vrabel
Cc: xen-devel, Juergen Gross, Stefano Stabellini, linux-kernel,
Julien Grall, Boris Ostrovsky
David Vrabel <david.vrabel@citrix.com> writes:
> On 28/07/16 17:24, Vitaly Kuznetsov wrote:
>> We pass xen_vcpu_id mapping information to hypercalls which require
>> uint32_t type so it would be cleaner to have it as uint32_t. The
>> initializer to -1 can be dropped as we always do the mapping before using
>> it and we never check the 'not set' value anyway.
> [...]
>> --- a/include/xen/xen-ops.h
>> +++ b/include/xen/xen-ops.h
>> @@ -9,7 +9,7 @@
>>
>> DECLARE_PER_CPU(struct vcpu_info *, xen_vcpu);
>>
>> -DECLARE_PER_CPU(int, xen_vcpu_id);
>> +DECLARE_PER_CPU(uint32_t, xen_vcpu_id);
>> static inline int xen_vcpu_nr(int cpu)
>
> Should the return type of this change to uint32_t as well?
>
Yes, missed that, will do v2. Sorry!
>> {
>> return per_cpu(xen_vcpu_id, cpu);
>>
--
Vitaly
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-29 8:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-28 16:24 [PATCH linux] xen: change the type of xen_vcpu_id to uint32_t Vitaly Kuznetsov
2016-07-28 17:18 ` [Xen-devel] " David Vrabel
2016-07-29 8:50 ` Vitaly Kuznetsov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).