[PATCH v2 1/2] dell-wmi: Adjust wifi catcher to emit KEY_WLAN

[PATCH v2 1/2] dell-wmi: Adjust wifi catcher to emit KEY_WLAN

[Mario Limonciello]

Wifi catcher is a slider switch, that when slid past the on position
will emit an event that is intended for launching a wifi application
or applet when the machine is turned on.

Signed-off-by: Mario Limonciello <mario_limonciello@dell.com>
---
 drivers/platform/x86/dell-wmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
index d2bc092..866bf73 100644
--- a/drivers/platform/x86/dell-wmi.c
+++ b/drivers/platform/x86/dell-wmi.c
@@ -114,7 +114,7 @@ static const struct key_entry dell_wmi_keymap_type_0000[] __initconst = {
 	/* { KE_IGNORE, 0xe00e, { KEY_RESERVED } }, */
 
 	/* Wifi Catcher */
-	{ KE_KEY,    0xe011, { KEY_PROG2 } },
+	{ KE_KEY,    0xe011, { KEY_WLAN } },
 
 	/* Ambient light sensor toggle */
 	{ KE_IGNORE, 0xe013, { KEY_RESERVED } },
-- 
2.7.4

[PATCH v2 2/2] dell-wmi: Add events created by Dell Rugged 2-in-1s

[Mario Limonciello]

The Dell Rugged 7202 has 3 programmable buttons (labeled P1, P2, P3)
and a detachable keyboard/mouse dock.

Signed-off-by: Mario Limonciello <mario_limonciello@dell.com>
---
 drivers/platform/x86/dell-wmi.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
index 866bf73..28ec17a 100644
--- a/drivers/platform/x86/dell-wmi.c
+++ b/drivers/platform/x86/dell-wmi.c
@@ -274,6 +274,16 @@ static const struct key_entry dell_wmi_keymap_type_0010[] __initconst = {
 
 	/* Stealth mode toggle */
 	{ KE_IGNORE, 0x155, { KEY_RESERVED } },
+
+	/* Rugged magnetic dock attach/detach events */
+	{ KE_IGNORE, 0x156, { KEY_RESERVED } },
+	{ KE_IGNORE, 0x157, { KEY_RESERVED } },
+
+	/* Rugged programmable (P1/P2/P3 keys) */
+	{ KE_KEY,    0x850, { KEY_PROG1 } },
+	{ KE_KEY,    0x851, { KEY_PROG2 } },
+	{ KE_KEY,    0x852, { KEY_PROG3 } },
+
 };
 
 /*
-- 
2.7.4

Re: [PATCH v2 2/2] dell-wmi: Add events created by Dell Rugged 2-in-1s

[Andy Shevchenko]

On Thu, Jul 28, 2016 at 8:53 PM, Mario Limonciello
<mario_limonciello@dell.com> wrote:
> The Dell Rugged 7202 has 3 programmable buttons (labeled P1, P2, P3)
> and a detachable keyboard/mouse dock.
>
> Signed-off-by: Mario Limonciello <mario_limonciello@dell.com>

There was a long discussion in the past. Just to get it clear. Are we
all okay with version 2 of this series?

> ---
>  drivers/platform/x86/dell-wmi.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index 866bf73..28ec17a 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -274,6 +274,16 @@ static const struct key_entry dell_wmi_keymap_type_0010[] __initconst = {
>
>         /* Stealth mode toggle */
>         { KE_IGNORE, 0x155, { KEY_RESERVED } },
> +
> +       /* Rugged magnetic dock attach/detach events */
> +       { KE_IGNORE, 0x156, { KEY_RESERVED } },
> +       { KE_IGNORE, 0x157, { KEY_RESERVED } },
> +
> +       /* Rugged programmable (P1/P2/P3 keys) */
> +       { KE_KEY,    0x850, { KEY_PROG1 } },
> +       { KE_KEY,    0x851, { KEY_PROG2 } },
> +       { KE_KEY,    0x852, { KEY_PROG3 } },
> +
>  };
>
>  /*
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 2/2] dell-wmi: Add events created by Dell Rugged 2-in-1s

[Andy Shevchenko]

On Sat, Nov 19, 2016 at 6:33 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Thu, Jul 28, 2016 at 8:53 PM, Mario Limonciello
> <mario_limonciello@dell.com> wrote:
>> The Dell Rugged 7202 has 3 programmable buttons (labeled P1, P2, P3)
>> and a detachable keyboard/mouse dock.
>>
>> Signed-off-by: Mario Limonciello <mario_limonciello@dell.com>
>
> There was a long discussion in the past. Just to get it clear. Are we
> all okay with version 2 of this series?

Darren, FWIW:
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

>
>> ---
>>  drivers/platform/x86/dell-wmi.c | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
>> index 866bf73..28ec17a 100644
>> --- a/drivers/platform/x86/dell-wmi.c
>> +++ b/drivers/platform/x86/dell-wmi.c
>> @@ -274,6 +274,16 @@ static const struct key_entry dell_wmi_keymap_type_0010[] __initconst = {
>>
>>         /* Stealth mode toggle */
>>         { KE_IGNORE, 0x155, { KEY_RESERVED } },
>> +
>> +       /* Rugged magnetic dock attach/detach events */
>> +       { KE_IGNORE, 0x156, { KEY_RESERVED } },
>> +       { KE_IGNORE, 0x157, { KEY_RESERVED } },
>> +
>> +       /* Rugged programmable (P1/P2/P3 keys) */
>> +       { KE_KEY,    0x850, { KEY_PROG1 } },
>> +       { KE_KEY,    0x851, { KEY_PROG2 } },
>> +       { KE_KEY,    0x852, { KEY_PROG3 } },
>> +
>>  };

-- 
With Best Regards,
Andy Shevchenko