* [PATCH 02/10] reset: berlin: add driver Kconfig option
2016-08-24 13:28 [PATCH 01/10] reset: ath79: add driver Kconfig option Philipp Zabel
@ 2016-08-24 13:28 ` Philipp Zabel
2016-08-24 17:43 ` Masahiro Yamada
2016-08-24 13:28 ` [PATCH 03/10] reset: lpc18xx: " Philipp Zabel
` (11 subsequent siblings)
12 siblings, 1 reply; 42+ messages in thread
From: Philipp Zabel @ 2016-08-24 13:28 UTC (permalink / raw)
To: linux-kernel
Cc: Masahiro Yamada, Arnd Bergmann, Axel Lin, Hans de Goede,
Maxime Ripard, Lee Jones, linux-arm-kernel, Philipp Zabel,
Antoine Tenart, Sebastian Hesselbarth
Visible only if COMPILE_TEST is enabled, this allows to include the
driver in build tests.
Cc: Antoine Tenart <antoine.tenart@free-electrons.com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/reset/Kconfig | 6 ++++++
drivers/reset/Makefile | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index 9da0507..1194cbe 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -21,6 +21,12 @@ config RESET_ATH79
This enables the ATH79 reset controller driver that supports the
AR71xx SoC reset controller.
+config RESET_BERLIN
+ bool "Berlin Reset Driver" if COMPILE_TEST
+ default ARCH_BERLIN
+ help
+ This enables the reset controller driver for Marvell Berlin SoCs.
+
config RESET_OXNAS
bool
diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
index e3fc337..34c0b23 100644
--- a/drivers/reset/Makefile
+++ b/drivers/reset/Makefile
@@ -1,7 +1,6 @@
obj-y += core.o
obj-$(CONFIG_ARCH_LPC18XX) += reset-lpc18xx.o
obj-$(CONFIG_ARCH_SOCFPGA) += reset-socfpga.o
-obj-$(CONFIG_ARCH_BERLIN) += reset-berlin.o
obj-$(CONFIG_MACH_PISTACHIO) += reset-pistachio.o
obj-$(CONFIG_ARCH_MESON) += reset-meson.o
obj-$(CONFIG_ARCH_STM32) += reset-stm32.o
@@ -10,6 +9,7 @@ obj-$(CONFIG_ARCH_STI) += sti/
obj-$(CONFIG_ARCH_HISI) += hisilicon/
obj-$(CONFIG_ARCH_ZYNQ) += reset-zynq.o
obj-$(CONFIG_RESET_ATH79) += reset-ath79.o
+obj-$(CONFIG_RESET_BERLIN) += reset-berlin.o
obj-$(CONFIG_RESET_OXNAS) += reset-oxnas.o
obj-$(CONFIG_TI_SYSCON_RESET) += reset-ti-syscon.o
obj-$(CONFIG_RESET_UNIPHIER) += reset-uniphier.o
--
2.8.1
^ permalink raw reply related [flat|nested] 42+ messages in thread* Re: [PATCH 02/10] reset: berlin: add driver Kconfig option
2016-08-24 13:28 ` [PATCH 02/10] reset: berlin: " Philipp Zabel
@ 2016-08-24 17:43 ` Masahiro Yamada
0 siblings, 0 replies; 42+ messages in thread
From: Masahiro Yamada @ 2016-08-24 17:43 UTC (permalink / raw)
To: Philipp Zabel
Cc: Linux Kernel Mailing List, Axel Lin, Arnd Bergmann,
Hans de Goede, Antoine Tenart, Maxime Ripard, Lee Jones,
linux-arm-kernel, Sebastian Hesselbarth
2016-08-24 22:28 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
> Visible only if COMPILE_TEST is enabled, this allows to include the
> driver in build tests.
>
> Cc: Antoine Tenart <antoine.tenart@free-electrons.com>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH 03/10] reset: lpc18xx: add driver Kconfig option
2016-08-24 13:28 [PATCH 01/10] reset: ath79: add driver Kconfig option Philipp Zabel
2016-08-24 13:28 ` [PATCH 02/10] reset: berlin: " Philipp Zabel
@ 2016-08-24 13:28 ` Philipp Zabel
2016-08-24 17:43 ` Masahiro Yamada
2016-08-24 20:32 ` Joachim Eastwood
2016-08-24 13:28 ` [PATCH 04/10] reset: meson: " Philipp Zabel
` (10 subsequent siblings)
12 siblings, 2 replies; 42+ messages in thread
From: Philipp Zabel @ 2016-08-24 13:28 UTC (permalink / raw)
To: linux-kernel
Cc: Masahiro Yamada, Arnd Bergmann, Axel Lin, Hans de Goede,
Maxime Ripard, Lee Jones, linux-arm-kernel, Philipp Zabel,
Joachim Eastwood
Visible only if COMPILE_TEST is enabled, this allows to include the
driver in build tests.
Cc: Joachim Eastwood <manabian@gmail.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/reset/Kconfig | 7 +++++++
drivers/reset/Makefile | 2 +-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index 1194cbe..8e33de2 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -27,6 +27,13 @@ config RESET_BERLIN
help
This enables the reset controller driver for Marvell Berlin SoCs.
+config RESET_LPC18XX
+ bool "LPC18xx/43xx Reset Driver" if COMPILE_TEST
+ default ARCH_LPC18XX
+ help
+ This enables the LPC18xx/43 reset driver that supports the reset
+ controllers on AR71xx SoCs.
+
config RESET_OXNAS
bool
diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
index 34c0b23..25aa05a 100644
--- a/drivers/reset/Makefile
+++ b/drivers/reset/Makefile
@@ -1,5 +1,4 @@
obj-y += core.o
-obj-$(CONFIG_ARCH_LPC18XX) += reset-lpc18xx.o
obj-$(CONFIG_ARCH_SOCFPGA) += reset-socfpga.o
obj-$(CONFIG_MACH_PISTACHIO) += reset-pistachio.o
obj-$(CONFIG_ARCH_MESON) += reset-meson.o
@@ -10,6 +9,7 @@ obj-$(CONFIG_ARCH_HISI) += hisilicon/
obj-$(CONFIG_ARCH_ZYNQ) += reset-zynq.o
obj-$(CONFIG_RESET_ATH79) += reset-ath79.o
obj-$(CONFIG_RESET_BERLIN) += reset-berlin.o
+obj-$(CONFIG_RESET_LPC18XX) += reset-lpc18xx.o
obj-$(CONFIG_RESET_OXNAS) += reset-oxnas.o
obj-$(CONFIG_TI_SYSCON_RESET) += reset-ti-syscon.o
obj-$(CONFIG_RESET_UNIPHIER) += reset-uniphier.o
--
2.8.1
^ permalink raw reply related [flat|nested] 42+ messages in thread* Re: [PATCH 03/10] reset: lpc18xx: add driver Kconfig option
2016-08-24 13:28 ` [PATCH 03/10] reset: lpc18xx: " Philipp Zabel
@ 2016-08-24 17:43 ` Masahiro Yamada
2016-08-24 20:32 ` Joachim Eastwood
1 sibling, 0 replies; 42+ messages in thread
From: Masahiro Yamada @ 2016-08-24 17:43 UTC (permalink / raw)
To: Philipp Zabel
Cc: Linux Kernel Mailing List, Arnd Bergmann, Axel Lin,
Hans de Goede, Maxime Ripard, Lee Jones, linux-arm-kernel,
Joachim Eastwood
2016-08-24 22:28 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
> Visible only if COMPILE_TEST is enabled, this allows to include the
> driver in build tests.
>
> Cc: Joachim Eastwood <manabian@gmail.com>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 03/10] reset: lpc18xx: add driver Kconfig option
2016-08-24 13:28 ` [PATCH 03/10] reset: lpc18xx: " Philipp Zabel
2016-08-24 17:43 ` Masahiro Yamada
@ 2016-08-24 20:32 ` Joachim Eastwood
2016-08-25 7:22 ` Philipp Zabel
1 sibling, 1 reply; 42+ messages in thread
From: Joachim Eastwood @ 2016-08-24 20:32 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, Masahiro Yamada, Arnd Bergmann, Axel Lin,
Hans de Goede, Maxime Ripard, Lee Jones, linux-arm-kernel
Hi Philipp,
On 24 August 2016 at 15:28, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Visible only if COMPILE_TEST is enabled, this allows to include the
> driver in build tests.
>
> Cc: Joachim Eastwood <manabian@gmail.com>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/reset/Kconfig | 7 +++++++
> drivers/reset/Makefile | 2 +-
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 1194cbe..8e33de2 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -27,6 +27,13 @@ config RESET_BERLIN
> help
> This enables the reset controller driver for Marvell Berlin SoCs.
>
> +config RESET_LPC18XX
> + bool "LPC18xx/43xx Reset Driver" if COMPILE_TEST
> + default ARCH_LPC18XX
> + help
> + This enables the LPC18xx/43 reset driver that supports the reset
> + controllers on AR71xx SoCs.
Don't know where you got the "AR71xx SoCs" from. This reset controller
is found on NXP LPC18xx/43xx SoCs.
Other than that it looks fine to me.
Acked-by: Joachim Eastwood <manabian@gmail.com>
> +
> config RESET_OXNAS
> bool
>
> diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
> index 34c0b23..25aa05a 100644
> --- a/drivers/reset/Makefile
> +++ b/drivers/reset/Makefile
> @@ -1,5 +1,4 @@
> obj-y += core.o
> -obj-$(CONFIG_ARCH_LPC18XX) += reset-lpc18xx.o
> obj-$(CONFIG_ARCH_SOCFPGA) += reset-socfpga.o
> obj-$(CONFIG_MACH_PISTACHIO) += reset-pistachio.o
> obj-$(CONFIG_ARCH_MESON) += reset-meson.o
> @@ -10,6 +9,7 @@ obj-$(CONFIG_ARCH_HISI) += hisilicon/
> obj-$(CONFIG_ARCH_ZYNQ) += reset-zynq.o
> obj-$(CONFIG_RESET_ATH79) += reset-ath79.o
> obj-$(CONFIG_RESET_BERLIN) += reset-berlin.o
> +obj-$(CONFIG_RESET_LPC18XX) += reset-lpc18xx.o
> obj-$(CONFIG_RESET_OXNAS) += reset-oxnas.o
> obj-$(CONFIG_TI_SYSCON_RESET) += reset-ti-syscon.o
> obj-$(CONFIG_RESET_UNIPHIER) += reset-uniphier.o
> --
> 2.8.1
regards,
Joachim Eastwood
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 03/10] reset: lpc18xx: add driver Kconfig option
2016-08-24 20:32 ` Joachim Eastwood
@ 2016-08-25 7:22 ` Philipp Zabel
0 siblings, 0 replies; 42+ messages in thread
From: Philipp Zabel @ 2016-08-25 7:22 UTC (permalink / raw)
To: Joachim Eastwood
Cc: linux-kernel, Masahiro Yamada, Arnd Bergmann, Axel Lin,
Hans de Goede, Maxime Ripard, Lee Jones, linux-arm-kernel
Am Mittwoch, den 24.08.2016, 22:32 +0200 schrieb Joachim Eastwood:
> Hi Philipp,
>
> On 24 August 2016 at 15:28, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> > Visible only if COMPILE_TEST is enabled, this allows to include the
> > driver in build tests.
> >
> > Cc: Joachim Eastwood <manabian@gmail.com>
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > ---
> > drivers/reset/Kconfig | 7 +++++++
> > drivers/reset/Makefile | 2 +-
> > 2 files changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> > index 1194cbe..8e33de2 100644
> > --- a/drivers/reset/Kconfig
> > +++ b/drivers/reset/Kconfig
> > @@ -27,6 +27,13 @@ config RESET_BERLIN
> > help
> > This enables the reset controller driver for Marvell Berlin SoCs.
> >
> > +config RESET_LPC18XX
> > + bool "LPC18xx/43xx Reset Driver" if COMPILE_TEST
> > + default ARCH_LPC18XX
> > + help
> > + This enables the LPC18xx/43 reset driver that supports the reset
> > + controllers on AR71xx SoCs.
>
> Don't know where you got the "AR71xx SoCs" from. This reset controller
> is found on NXP LPC18xx/43xx SoCs.
>
> Other than that it looks fine to me.
>
> Acked-by: Joachim Eastwood <manabian@gmail.com>
Thanks, copy and paste error. I'll fix it.
regards
Philipp
^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH 04/10] reset: meson: add driver Kconfig option
2016-08-24 13:28 [PATCH 01/10] reset: ath79: add driver Kconfig option Philipp Zabel
2016-08-24 13:28 ` [PATCH 02/10] reset: berlin: " Philipp Zabel
2016-08-24 13:28 ` [PATCH 03/10] reset: lpc18xx: " Philipp Zabel
@ 2016-08-24 13:28 ` Philipp Zabel
2016-08-24 13:30 ` Neil Armstrong
2016-08-24 17:43 ` Masahiro Yamada
2016-08-24 13:28 ` [PATCH 05/10] reset: pistachio: " Philipp Zabel
` (9 subsequent siblings)
12 siblings, 2 replies; 42+ messages in thread
From: Philipp Zabel @ 2016-08-24 13:28 UTC (permalink / raw)
To: linux-kernel
Cc: Masahiro Yamada, Arnd Bergmann, Axel Lin, Hans de Goede,
Maxime Ripard, Lee Jones, linux-arm-kernel, Philipp Zabel,
Neil Armstrong
Visible only if COMPILE_TEST is enabled, this allows to include the
driver in build tests.
Cc: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/reset/Kconfig | 6 ++++++
drivers/reset/Makefile | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index 8e33de2..fdf942d 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -34,6 +34,12 @@ config RESET_LPC18XX
This enables the LPC18xx/43 reset driver that supports the reset
controllers on AR71xx SoCs.
+config RESET_MESON
+ bool "Meson Reset Driver" if COMPILE_TEST
+ default ARCH_MESON
+ help
+ This enables the reset driver for Amlogic Meson SoCs.
+
config RESET_OXNAS
bool
diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
index 25aa05a..1408cba 100644
--- a/drivers/reset/Makefile
+++ b/drivers/reset/Makefile
@@ -1,7 +1,6 @@
obj-y += core.o
obj-$(CONFIG_ARCH_SOCFPGA) += reset-socfpga.o
obj-$(CONFIG_MACH_PISTACHIO) += reset-pistachio.o
-obj-$(CONFIG_ARCH_MESON) += reset-meson.o
obj-$(CONFIG_ARCH_STM32) += reset-stm32.o
obj-$(CONFIG_ARCH_SUNXI) += reset-sunxi.o
obj-$(CONFIG_ARCH_STI) += sti/
@@ -10,6 +9,7 @@ obj-$(CONFIG_ARCH_ZYNQ) += reset-zynq.o
obj-$(CONFIG_RESET_ATH79) += reset-ath79.o
obj-$(CONFIG_RESET_BERLIN) += reset-berlin.o
obj-$(CONFIG_RESET_LPC18XX) += reset-lpc18xx.o
+obj-$(CONFIG_RESET_MESON) += reset-meson.o
obj-$(CONFIG_RESET_OXNAS) += reset-oxnas.o
obj-$(CONFIG_TI_SYSCON_RESET) += reset-ti-syscon.o
obj-$(CONFIG_RESET_UNIPHIER) += reset-uniphier.o
--
2.8.1
^ permalink raw reply related [flat|nested] 42+ messages in thread* Re: [PATCH 04/10] reset: meson: add driver Kconfig option
2016-08-24 13:28 ` [PATCH 04/10] reset: meson: " Philipp Zabel
@ 2016-08-24 13:30 ` Neil Armstrong
2016-08-24 17:43 ` Masahiro Yamada
1 sibling, 0 replies; 42+ messages in thread
From: Neil Armstrong @ 2016-08-24 13:30 UTC (permalink / raw)
To: Philipp Zabel, linux-kernel
Cc: Masahiro Yamada, Arnd Bergmann, Axel Lin, Hans de Goede,
Maxime Ripard, Lee Jones, linux-arm-kernel
On 08/24/2016 03:28 PM, Philipp Zabel wrote:
> Visible only if COMPILE_TEST is enabled, this allows to include the
> driver in build tests.
>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/reset/Kconfig | 6 ++++++
> drivers/reset/Makefile | 2 +-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 8e33de2..fdf942d 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -34,6 +34,12 @@ config RESET_LPC18XX
> This enables the LPC18xx/43 reset driver that supports the reset
> controllers on AR71xx SoCs.
>
> +config RESET_MESON
> + bool "Meson Reset Driver" if COMPILE_TEST
> + default ARCH_MESON
> + help
> + This enables the reset driver for Amlogic Meson SoCs.
> +
> config RESET_OXNAS
> bool
>
> diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
> index 25aa05a..1408cba 100644
> --- a/drivers/reset/Makefile
> +++ b/drivers/reset/Makefile
> @@ -1,7 +1,6 @@
> obj-y += core.o
> obj-$(CONFIG_ARCH_SOCFPGA) += reset-socfpga.o
> obj-$(CONFIG_MACH_PISTACHIO) += reset-pistachio.o
> -obj-$(CONFIG_ARCH_MESON) += reset-meson.o
> obj-$(CONFIG_ARCH_STM32) += reset-stm32.o
> obj-$(CONFIG_ARCH_SUNXI) += reset-sunxi.o
> obj-$(CONFIG_ARCH_STI) += sti/
> @@ -10,6 +9,7 @@ obj-$(CONFIG_ARCH_ZYNQ) += reset-zynq.o
> obj-$(CONFIG_RESET_ATH79) += reset-ath79.o
> obj-$(CONFIG_RESET_BERLIN) += reset-berlin.o
> obj-$(CONFIG_RESET_LPC18XX) += reset-lpc18xx.o
> +obj-$(CONFIG_RESET_MESON) += reset-meson.o
> obj-$(CONFIG_RESET_OXNAS) += reset-oxnas.o
> obj-$(CONFIG_TI_SYSCON_RESET) += reset-ti-syscon.o
> obj-$(CONFIG_RESET_UNIPHIER) += reset-uniphier.o
>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 04/10] reset: meson: add driver Kconfig option
2016-08-24 13:28 ` [PATCH 04/10] reset: meson: " Philipp Zabel
2016-08-24 13:30 ` Neil Armstrong
@ 2016-08-24 17:43 ` Masahiro Yamada
1 sibling, 0 replies; 42+ messages in thread
From: Masahiro Yamada @ 2016-08-24 17:43 UTC (permalink / raw)
To: Philipp Zabel
Cc: Linux Kernel Mailing List, Axel Lin, Arnd Bergmann,
Hans de Goede, Neil Armstrong, Maxime Ripard, Lee Jones,
linux-arm-kernel
2016-08-24 22:28 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
> Visible only if COMPILE_TEST is enabled, this allows to include the
> driver in build tests.
>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH 05/10] reset: pistachio: add driver Kconfig option
2016-08-24 13:28 [PATCH 01/10] reset: ath79: add driver Kconfig option Philipp Zabel
` (2 preceding siblings ...)
2016-08-24 13:28 ` [PATCH 04/10] reset: meson: " Philipp Zabel
@ 2016-08-24 13:28 ` Philipp Zabel
2016-08-24 17:44 ` Masahiro Yamada
2016-08-29 20:40 ` James Hartley
2016-08-24 13:28 ` [PATCH 06/10] reset: socfpga: " Philipp Zabel
` (8 subsequent siblings)
12 siblings, 2 replies; 42+ messages in thread
From: Philipp Zabel @ 2016-08-24 13:28 UTC (permalink / raw)
To: linux-kernel
Cc: Masahiro Yamada, Arnd Bergmann, Axel Lin, Hans de Goede,
Maxime Ripard, Lee Jones, linux-arm-kernel, Philipp Zabel,
Damien Horsley, James Hartley
Visible only if COMPILE_TEST is enabled, this allows to include the
driver in build tests.
Cc: Damien Horsley <Damien.Horsley@imgtec.com>
Cc: James Hartley <james.hartley@imgtec.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/reset/Kconfig | 6 ++++++
drivers/reset/Makefile | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index fdf942d..6ac631e 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -43,6 +43,12 @@ config RESET_MESON
config RESET_OXNAS
bool
+config RESET_PISTACHIO
+ bool "Pistachio Reset Driver" if COMPILE_TEST
+ default MACH_PISTACHIO
+ help
+ This enables the reset driver for ImgTec Pistachio SoCs.
+
config TI_SYSCON_RESET
tristate "TI SYSCON Reset Driver"
depends on HAS_IOMEM
diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
index 1408cba..c796a14 100644
--- a/drivers/reset/Makefile
+++ b/drivers/reset/Makefile
@@ -1,6 +1,5 @@
obj-y += core.o
obj-$(CONFIG_ARCH_SOCFPGA) += reset-socfpga.o
-obj-$(CONFIG_MACH_PISTACHIO) += reset-pistachio.o
obj-$(CONFIG_ARCH_STM32) += reset-stm32.o
obj-$(CONFIG_ARCH_SUNXI) += reset-sunxi.o
obj-$(CONFIG_ARCH_STI) += sti/
@@ -11,5 +10,6 @@ obj-$(CONFIG_RESET_BERLIN) += reset-berlin.o
obj-$(CONFIG_RESET_LPC18XX) += reset-lpc18xx.o
obj-$(CONFIG_RESET_MESON) += reset-meson.o
obj-$(CONFIG_RESET_OXNAS) += reset-oxnas.o
+obj-$(CONFIG_RESET_PISTACHIO) += reset-pistachio.o
obj-$(CONFIG_TI_SYSCON_RESET) += reset-ti-syscon.o
obj-$(CONFIG_RESET_UNIPHIER) += reset-uniphier.o
--
2.8.1
^ permalink raw reply related [flat|nested] 42+ messages in thread* Re: [PATCH 05/10] reset: pistachio: add driver Kconfig option
2016-08-24 13:28 ` [PATCH 05/10] reset: pistachio: " Philipp Zabel
@ 2016-08-24 17:44 ` Masahiro Yamada
2016-08-29 20:40 ` James Hartley
1 sibling, 0 replies; 42+ messages in thread
From: Masahiro Yamada @ 2016-08-24 17:44 UTC (permalink / raw)
To: Philipp Zabel
Cc: Linux Kernel Mailing List, Axel Lin, Arnd Bergmann,
Hans de Goede, Damien Horsley, Maxime Ripard, Lee Jones,
James Hartley, linux-arm-kernel
2016-08-24 22:28 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
> Visible only if COMPILE_TEST is enabled, this allows to include the
> driver in build tests.
>
> Cc: Damien Horsley <Damien.Horsley@imgtec.com>
> Cc: James Hartley <james.hartley@imgtec.com>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 42+ messages in thread
* RE: [PATCH 05/10] reset: pistachio: add driver Kconfig option
2016-08-24 13:28 ` [PATCH 05/10] reset: pistachio: " Philipp Zabel
2016-08-24 17:44 ` Masahiro Yamada
@ 2016-08-29 20:40 ` James Hartley
1 sibling, 0 replies; 42+ messages in thread
From: James Hartley @ 2016-08-29 20:40 UTC (permalink / raw)
To: Philipp Zabel, linux-kernel
Cc: Masahiro Yamada, Arnd Bergmann, Axel Lin, Hans de Goede,
Maxime Ripard, Lee Jones, linux-arm-kernel, Damien Horsley
Acked-by: James Hartley <james.hartley@imgtec.com>
James.
> -----Original Message-----
> From: Philipp Zabel [mailto:p.zabel@pengutronix.de]
> Sent: 24 August 2016 14:29
> To: linux-kernel@vger.kernel.org
> Cc: Masahiro Yamada; Arnd Bergmann; Axel Lin; Hans de Goede; Maxime
> Ripard; Lee Jones; linux-arm-kernel@lists.infradead.org; Philipp Zabel;
> Damien Horsley; James Hartley
> Subject: [PATCH 05/10] reset: pistachio: add driver Kconfig option
>
> Visible only if COMPILE_TEST is enabled, this allows to include the driver in
> build tests.
>
> Cc: Damien Horsley <Damien.Horsley@imgtec.com>
> Cc: James Hartley <james.hartley@imgtec.com>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/reset/Kconfig | 6 ++++++
> drivers/reset/Makefile | 2 +-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig index
> fdf942d..6ac631e 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -43,6 +43,12 @@ config RESET_MESON
> config RESET_OXNAS
> bool
>
> +config RESET_PISTACHIO
> + bool "Pistachio Reset Driver" if COMPILE_TEST
> + default MACH_PISTACHIO
> + help
> + This enables the reset driver for ImgTec Pistachio SoCs.
> +
> config TI_SYSCON_RESET
> tristate "TI SYSCON Reset Driver"
> depends on HAS_IOMEM
> diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile index
> 1408cba..c796a14 100644
> --- a/drivers/reset/Makefile
> +++ b/drivers/reset/Makefile
> @@ -1,6 +1,5 @@
> obj-y += core.o
> obj-$(CONFIG_ARCH_SOCFPGA) += reset-socfpga.o
> -obj-$(CONFIG_MACH_PISTACHIO) += reset-pistachio.o
> obj-$(CONFIG_ARCH_STM32) += reset-stm32.o
> obj-$(CONFIG_ARCH_SUNXI) += reset-sunxi.o
> obj-$(CONFIG_ARCH_STI) += sti/
> @@ -11,5 +10,6 @@ obj-$(CONFIG_RESET_BERLIN) += reset-berlin.o
> obj-$(CONFIG_RESET_LPC18XX) += reset-lpc18xx.o
> obj-$(CONFIG_RESET_MESON) += reset-meson.o
> obj-$(CONFIG_RESET_OXNAS) += reset-oxnas.o
> +obj-$(CONFIG_RESET_PISTACHIO) += reset-pistachio.o
> obj-$(CONFIG_TI_SYSCON_RESET) += reset-ti-syscon.o
> obj-$(CONFIG_RESET_UNIPHIER) += reset-uniphier.o
> --
> 2.8.1
^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH 06/10] reset: socfpga: add driver Kconfig option
2016-08-24 13:28 [PATCH 01/10] reset: ath79: add driver Kconfig option Philipp Zabel
` (3 preceding siblings ...)
2016-08-24 13:28 ` [PATCH 05/10] reset: pistachio: " Philipp Zabel
@ 2016-08-24 13:28 ` Philipp Zabel
2016-08-24 15:26 ` Dinh Nguyen
2016-08-24 17:44 ` Masahiro Yamada
2016-08-24 13:28 ` [PATCH 07/10] reset: stm32: " Philipp Zabel
` (7 subsequent siblings)
12 siblings, 2 replies; 42+ messages in thread
From: Philipp Zabel @ 2016-08-24 13:28 UTC (permalink / raw)
To: linux-kernel
Cc: Masahiro Yamada, Arnd Bergmann, Axel Lin, Hans de Goede,
Maxime Ripard, Lee Jones, linux-arm-kernel, Philipp Zabel,
Dinh Nguyen
Visible only if COMPILE_TEST is enabled, this allows to include the
driver in build tests.
Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/reset/Kconfig | 6 ++++++
drivers/reset/Makefile | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index 6ac631e..354e281 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -49,6 +49,12 @@ config RESET_PISTACHIO
help
This enables the reset driver for ImgTec Pistachio SoCs.
+config RESET_SOCFPGA
+ bool "SoC FPGA Reset Driver" if COMPILE_TEST
+ default ARCH_SOCFPGA
+ help
+ This enables the reset driver for Altera SoC FPGAs.
+
config TI_SYSCON_RESET
tristate "TI SYSCON Reset Driver"
depends on HAS_IOMEM
diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
index c796a14..61e4c64 100644
--- a/drivers/reset/Makefile
+++ b/drivers/reset/Makefile
@@ -1,5 +1,4 @@
obj-y += core.o
-obj-$(CONFIG_ARCH_SOCFPGA) += reset-socfpga.o
obj-$(CONFIG_ARCH_STM32) += reset-stm32.o
obj-$(CONFIG_ARCH_SUNXI) += reset-sunxi.o
obj-$(CONFIG_ARCH_STI) += sti/
@@ -11,5 +10,6 @@ obj-$(CONFIG_RESET_LPC18XX) += reset-lpc18xx.o
obj-$(CONFIG_RESET_MESON) += reset-meson.o
obj-$(CONFIG_RESET_OXNAS) += reset-oxnas.o
obj-$(CONFIG_RESET_PISTACHIO) += reset-pistachio.o
+obj-$(CONFIG_RESET_SOCFPGA) += reset-socfpga.o
obj-$(CONFIG_TI_SYSCON_RESET) += reset-ti-syscon.o
obj-$(CONFIG_RESET_UNIPHIER) += reset-uniphier.o
--
2.8.1
^ permalink raw reply related [flat|nested] 42+ messages in thread* Re: [PATCH 06/10] reset: socfpga: add driver Kconfig option
2016-08-24 13:28 ` [PATCH 06/10] reset: socfpga: " Philipp Zabel
@ 2016-08-24 15:26 ` Dinh Nguyen
2016-08-25 7:23 ` Philipp Zabel
2016-08-24 17:44 ` Masahiro Yamada
1 sibling, 1 reply; 42+ messages in thread
From: Dinh Nguyen @ 2016-08-24 15:26 UTC (permalink / raw)
To: Philipp Zabel, linux-kernel
Cc: Masahiro Yamada, Arnd Bergmann, Axel Lin, Hans de Goede,
Maxime Ripard, Lee Jones, linux-arm-kernel
Hi Philipp,
just a minor nit:
On 08/24/2016 08:28 AM, Philipp Zabel wrote:
> Visible only if COMPILE_TEST is enabled, this allows to include the
> driver in build tests.
>
> Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/reset/Kconfig | 6 ++++++
> drivers/reset/Makefile | 2 +-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 6ac631e..354e281 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -49,6 +49,12 @@ config RESET_PISTACHIO
> help
> This enables the reset driver for ImgTec Pistachio SoCs.
>
> +config RESET_SOCFPGA
> + bool "SoC FPGA Reset Driver" if COMPILE_TEST
Prefer to be "SoCFPGA", no space in between.
> + default ARCH_SOCFPGA
> + help
> + This enables the reset driver for Altera SoC FPGAs.
Same here...
> +
> config TI_SYSCON_RESET
> tristate "TI SYSCON Reset Driver"
> depends on HAS_IOMEM
> diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
> index c796a14..61e4c64 100644
> --- a/drivers/reset/Makefile
> +++ b/drivers/reset/Makefile
> @@ -1,5 +1,4 @@
> obj-y += core.o
> -obj-$(CONFIG_ARCH_SOCFPGA) += reset-socfpga.o
> obj-$(CONFIG_ARCH_STM32) += reset-stm32.o
> obj-$(CONFIG_ARCH_SUNXI) += reset-sunxi.o
> obj-$(CONFIG_ARCH_STI) += sti/
> @@ -11,5 +10,6 @@ obj-$(CONFIG_RESET_LPC18XX) += reset-lpc18xx.o
> obj-$(CONFIG_RESET_MESON) += reset-meson.o
> obj-$(CONFIG_RESET_OXNAS) += reset-oxnas.o
> obj-$(CONFIG_RESET_PISTACHIO) += reset-pistachio.o
> +obj-$(CONFIG_RESET_SOCFPGA) += reset-socfpga.o
> obj-$(CONFIG_TI_SYSCON_RESET) += reset-ti-syscon.o
> obj-$(CONFIG_RESET_UNIPHIER) += reset-uniphier.o
>
Otherwise,
Acked-by: Dinh Nguyen <dinguyen@opensource.altera.com>
Thanks,
Dinh
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 06/10] reset: socfpga: add driver Kconfig option
2016-08-24 15:26 ` Dinh Nguyen
@ 2016-08-25 7:23 ` Philipp Zabel
0 siblings, 0 replies; 42+ messages in thread
From: Philipp Zabel @ 2016-08-25 7:23 UTC (permalink / raw)
To: Dinh Nguyen
Cc: linux-kernel, Masahiro Yamada, Arnd Bergmann, Axel Lin,
Hans de Goede, Maxime Ripard, Lee Jones, linux-arm-kernel
Am Mittwoch, den 24.08.2016, 10:26 -0500 schrieb Dinh Nguyen:
> Hi Philipp,
>
> just a minor nit:
>
> On 08/24/2016 08:28 AM, Philipp Zabel wrote:
> > Visible only if COMPILE_TEST is enabled, this allows to include the
> > driver in build tests.
> >
> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > ---
> > drivers/reset/Kconfig | 6 ++++++
> > drivers/reset/Makefile | 2 +-
> > 2 files changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> > index 6ac631e..354e281 100644
> > --- a/drivers/reset/Kconfig
> > +++ b/drivers/reset/Kconfig
> > @@ -49,6 +49,12 @@ config RESET_PISTACHIO
> > help
> > This enables the reset driver for ImgTec Pistachio SoCs.
> >
> > +config RESET_SOCFPGA
> > + bool "SoC FPGA Reset Driver" if COMPILE_TEST
>
> Prefer to be "SoCFPGA", no space in between.
>
[...]
>
> Otherwise,
>
> Acked-by: Dinh Nguyen <dinguyen@opensource.altera.com>
Thank you, I'll fix this.
regards
Philipp
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 06/10] reset: socfpga: add driver Kconfig option
2016-08-24 13:28 ` [PATCH 06/10] reset: socfpga: " Philipp Zabel
2016-08-24 15:26 ` Dinh Nguyen
@ 2016-08-24 17:44 ` Masahiro Yamada
1 sibling, 0 replies; 42+ messages in thread
From: Masahiro Yamada @ 2016-08-24 17:44 UTC (permalink / raw)
To: Philipp Zabel
Cc: Linux Kernel Mailing List, Axel Lin, Arnd Bergmann,
Hans de Goede, Maxime Ripard, Lee Jones, Dinh Nguyen,
linux-arm-kernel
2016-08-24 22:28 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
> Visible only if COMPILE_TEST is enabled, this allows to include the
> driver in build tests.
>
> Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH 07/10] reset: stm32: add driver Kconfig option
2016-08-24 13:28 [PATCH 01/10] reset: ath79: add driver Kconfig option Philipp Zabel
` (4 preceding siblings ...)
2016-08-24 13:28 ` [PATCH 06/10] reset: socfpga: " Philipp Zabel
@ 2016-08-24 13:28 ` Philipp Zabel
2016-08-24 17:44 ` Masahiro Yamada
2016-08-24 13:29 ` [PATCH 08/10] reset: sunxi: " Philipp Zabel
` (6 subsequent siblings)
12 siblings, 1 reply; 42+ messages in thread
From: Philipp Zabel @ 2016-08-24 13:28 UTC (permalink / raw)
To: linux-kernel
Cc: Masahiro Yamada, Arnd Bergmann, Axel Lin, Hans de Goede,
Maxime Ripard, Lee Jones, linux-arm-kernel, Philipp Zabel,
Maxime Coquelin, Gabriel Fernandez
Visible only if COMPILE_TEST is enabled, this allows to include the
driver in build tests.
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Gabriel Fernandez <gabriel.fernandez@st.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/reset/Kconfig | 6 ++++++
drivers/reset/Makefile | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index 354e281..3a54a66 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -55,6 +55,12 @@ config RESET_SOCFPGA
help
This enables the reset driver for Altera SoC FPGAs.
+config RESET_STM32
+ bool "STM32 Reset Driver" if COMPILE_TEST
+ default ARCH_STM32
+ help
+ This enables the RCC reset controller driver for STM32 MCUs.
+
config TI_SYSCON_RESET
tristate "TI SYSCON Reset Driver"
depends on HAS_IOMEM
diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
index 61e4c64..6276f82 100644
--- a/drivers/reset/Makefile
+++ b/drivers/reset/Makefile
@@ -1,5 +1,4 @@
obj-y += core.o
-obj-$(CONFIG_ARCH_STM32) += reset-stm32.o
obj-$(CONFIG_ARCH_SUNXI) += reset-sunxi.o
obj-$(CONFIG_ARCH_STI) += sti/
obj-$(CONFIG_ARCH_HISI) += hisilicon/
@@ -11,5 +10,6 @@ obj-$(CONFIG_RESET_MESON) += reset-meson.o
obj-$(CONFIG_RESET_OXNAS) += reset-oxnas.o
obj-$(CONFIG_RESET_PISTACHIO) += reset-pistachio.o
obj-$(CONFIG_RESET_SOCFPGA) += reset-socfpga.o
+obj-$(CONFIG_RESET_STM32) += reset-stm32.o
obj-$(CONFIG_TI_SYSCON_RESET) += reset-ti-syscon.o
obj-$(CONFIG_RESET_UNIPHIER) += reset-uniphier.o
--
2.8.1
^ permalink raw reply related [flat|nested] 42+ messages in thread* Re: [PATCH 07/10] reset: stm32: add driver Kconfig option
2016-08-24 13:28 ` [PATCH 07/10] reset: stm32: " Philipp Zabel
@ 2016-08-24 17:44 ` Masahiro Yamada
0 siblings, 0 replies; 42+ messages in thread
From: Masahiro Yamada @ 2016-08-24 17:44 UTC (permalink / raw)
To: Philipp Zabel
Cc: Linux Kernel Mailing List, Arnd Bergmann, Axel Lin,
Hans de Goede, Maxime Ripard, Lee Jones, linux-arm-kernel,
Maxime Coquelin, Gabriel Fernandez
2016-08-24 22:28 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
> Visible only if COMPILE_TEST is enabled, this allows to include the
> driver in build tests.
>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Gabriel Fernandez <gabriel.fernandez@st.com>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH 08/10] reset: sunxi: add driver Kconfig option
2016-08-24 13:28 [PATCH 01/10] reset: ath79: add driver Kconfig option Philipp Zabel
` (5 preceding siblings ...)
2016-08-24 13:28 ` [PATCH 07/10] reset: stm32: " Philipp Zabel
@ 2016-08-24 13:29 ` Philipp Zabel
2016-08-24 17:45 ` Masahiro Yamada
2016-08-24 13:29 ` [PATCH 09/10] reset: zynq: " Philipp Zabel
` (5 subsequent siblings)
12 siblings, 1 reply; 42+ messages in thread
From: Philipp Zabel @ 2016-08-24 13:29 UTC (permalink / raw)
To: linux-kernel
Cc: Masahiro Yamada, Arnd Bergmann, Axel Lin, Hans de Goede,
Maxime Ripard, Lee Jones, linux-arm-kernel, Philipp Zabel
Visible only if COMPILE_TEST is enabled, this allows to include the
driver in build tests.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/reset/Kconfig | 6 ++++++
drivers/reset/Makefile | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index 3a54a66..17030e2 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -61,6 +61,12 @@ config RESET_STM32
help
This enables the RCC reset controller driver for STM32 MCUs.
+config RESET_SUNXI
+ bool "Allwinner SoCs Reset Driver" if COMPILE_TEST
+ default ARCH_SUNXI
+ help
+ This enables the reset driver for Allwinner SoCs.
+
config TI_SYSCON_RESET
tristate "TI SYSCON Reset Driver"
depends on HAS_IOMEM
diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
index 6276f82..4a163c7 100644
--- a/drivers/reset/Makefile
+++ b/drivers/reset/Makefile
@@ -1,5 +1,4 @@
obj-y += core.o
-obj-$(CONFIG_ARCH_SUNXI) += reset-sunxi.o
obj-$(CONFIG_ARCH_STI) += sti/
obj-$(CONFIG_ARCH_HISI) += hisilicon/
obj-$(CONFIG_ARCH_ZYNQ) += reset-zynq.o
@@ -11,5 +10,6 @@ obj-$(CONFIG_RESET_OXNAS) += reset-oxnas.o
obj-$(CONFIG_RESET_PISTACHIO) += reset-pistachio.o
obj-$(CONFIG_RESET_SOCFPGA) += reset-socfpga.o
obj-$(CONFIG_RESET_STM32) += reset-stm32.o
+obj-$(CONFIG_RESET_SUNXI) += reset-sunxi.o
obj-$(CONFIG_TI_SYSCON_RESET) += reset-ti-syscon.o
obj-$(CONFIG_RESET_UNIPHIER) += reset-uniphier.o
--
2.8.1
^ permalink raw reply related [flat|nested] 42+ messages in thread* Re: [PATCH 08/10] reset: sunxi: add driver Kconfig option
2016-08-24 13:29 ` [PATCH 08/10] reset: sunxi: " Philipp Zabel
@ 2016-08-24 17:45 ` Masahiro Yamada
0 siblings, 0 replies; 42+ messages in thread
From: Masahiro Yamada @ 2016-08-24 17:45 UTC (permalink / raw)
To: Philipp Zabel
Cc: Linux Kernel Mailing List, Arnd Bergmann, Axel Lin,
Hans de Goede, Maxime Ripard, Lee Jones, linux-arm-kernel
2016-08-24 22:29 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
> Visible only if COMPILE_TEST is enabled, this allows to include the
> driver in build tests.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH 09/10] reset: zynq: add driver Kconfig option
2016-08-24 13:28 [PATCH 01/10] reset: ath79: add driver Kconfig option Philipp Zabel
` (6 preceding siblings ...)
2016-08-24 13:29 ` [PATCH 08/10] reset: sunxi: " Philipp Zabel
@ 2016-08-24 13:29 ` Philipp Zabel
2016-08-24 17:48 ` Masahiro Yamada
2016-08-24 13:29 ` [PATCH 10/10] reset: hi6220: allow to compile test driver on other architectures Philipp Zabel
` (4 subsequent siblings)
12 siblings, 1 reply; 42+ messages in thread
From: Philipp Zabel @ 2016-08-24 13:29 UTC (permalink / raw)
To: linux-kernel
Cc: Masahiro Yamada, Arnd Bergmann, Axel Lin, Hans de Goede,
Maxime Ripard, Lee Jones, linux-arm-kernel, Philipp Zabel,
Moritz Fischer, Michal Simek, Sören Brinkmann
Visible only if COMPILE_TEST is enabled, this allows to include the
driver in build tests.
Cc: Moritz Fischer <moritz.fischer@ettus.com>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: Sören Brinkmann <soren.brinkmann@xilinx.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/reset/Kconfig | 6 ++++++
drivers/reset/Makefile | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index 17030e2..86b49a2 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -67,6 +67,12 @@ config RESET_SUNXI
help
This enables the reset driver for Allwinner SoCs.
+config RESET_ZYNQ
+ bool "ZYNQ Reset Driver" if COMPILE_TEST
+ default ARCH_ZYNQ
+ help
+ This enables the reset driver for Xilinx Zynq FPGAs.
+
config TI_SYSCON_RESET
tristate "TI SYSCON Reset Driver"
depends on HAS_IOMEM
diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
index 4a163c7..56f90ea 100644
--- a/drivers/reset/Makefile
+++ b/drivers/reset/Makefile
@@ -1,7 +1,6 @@
obj-y += core.o
obj-$(CONFIG_ARCH_STI) += sti/
obj-$(CONFIG_ARCH_HISI) += hisilicon/
-obj-$(CONFIG_ARCH_ZYNQ) += reset-zynq.o
obj-$(CONFIG_RESET_ATH79) += reset-ath79.o
obj-$(CONFIG_RESET_BERLIN) += reset-berlin.o
obj-$(CONFIG_RESET_LPC18XX) += reset-lpc18xx.o
@@ -13,3 +12,4 @@ obj-$(CONFIG_RESET_STM32) += reset-stm32.o
obj-$(CONFIG_RESET_SUNXI) += reset-sunxi.o
obj-$(CONFIG_TI_SYSCON_RESET) += reset-ti-syscon.o
obj-$(CONFIG_RESET_UNIPHIER) += reset-uniphier.o
+obj-$(CONFIG_RESET_ZYNQ) += reset-zynq.o
--
2.8.1
^ permalink raw reply related [flat|nested] 42+ messages in thread* Re: [PATCH 09/10] reset: zynq: add driver Kconfig option
2016-08-24 13:29 ` [PATCH 09/10] reset: zynq: " Philipp Zabel
@ 2016-08-24 17:48 ` Masahiro Yamada
2016-08-25 1:08 ` Masahiro Yamada
0 siblings, 1 reply; 42+ messages in thread
From: Masahiro Yamada @ 2016-08-24 17:48 UTC (permalink / raw)
To: Philipp Zabel
Cc: Linux Kernel Mailing List, Arnd Bergmann, Axel Lin,
Hans de Goede, Maxime Ripard, Lee Jones, linux-arm-kernel,
Moritz Fischer, Michal Simek, Sören Brinkmann
2016-08-24 22:29 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
> Visible only if COMPILE_TEST is enabled, this allows to include the
> driver in build tests.
>
> Cc: Moritz Fischer <moritz.fischer@ettus.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Sören Brinkmann <soren.brinkmann@xilinx.com>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/reset/Kconfig | 6 ++++++
> drivers/reset/Makefile | 2 +-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 17030e2..86b49a2 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -67,6 +67,12 @@ config RESET_SUNXI
> help
> This enables the reset driver for Allwinner SoCs.
>
> +config RESET_ZYNQ
> + bool "ZYNQ Reset Driver" if COMPILE_TEST
> + default ARCH_ZYNQ
> + help
> + This enables the reset driver for Xilinx Zynq FPGAs.
> +
Please move this below RESET_UNIPHIER
as I assume you are sorting Kconfig entries alphabetically.
Otherwise,
Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 09/10] reset: zynq: add driver Kconfig option
2016-08-24 17:48 ` Masahiro Yamada
@ 2016-08-25 1:08 ` Masahiro Yamada
2016-08-25 7:23 ` Philipp Zabel
0 siblings, 1 reply; 42+ messages in thread
From: Masahiro Yamada @ 2016-08-25 1:08 UTC (permalink / raw)
To: Philipp Zabel
Cc: Linux Kernel Mailing List, Arnd Bergmann, Axel Lin,
Hans de Goede, Maxime Ripard, Lee Jones, linux-arm-kernel,
Moritz Fischer, Michal Simek, Sören Brinkmann
2016-08-25 2:48 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> 2016-08-24 22:29 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
>> Visible only if COMPILE_TEST is enabled, this allows to include the
>> driver in build tests.
>>
>> Cc: Moritz Fischer <moritz.fischer@ettus.com>
>> Cc: Michal Simek <michal.simek@xilinx.com>
>> Cc: Sören Brinkmann <soren.brinkmann@xilinx.com>
>> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
>> ---
>> drivers/reset/Kconfig | 6 ++++++
>> drivers/reset/Makefile | 2 +-
>> 2 files changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
>> index 17030e2..86b49a2 100644
>> --- a/drivers/reset/Kconfig
>> +++ b/drivers/reset/Kconfig
>> @@ -67,6 +67,12 @@ config RESET_SUNXI
>> help
>> This enables the reset driver for Allwinner SoCs.
>>
>> +config RESET_ZYNQ
>> + bool "ZYNQ Reset Driver" if COMPILE_TEST
>> + default ARCH_ZYNQ
>> + help
>> + This enables the reset driver for Xilinx Zynq FPGAs.
>> +
>
> Please move this below RESET_UNIPHIER
> as I assume you are sorting Kconfig entries alphabetically.
>
>
> Otherwise,
>
> Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
>> + This enables the reset driver for Xilinx Zynq FPGAs.
One more thing, I thought this statement is not precise
because Zynq is not only an FPGA,
but ARM SoC + FPGA.
Please consider to reword
"This enables the reset driver for Xilinx Zynq SoC"
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 09/10] reset: zynq: add driver Kconfig option
2016-08-25 1:08 ` Masahiro Yamada
@ 2016-08-25 7:23 ` Philipp Zabel
2016-08-25 7:31 ` Masahiro Yamada
0 siblings, 1 reply; 42+ messages in thread
From: Philipp Zabel @ 2016-08-25 7:23 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Linux Kernel Mailing List, Arnd Bergmann, Axel Lin,
Hans de Goede, Maxime Ripard, Lee Jones, linux-arm-kernel,
Moritz Fischer, Michal Simek, Sören Brinkmann
Am Donnerstag, den 25.08.2016, 10:08 +0900 schrieb Masahiro Yamada:
> 2016-08-25 2:48 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> > 2016-08-24 22:29 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
> >> Visible only if COMPILE_TEST is enabled, this allows to include the
> >> driver in build tests.
> >>
> >> Cc: Moritz Fischer <moritz.fischer@ettus.com>
> >> Cc: Michal Simek <michal.simek@xilinx.com>
> >> Cc: Sören Brinkmann <soren.brinkmann@xilinx.com>
> >> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> >> ---
> >> drivers/reset/Kconfig | 6 ++++++
> >> drivers/reset/Makefile | 2 +-
> >> 2 files changed, 7 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> >> index 17030e2..86b49a2 100644
> >> --- a/drivers/reset/Kconfig
> >> +++ b/drivers/reset/Kconfig
> >> @@ -67,6 +67,12 @@ config RESET_SUNXI
> >> help
> >> This enables the reset driver for Allwinner SoCs.
> >>
> >> +config RESET_ZYNQ
> >> + bool "ZYNQ Reset Driver" if COMPILE_TEST
> >> + default ARCH_ZYNQ
> >> + help
> >> + This enables the reset driver for Xilinx Zynq FPGAs.
> >> +
> >
> > Please move this below RESET_UNIPHIER
> > as I assume you are sorting Kconfig entries alphabetically.
Yes, that was my intention.
> > Otherwise,
> >
> > Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> >
>
>
>
>
> >> + This enables the reset driver for Xilinx Zynq FPGAs.
>
>
> One more thing, I thought this statement is not precise
> because Zynq is not only an FPGA,
> but ARM SoC + FPGA.
>
> Please consider to reword
>
> "This enables the reset driver for Xilinx Zynq SoC"
I'll change it to SoCs, thanks.
regards
Philipp
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 09/10] reset: zynq: add driver Kconfig option
2016-08-25 7:23 ` Philipp Zabel
@ 2016-08-25 7:31 ` Masahiro Yamada
2016-08-25 7:51 ` Philipp Zabel
0 siblings, 1 reply; 42+ messages in thread
From: Masahiro Yamada @ 2016-08-25 7:31 UTC (permalink / raw)
To: Philipp Zabel
Cc: Linux Kernel Mailing List, Arnd Bergmann, Axel Lin,
Hans de Goede, Maxime Ripard, Lee Jones, linux-arm-kernel,
Moritz Fischer, Michal Simek, Sören Brinkmann
2016-08-25 16:23 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
> Am Donnerstag, den 25.08.2016, 10:08 +0900 schrieb Masahiro Yamada:
>> 2016-08-25 2:48 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
>> > 2016-08-24 22:29 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
>> >> Visible only if COMPILE_TEST is enabled, this allows to include the
>> >> driver in build tests.
>> >>
>> >> Cc: Moritz Fischer <moritz.fischer@ettus.com>
>> >> Cc: Michal Simek <michal.simek@xilinx.com>
>> >> Cc: Sören Brinkmann <soren.brinkmann@xilinx.com>
>> >> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
>> >> ---
>> >> drivers/reset/Kconfig | 6 ++++++
>> >> drivers/reset/Makefile | 2 +-
>> >> 2 files changed, 7 insertions(+), 1 deletion(-)
>> >>
>> >> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
>> >> index 17030e2..86b49a2 100644
>> >> --- a/drivers/reset/Kconfig
>> >> +++ b/drivers/reset/Kconfig
>> >> @@ -67,6 +67,12 @@ config RESET_SUNXI
>> >> help
>> >> This enables the reset driver for Allwinner SoCs.
>> >>
>> >> +config RESET_ZYNQ
>> >> + bool "ZYNQ Reset Driver" if COMPILE_TEST
>> >> + default ARCH_ZYNQ
>> >> + help
>> >> + This enables the reset driver for Xilinx Zynq FPGAs.
>> >> +
>> >
>> > Please move this below RESET_UNIPHIER
>> > as I assume you are sorting Kconfig entries alphabetically.
>
> Yes, that was my intention.
>
>> > Otherwise,
>> >
>> > Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> >
>>
>>
>>
>>
>> >> + This enables the reset driver for Xilinx Zynq FPGAs.
>>
>>
>> One more thing, I thought this statement is not precise
>> because Zynq is not only an FPGA,
>> but ARM SoC + FPGA.
>>
>> Please consider to reword
>>
>> "This enables the reset driver for Xilinx Zynq SoC"
>
> I'll change it to SoCs, thanks.
Maybe singular? As far as I know, Zynq-7000 is the only SoC
of the Zynq family.
I am not sure if Xilinx has plan to add more lineups to 32bit SoCs.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 09/10] reset: zynq: add driver Kconfig option
2016-08-25 7:31 ` Masahiro Yamada
@ 2016-08-25 7:51 ` Philipp Zabel
0 siblings, 0 replies; 42+ messages in thread
From: Philipp Zabel @ 2016-08-25 7:51 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Linux Kernel Mailing List, Arnd Bergmann, Axel Lin,
Hans de Goede, Maxime Ripard, Lee Jones, linux-arm-kernel,
Moritz Fischer, Michal Simek, Sören Brinkmann
Am Donnerstag, den 25.08.2016, 16:31 +0900 schrieb Masahiro Yamada:
> 2016-08-25 16:23 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
> > Am Donnerstag, den 25.08.2016, 10:08 +0900 schrieb Masahiro Yamada:
> >> 2016-08-25 2:48 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> >> > 2016-08-24 22:29 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
> >> >> Visible only if COMPILE_TEST is enabled, this allows to include the
> >> >> driver in build tests.
> >> >>
> >> >> Cc: Moritz Fischer <moritz.fischer@ettus.com>
> >> >> Cc: Michal Simek <michal.simek@xilinx.com>
> >> >> Cc: Sören Brinkmann <soren.brinkmann@xilinx.com>
> >> >> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> >> >> ---
> >> >> drivers/reset/Kconfig | 6 ++++++
> >> >> drivers/reset/Makefile | 2 +-
> >> >> 2 files changed, 7 insertions(+), 1 deletion(-)
> >> >>
> >> >> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> >> >> index 17030e2..86b49a2 100644
> >> >> --- a/drivers/reset/Kconfig
> >> >> +++ b/drivers/reset/Kconfig
> >> >> @@ -67,6 +67,12 @@ config RESET_SUNXI
> >> >> help
> >> >> This enables the reset driver for Allwinner SoCs.
> >> >>
> >> >> +config RESET_ZYNQ
> >> >> + bool "ZYNQ Reset Driver" if COMPILE_TEST
> >> >> + default ARCH_ZYNQ
> >> >> + help
> >> >> + This enables the reset driver for Xilinx Zynq FPGAs.
> >> >> +
> >> >
> >> > Please move this below RESET_UNIPHIER
> >> > as I assume you are sorting Kconfig entries alphabetically.
> >
> > Yes, that was my intention.
> >
> >> > Otherwise,
> >> >
> >> > Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> >> >
> >>
> >>
> >>
> >>
> >> >> + This enables the reset driver for Xilinx Zynq FPGAs.
> >>
> >>
> >> One more thing, I thought this statement is not precise
> >> because Zynq is not only an FPGA,
> >> but ARM SoC + FPGA.
> >>
> >> Please consider to reword
> >>
> >> "This enables the reset driver for Xilinx Zynq SoC"
> >
> > I'll change it to SoCs, thanks.
>
> Maybe singular? As far as I know, Zynq-7000 is the only SoC
> of the Zynq family.
> I am not sure if Xilinx has plan to add more lineups to 32bit SoCs.
Zynq-7000 is a family, so plural should be okay.
regards
Philipp
^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH 10/10] reset: hi6220: allow to compile test driver on other architectures
2016-08-24 13:28 [PATCH 01/10] reset: ath79: add driver Kconfig option Philipp Zabel
` (7 preceding siblings ...)
2016-08-24 13:29 ` [PATCH 09/10] reset: zynq: " Philipp Zabel
@ 2016-08-24 13:29 ` Philipp Zabel
2016-08-24 18:00 ` Masahiro Yamada
2016-08-24 15:51 ` [PATCH 01/10] reset: ath79: add driver Kconfig option Arnd Bergmann
` (3 subsequent siblings)
12 siblings, 1 reply; 42+ messages in thread
From: Philipp Zabel @ 2016-08-24 13:29 UTC (permalink / raw)
To: linux-kernel
Cc: Masahiro Yamada, Arnd Bergmann, Axel Lin, Hans de Goede,
Maxime Ripard, Lee Jones, linux-arm-kernel, Philipp Zabel,
Chen Feng
Also remove the RESET_CONTROLLER dependency, this Kconfig file is
included inside the menuconfig already.
Cc: Chen Feng <puck.chen@hisilicon.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/reset/hisilicon/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/reset/hisilicon/Kconfig b/drivers/reset/hisilicon/Kconfig
index 26bf95a..1ff8b0c 100644
--- a/drivers/reset/hisilicon/Kconfig
+++ b/drivers/reset/hisilicon/Kconfig
@@ -1,5 +1,6 @@
config COMMON_RESET_HI6220
tristate "Hi6220 Reset Driver"
- depends on (ARCH_HISI && RESET_CONTROLLER)
+ depends on ARCH_HISI || COMPILE_TEST
+ default ARCH_HISI
help
Build the Hisilicon Hi6220 reset driver.
--
2.8.1
^ permalink raw reply related [flat|nested] 42+ messages in thread* Re: [PATCH 10/10] reset: hi6220: allow to compile test driver on other architectures
2016-08-24 13:29 ` [PATCH 10/10] reset: hi6220: allow to compile test driver on other architectures Philipp Zabel
@ 2016-08-24 18:00 ` Masahiro Yamada
2016-08-25 7:23 ` Philipp Zabel
0 siblings, 1 reply; 42+ messages in thread
From: Masahiro Yamada @ 2016-08-24 18:00 UTC (permalink / raw)
To: Philipp Zabel
Cc: Linux Kernel Mailing List, Arnd Bergmann, Axel Lin,
Hans de Goede, Maxime Ripard, Lee Jones, linux-arm-kernel,
Chen Feng
2016-08-24 22:29 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
> Also remove the RESET_CONTROLLER dependency, this Kconfig file is
> included inside the menuconfig already.
>
> Cc: Chen Feng <puck.chen@hisilicon.com>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/reset/hisilicon/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/reset/hisilicon/Kconfig b/drivers/reset/hisilicon/Kconfig
> index 26bf95a..1ff8b0c 100644
> --- a/drivers/reset/hisilicon/Kconfig
> +++ b/drivers/reset/hisilicon/Kconfig
> @@ -1,5 +1,6 @@
> config COMMON_RESET_HI6220
> tristate "Hi6220 Reset Driver"
> - depends on (ARCH_HISI && RESET_CONTROLLER)
> + depends on ARCH_HISI || COMPILE_TEST
> + default ARCH_HISI
> help
> Build the Hisilicon Hi6220 reset driver.
> --
> 2.8.1
>
As you see
obj-$(CONFIG_ARCH_HISI) += hisilicon/
in drivers/reset/Makefile,
Kbuild can descend into drivers/reset/hisilicon/
only when CONFIG_ARCH_HISI is enabled.
So, this patch does not add compile-test'ability.
Currently, I only see a single file in drivers/reset/hisilicon/ directory,
but perhaps they might be planning to add more reset drivers for
other Hisilicon SoCs in the future.
Change to
obj-y += hisilicon/
or
create "config RESET_HISI" as a vendor-common option and
obj-$(CONFIG_RESET_HISI) += hisilicon/
?
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 10/10] reset: hi6220: allow to compile test driver on other architectures
2016-08-24 18:00 ` Masahiro Yamada
@ 2016-08-25 7:23 ` Philipp Zabel
0 siblings, 0 replies; 42+ messages in thread
From: Philipp Zabel @ 2016-08-25 7:23 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Linux Kernel Mailing List, Arnd Bergmann, Axel Lin,
Hans de Goede, Maxime Ripard, Lee Jones, linux-arm-kernel,
Chen Feng
Am Donnerstag, den 25.08.2016, 03:00 +0900 schrieb Masahiro Yamada:
> 2016-08-24 22:29 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
> > Also remove the RESET_CONTROLLER dependency, this Kconfig file is
> > included inside the menuconfig already.
> >
> > Cc: Chen Feng <puck.chen@hisilicon.com>
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > ---
> > drivers/reset/hisilicon/Kconfig | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/reset/hisilicon/Kconfig b/drivers/reset/hisilicon/Kconfig
> > index 26bf95a..1ff8b0c 100644
> > --- a/drivers/reset/hisilicon/Kconfig
> > +++ b/drivers/reset/hisilicon/Kconfig
> > @@ -1,5 +1,6 @@
> > config COMMON_RESET_HI6220
> > tristate "Hi6220 Reset Driver"
> > - depends on (ARCH_HISI && RESET_CONTROLLER)
> > + depends on ARCH_HISI || COMPILE_TEST
> > + default ARCH_HISI
> > help
> > Build the Hisilicon Hi6220 reset driver.
> > --
> > 2.8.1
> >
>
>
> As you see
>
> obj-$(CONFIG_ARCH_HISI) += hisilicon/
>
> in drivers/reset/Makefile,
> Kbuild can descend into drivers/reset/hisilicon/
> only when CONFIG_ARCH_HISI is enabled.
>
> So, this patch does not add compile-test'ability.
>
>
> Currently, I only see a single file in drivers/reset/hisilicon/ directory,
> but perhaps they might be planning to add more reset drivers for
> other Hisilicon SoCs in the future.
>
>
> Change to
>
> obj-y += hisilicon/
Good catch, I'll do that for now ...
> or
>
> create "config RESET_HISI" as a vendor-common option and
>
> obj-$(CONFIG_RESET_HISI) += hisilicon/
>
> ?
... since I'm not quite sure if there are currently patches selecting
COMMON_RESET_HI6220 floating around.
regards
Philipp
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 01/10] reset: ath79: add driver Kconfig option
2016-08-24 13:28 [PATCH 01/10] reset: ath79: add driver Kconfig option Philipp Zabel
` (8 preceding siblings ...)
2016-08-24 13:29 ` [PATCH 10/10] reset: hi6220: allow to compile test driver on other architectures Philipp Zabel
@ 2016-08-24 15:51 ` Arnd Bergmann
2016-08-24 18:18 ` Masahiro Yamada
2016-08-24 17:42 ` Masahiro Yamada
` (2 subsequent siblings)
12 siblings, 1 reply; 42+ messages in thread
From: Arnd Bergmann @ 2016-08-24 15:51 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, Masahiro Yamada, Axel Lin, Hans de Goede,
Maxime Ripard, Lee Jones, linux-arm-kernel, Alban Bedel
On Wednesday, August 24, 2016 3:28:53 PM CEST Philipp Zabel wrote:
> if RESET_CONTROLLER
>
> +config RESET_ATH79
> + bool "AR71xx Reset Driver" if COMPILE_TEST
> + default ATH79
> + help
> + This enables the ATH79 reset controller driver that supports the
> + AR71xx SoC reset controller.
> +
>
Nice series!
Just note that there is one possible problem with COMPILE_TEST
when the platforms are enabled, as you can then disable a driver
that is normally there, and that can in turn cause problems in
rare cases, e.g. when the driver has a global function that is
called from platform code. I don't know if any of the drivers
do that, but if they do, you'd have to use
config RESET_ATH79
bool "AR71xx Reset Driver" if COMPILE_TEST && !ATH79
default ATH79
to ensure that it's impossible to disable the driver on platforms
that require it.
Arnd
^ permalink raw reply [flat|nested] 42+ messages in thread* Re: [PATCH 01/10] reset: ath79: add driver Kconfig option
2016-08-24 15:51 ` [PATCH 01/10] reset: ath79: add driver Kconfig option Arnd Bergmann
@ 2016-08-24 18:18 ` Masahiro Yamada
2016-08-24 20:06 ` Arnd Bergmann
0 siblings, 1 reply; 42+ messages in thread
From: Masahiro Yamada @ 2016-08-24 18:18 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Philipp Zabel, Axel Lin, Hans de Goede,
Linux Kernel Mailing List, Alban Bedel, Maxime Ripard, Lee Jones,
linux-arm-kernel
Hi Arnd,
2016-08-25 0:51 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> On Wednesday, August 24, 2016 3:28:53 PM CEST Philipp Zabel wrote:
>> if RESET_CONTROLLER
>>
>> +config RESET_ATH79
>> + bool "AR71xx Reset Driver" if COMPILE_TEST
>> + default ATH79
>> + help
>> + This enables the ATH79 reset controller driver that supports the
>> + AR71xx SoC reset controller.
>> +
>>
>
> Nice series!
>
> Just note that there is one possible problem with COMPILE_TEST
> when the platforms are enabled, as you can then disable a driver
> that is normally there, and that can in turn cause problems in
> rare cases, e.g. when the driver has a global function that is
> called from platform code. I don't know if any of the drivers
> do that, but if they do, you'd have to use
>
> config RESET_ATH79
> bool "AR71xx Reset Driver" if COMPILE_TEST && !ATH79
> default ATH79
>
> to ensure that it's impossible to disable the driver on platforms
> that require it.
Hmm,
Can we do this only when we really have to do so?
I think we should not care about such a rare case that may not happen.
Let's start with only "if COMPILE_TEST",
and take a look at it if a build error is detected.
Anyway, depending on platform code is a sign of weird implementation.
It might be better to find a potential issue rather than hide it.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 01/10] reset: ath79: add driver Kconfig option
2016-08-24 18:18 ` Masahiro Yamada
@ 2016-08-24 20:06 ` Arnd Bergmann
2016-08-25 2:43 ` Masahiro Yamada
2016-08-25 7:22 ` Philipp Zabel
0 siblings, 2 replies; 42+ messages in thread
From: Arnd Bergmann @ 2016-08-24 20:06 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Masahiro Yamada, Axel Lin, Linux Kernel Mailing List,
Hans de Goede, Alban Bedel, Philipp Zabel, Maxime Ripard,
Lee Jones
On Thursday, August 25, 2016 3:18:55 AM CEST Masahiro Yamada wrote:
> Hi Arnd,
>
>
> 2016-08-25 0:51 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> > On Wednesday, August 24, 2016 3:28:53 PM CEST Philipp Zabel wrote:
> >> if RESET_CONTROLLER
> >>
> >> +config RESET_ATH79
> >> + bool "AR71xx Reset Driver" if COMPILE_TEST
> >> + default ATH79
> >> + help
> >> + This enables the ATH79 reset controller driver that supports the
> >> + AR71xx SoC reset controller.
> >> +
> >>
> >
> > Nice series!
> >
> > Just note that there is one possible problem with COMPILE_TEST
> > when the platforms are enabled, as you can then disable a driver
> > that is normally there, and that can in turn cause problems in
> > rare cases, e.g. when the driver has a global function that is
> > called from platform code. I don't know if any of the drivers
> > do that, but if they do, you'd have to use
> >
> > config RESET_ATH79
> > bool "AR71xx Reset Driver" if COMPILE_TEST && !ATH79
> > default ATH79
> >
> > to ensure that it's impossible to disable the driver on platforms
> > that require it.
>
> Hmm,
> Can we do this only when we really have to do so?
> I think we should not care about such a rare case that may not happen.
>
> Let's start with only "if COMPILE_TEST",
> and take a look at it if a build error is detected.
>
> Anyway, depending on platform code is a sign of weird implementation.
>
> It might be better to find a potential issue rather than hide it.
>
>
>
I just checked the object files in an allyesconfig build and found
one instance:
arch/arm/mach-sunxi/sunxi.c:extern void __init sun6i_reset_init(void);
arch/arm/mach-sunxi/sunxi.c: sun6i_reset_init();
drivers/reset/reset-sunxi.c:void __init sun6i_reset_init(void)
We should definitely make sure this one is handled right, and maybe
check the source code for other instances.
Arnd
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 01/10] reset: ath79: add driver Kconfig option
2016-08-24 20:06 ` Arnd Bergmann
@ 2016-08-25 2:43 ` Masahiro Yamada
2016-08-25 7:22 ` Philipp Zabel
1 sibling, 0 replies; 42+ messages in thread
From: Masahiro Yamada @ 2016-08-25 2:43 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-arm-kernel, Axel Lin, Hans de Goede,
Linux Kernel Mailing List, Alban Bedel, Philipp Zabel,
Maxime Ripard, Lee Jones
2016-08-25 5:06 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> On Thursday, August 25, 2016 3:18:55 AM CEST Masahiro Yamada wrote:
>> Hi Arnd,
>>
>>
>> 2016-08-25 0:51 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
>> > On Wednesday, August 24, 2016 3:28:53 PM CEST Philipp Zabel wrote:
>> >> if RESET_CONTROLLER
>> >>
>> >> +config RESET_ATH79
>> >> + bool "AR71xx Reset Driver" if COMPILE_TEST
>> >> + default ATH79
>> >> + help
>> >> + This enables the ATH79 reset controller driver that supports the
>> >> + AR71xx SoC reset controller.
>> >> +
>> >>
>> >
>> > Nice series!
>> >
>> > Just note that there is one possible problem with COMPILE_TEST
>> > when the platforms are enabled, as you can then disable a driver
>> > that is normally there, and that can in turn cause problems in
>> > rare cases, e.g. when the driver has a global function that is
>> > called from platform code. I don't know if any of the drivers
>> > do that, but if they do, you'd have to use
>> >
>> > config RESET_ATH79
>> > bool "AR71xx Reset Driver" if COMPILE_TEST && !ATH79
>> > default ATH79
>> >
>> > to ensure that it's impossible to disable the driver on platforms
>> > that require it.
>>
>> Hmm,
>> Can we do this only when we really have to do so?
>> I think we should not care about such a rare case that may not happen.
>>
>> Let's start with only "if COMPILE_TEST",
>> and take a look at it if a build error is detected.
>>
>> Anyway, depending on platform code is a sign of weird implementation.
>>
>> It might be better to find a potential issue rather than hide it.
>>
>>
>>
>
> I just checked the object files in an allyesconfig build and found
> one instance:
>
> arch/arm/mach-sunxi/sunxi.c:extern void __init sun6i_reset_init(void);
> arch/arm/mach-sunxi/sunxi.c: sun6i_reset_init();
> drivers/reset/reset-sunxi.c:void __init sun6i_reset_init(void)
>
> We should definitely make sure this one is handled right, and maybe
> check the source code for other instances.
Hmm.
Is is solved with RESET_OF_DECLARE(),
like we have CLK_OF_DECLARE() ?
Or, use something like postcore_initcall() to probe it really early?
Not sure...
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 01/10] reset: ath79: add driver Kconfig option
2016-08-24 20:06 ` Arnd Bergmann
2016-08-25 2:43 ` Masahiro Yamada
@ 2016-08-25 7:22 ` Philipp Zabel
2016-08-25 7:27 ` Masahiro Yamada
1 sibling, 1 reply; 42+ messages in thread
From: Philipp Zabel @ 2016-08-25 7:22 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-arm-kernel, Masahiro Yamada, Axel Lin,
Linux Kernel Mailing List, Hans de Goede, Alban Bedel,
Maxime Ripard, Lee Jones
Am Mittwoch, den 24.08.2016, 22:06 +0200 schrieb Arnd Bergmann:
> On Thursday, August 25, 2016 3:18:55 AM CEST Masahiro Yamada wrote:
> > Hi Arnd,
> >
> >
> > 2016-08-25 0:51 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> > > On Wednesday, August 24, 2016 3:28:53 PM CEST Philipp Zabel wrote:
> > >> if RESET_CONTROLLER
> > >>
> > >> +config RESET_ATH79
> > >> + bool "AR71xx Reset Driver" if COMPILE_TEST
> > >> + default ATH79
> > >> + help
> > >> + This enables the ATH79 reset controller driver that supports the
> > >> + AR71xx SoC reset controller.
> > >> +
> > >>
> > >
> > > Nice series!
> > >
> > > Just note that there is one possible problem with COMPILE_TEST
> > > when the platforms are enabled, as you can then disable a driver
> > > that is normally there, and that can in turn cause problems in
> > > rare cases, e.g. when the driver has a global function that is
> > > called from platform code. I don't know if any of the drivers
> > > do that, but if they do, you'd have to use
> > >
> > > config RESET_ATH79
> > > bool "AR71xx Reset Driver" if COMPILE_TEST && !ATH79
> > > default ATH79
> > >
> > > to ensure that it's impossible to disable the driver on platforms
> > > that require it.
> >
> > Hmm,
> > Can we do this only when we really have to do so?
> > I think we should not care about such a rare case that may not happen.
> >
> > Let's start with only "if COMPILE_TEST",
> > and take a look at it if a build error is detected.
> >
> > Anyway, depending on platform code is a sign of weird implementation.
> >
> > It might be better to find a potential issue rather than hide it.
> >
> >
> >
>
> I just checked the object files in an allyesconfig build and found
> one instance:
>
> arch/arm/mach-sunxi/sunxi.c:extern void __init sun6i_reset_init(void);
> arch/arm/mach-sunxi/sunxi.c: sun6i_reset_init();
> drivers/reset/reset-sunxi.c:void __init sun6i_reset_init(void)
>
> We should definitely make sure this one is handled right, and maybe
> check the source code for other instances.
I'll add "&& !ARCH_SUNXI" to the RESET_SUNXI symbol
The only other drivers that have __init symbols are the STiH4xx reset
drivers, which I haven't touched yet: STIH4xx_RESET symbols are already
selected by their respective SOC_STIH4xx under ARCH_STI. And the hi6220
driver, which doesn't have a user yet.
regards
Philipp
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 01/10] reset: ath79: add driver Kconfig option
2016-08-25 7:22 ` Philipp Zabel
@ 2016-08-25 7:27 ` Masahiro Yamada
2016-08-25 7:51 ` Philipp Zabel
0 siblings, 1 reply; 42+ messages in thread
From: Masahiro Yamada @ 2016-08-25 7:27 UTC (permalink / raw)
To: Philipp Zabel
Cc: Arnd Bergmann, linux-arm-kernel, Axel Lin,
Linux Kernel Mailing List, Hans de Goede, Alban Bedel,
Maxime Ripard, Lee Jones
2016-08-25 16:22 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
> And the hi6220
> driver, which doesn't have a user yet.
It does.
See arch/arm64/configs/defconfig
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 01/10] reset: ath79: add driver Kconfig option
2016-08-25 7:27 ` Masahiro Yamada
@ 2016-08-25 7:51 ` Philipp Zabel
0 siblings, 0 replies; 42+ messages in thread
From: Philipp Zabel @ 2016-08-25 7:51 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Arnd Bergmann, linux-arm-kernel, Axel Lin,
Linux Kernel Mailing List, Hans de Goede, Alban Bedel,
Maxime Ripard, Lee Jones
Am Donnerstag, den 25.08.2016, 16:27 +0900 schrieb Masahiro Yamada:
> 2016-08-25 16:22 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
> > And the hi6220
> > driver, which doesn't have a user yet.
>
> It does.
>
> See arch/arm64/configs/defconfig
My mistake, I missed that hi6220_reset_init is a postcore_initcall, so
there is no compile time dependency on the reset driver.
regards
Philipp
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 01/10] reset: ath79: add driver Kconfig option
2016-08-24 13:28 [PATCH 01/10] reset: ath79: add driver Kconfig option Philipp Zabel
` (9 preceding siblings ...)
2016-08-24 15:51 ` [PATCH 01/10] reset: ath79: add driver Kconfig option Arnd Bergmann
@ 2016-08-24 17:42 ` Masahiro Yamada
2016-08-25 10:31 ` kbuild test robot
2016-08-25 11:10 ` Alban
12 siblings, 0 replies; 42+ messages in thread
From: Masahiro Yamada @ 2016-08-24 17:42 UTC (permalink / raw)
To: Philipp Zabel
Cc: Linux Kernel Mailing List, Axel Lin, Arnd Bergmann,
Hans de Goede, Alban Bedel, Maxime Ripard, Lee Jones,
linux-arm-kernel
2016-08-24 22:28 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
> Visible only if COMPILE_TEST is enabled, this allows to include the
> driver in build tests.
>
> Cc: Alban Bedel <albeu@free.fr>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 42+ messages in thread* Re: [PATCH 01/10] reset: ath79: add driver Kconfig option
2016-08-24 13:28 [PATCH 01/10] reset: ath79: add driver Kconfig option Philipp Zabel
` (10 preceding siblings ...)
2016-08-24 17:42 ` Masahiro Yamada
@ 2016-08-25 10:31 ` kbuild test robot
2016-08-25 10:50 ` Arnd Bergmann
2016-08-25 11:10 ` Alban
12 siblings, 1 reply; 42+ messages in thread
From: kbuild test robot @ 2016-08-25 10:31 UTC (permalink / raw)
To: Philipp Zabel
Cc: kbuild-all, linux-kernel, Masahiro Yamada, Arnd Bergmann,
Axel Lin, Hans de Goede, Maxime Ripard, Lee Jones,
linux-arm-kernel, Philipp Zabel, Alban Bedel
[-- Attachment #1: Type: text/plain, Size: 2740 bytes --]
Hi Philipp,
[auto build test ERROR on pza/reset/next]
[also build test ERROR on v4.8-rc3 next-20160824]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]
url: https://github.com/0day-ci/linux/commits/Philipp-Zabel/reset-ath79-add-driver-Kconfig-option/20160824-213846
base: git://git.pengutronix.de/git/pza/linux reset/next
config: blackfin-allyesconfig (attached as .config)
compiler: bfin-uclinux-gcc (GCC) 4.6.3
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=blackfin
All errors (new ones prefixed by >>):
drivers/reset/reset-ath79.c: In function 'ath79_reset_update':
>> drivers/reset/reset-ath79.c:38:2: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
>> drivers/reset/reset-ath79.c:43:2: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
vim +/readl +38 drivers/reset/reset-ath79.c
ff591a91 Alban Bedel 2015-08-03 32 struct ath79_reset *ath79_reset =
ff591a91 Alban Bedel 2015-08-03 33 container_of(rcdev, struct ath79_reset, rcdev);
ff591a91 Alban Bedel 2015-08-03 34 unsigned long flags;
ff591a91 Alban Bedel 2015-08-03 35 u32 val;
ff591a91 Alban Bedel 2015-08-03 36
ff591a91 Alban Bedel 2015-08-03 37 spin_lock_irqsave(&ath79_reset->lock, flags);
ff591a91 Alban Bedel 2015-08-03 @38 val = readl(ath79_reset->base);
ff591a91 Alban Bedel 2015-08-03 39 if (assert)
ff591a91 Alban Bedel 2015-08-03 40 val |= BIT(id);
ff591a91 Alban Bedel 2015-08-03 41 else
ff591a91 Alban Bedel 2015-08-03 42 val &= ~BIT(id);
ff591a91 Alban Bedel 2015-08-03 @43 writel(val, ath79_reset->base);
ff591a91 Alban Bedel 2015-08-03 44 spin_unlock_irqrestore(&ath79_reset->lock, flags);
ff591a91 Alban Bedel 2015-08-03 45
ff591a91 Alban Bedel 2015-08-03 46 return 0;
:::::: The code at line 38 was first introduced by commit
:::::: ff591a91225d3621a503bb18faa0f0d747a06e50 reset: Add a driver for the reset controller on the AR71XX/AR9XXX
:::::: TO: Alban Bedel <albeu@free.fr>
:::::: CC: Philipp Zabel <p.zabel@pengutronix.de>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 41344 bytes --]
^ permalink raw reply [flat|nested] 42+ messages in thread* Re: [PATCH 01/10] reset: ath79: add driver Kconfig option
2016-08-25 10:31 ` kbuild test robot
@ 2016-08-25 10:50 ` Arnd Bergmann
2016-08-25 10:57 ` Philipp Zabel
0 siblings, 1 reply; 42+ messages in thread
From: Arnd Bergmann @ 2016-08-25 10:50 UTC (permalink / raw)
To: kbuild test robot
Cc: Philipp Zabel, kbuild-all, linux-kernel, Masahiro Yamada,
Axel Lin, Hans de Goede, Maxime Ripard, Lee Jones,
linux-arm-kernel, Alban Bedel
On Thursday, August 25, 2016 6:31:48 PM CEST kbuild test robot wrote:
>
> drivers/reset/reset-ath79.c: In function 'ath79_reset_update':
> >> drivers/reset/reset-ath79.c:38:2: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
> >> drivers/reset/reset-ath79.c:43:2: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
>
>
The file lacks "#include <linux/io.h"
Arnd
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 01/10] reset: ath79: add driver Kconfig option
2016-08-25 10:50 ` Arnd Bergmann
@ 2016-08-25 10:57 ` Philipp Zabel
0 siblings, 0 replies; 42+ messages in thread
From: Philipp Zabel @ 2016-08-25 10:57 UTC (permalink / raw)
To: Arnd Bergmann
Cc: kbuild test robot, kbuild-all, linux-kernel, Masahiro Yamada,
Axel Lin, Hans de Goede, Maxime Ripard, Lee Jones,
linux-arm-kernel, Alban Bedel
Am Donnerstag, den 25.08.2016, 12:50 +0200 schrieb Arnd Bergmann:
> On Thursday, August 25, 2016 6:31:48 PM CEST kbuild test robot wrote:
> >
> > drivers/reset/reset-ath79.c: In function 'ath79_reset_update':
> > >> drivers/reset/reset-ath79.c:38:2: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
> > >> drivers/reset/reset-ath79.c:43:2: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration]
> > cc1: some warnings being treated as errors
> >
> >
>
> The file lacks "#include <linux/io.h"
I already sent the fix separately, should have included it with the
series.
regards
Philipp
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 01/10] reset: ath79: add driver Kconfig option
2016-08-24 13:28 [PATCH 01/10] reset: ath79: add driver Kconfig option Philipp Zabel
` (11 preceding siblings ...)
2016-08-25 10:31 ` kbuild test robot
@ 2016-08-25 11:10 ` Alban
12 siblings, 0 replies; 42+ messages in thread
From: Alban @ 2016-08-25 11:10 UTC (permalink / raw)
To: Philipp Zabel
Cc: Alban, linux-kernel, Masahiro Yamada, Arnd Bergmann, Axel Lin,
Hans de Goede, Maxime Ripard, Lee Jones, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 327 bytes --]
On Wed, 24 Aug 2016 15:28:53 +0200
Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Visible only if COMPILE_TEST is enabled, this allows to include the
> driver in build tests.
>
> Cc: Alban Bedel <albeu@free.fr>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-by: Aban Bedel <albeu@free.fr>
Alban
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 42+ messages in thread