* [PATCH] mfd: lp873x: Remove unused mutex lock from struct lp873x
@ 2016-09-06 0:59 Axel Lin
2016-09-13 12:42 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2016-09-06 0:59 UTC (permalink / raw)
To: Lee Jones; +Cc: Keerthy, linux-kernel, Axel Lin
The mutex is not used, so remove it.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/mfd/lp873x.c | 2 --
include/linux/mfd/lp873x.h | 1 -
2 files changed, 3 deletions(-)
diff --git a/drivers/mfd/lp873x.c b/drivers/mfd/lp873x.c
index 9af064c..873c608 100644
--- a/drivers/mfd/lp873x.c
+++ b/drivers/mfd/lp873x.c
@@ -53,8 +53,6 @@ static int lp873x_probe(struct i2c_client *client,
return ret;
}
- mutex_init(&lp873->lock);
-
ret = regmap_read(lp873->regmap, LP873X_REG_OTP_REV, &otpid);
if (ret) {
dev_err(lp873->dev, "Failed to read OTP ID\n");
diff --git a/include/linux/mfd/lp873x.h b/include/linux/mfd/lp873x.h
index 83b1bd7..edbec83 100644
--- a/include/linux/mfd/lp873x.h
+++ b/include/linux/mfd/lp873x.h
@@ -263,7 +263,6 @@ enum lp873x_regulator_id {
struct lp873x {
struct device *dev;
u8 rev;
- struct mutex lock; /* lock guarding the data structure */
struct regmap *regmap;
};
#endif /* __LINUX_MFD_LP873X_H */
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: lp873x: Remove unused mutex lock from struct lp873x
2016-09-06 0:59 [PATCH] mfd: lp873x: Remove unused mutex lock from struct lp873x Axel Lin
@ 2016-09-13 12:42 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2016-09-13 12:42 UTC (permalink / raw)
To: Axel Lin; +Cc: Keerthy, linux-kernel
On Tue, 06 Sep 2016, Axel Lin wrote:
> The mutex is not used, so remove it.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/mfd/lp873x.c | 2 --
> include/linux/mfd/lp873x.h | 1 -
> 2 files changed, 3 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/lp873x.c b/drivers/mfd/lp873x.c
> index 9af064c..873c608 100644
> --- a/drivers/mfd/lp873x.c
> +++ b/drivers/mfd/lp873x.c
> @@ -53,8 +53,6 @@ static int lp873x_probe(struct i2c_client *client,
> return ret;
> }
>
> - mutex_init(&lp873->lock);
> -
> ret = regmap_read(lp873->regmap, LP873X_REG_OTP_REV, &otpid);
> if (ret) {
> dev_err(lp873->dev, "Failed to read OTP ID\n");
> diff --git a/include/linux/mfd/lp873x.h b/include/linux/mfd/lp873x.h
> index 83b1bd7..edbec83 100644
> --- a/include/linux/mfd/lp873x.h
> +++ b/include/linux/mfd/lp873x.h
> @@ -263,7 +263,6 @@ enum lp873x_regulator_id {
> struct lp873x {
> struct device *dev;
> u8 rev;
> - struct mutex lock; /* lock guarding the data structure */
> struct regmap *regmap;
> };
> #endif /* __LINUX_MFD_LP873X_H */
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-13 12:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-06 0:59 [PATCH] mfd: lp873x: Remove unused mutex lock from struct lp873x Axel Lin
2016-09-13 12:42 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).