[PATCH] printk.c: removed unnecessary code

* [PATCH] printk.c: removed unnecessary code
@ 2016-11-29 15:19 Sebastian Duda
  2016-11-30  9:14 ` Michal Hocko
  2016-12-01 17:12 ` [lkp] [printk.c] ea0639c4d5: BUG:recent_printk_recursion kernel test robot
  0 siblings, 2 replies; 5+ messages in thread
From: Sebastian Duda @ 2016-11-29 15:19 UTC (permalink / raw)
  Cc: linux-kernel, Sebastian Duda, Tobias Baumeister, Andrew Morton,
	Petr Mladek, Sergey Senozhatsky, Borislav Petkov, Tejun Heo,
	Thierry Reding, open list

snprintf((char *) ?, 0, ...); always returns Zero and doesn't change the data.
Thus the execution of
	snprintf(NULL, 0, "[%5lu.000000] ", (unsigned long)ts);
has no effect on program.
The substitution with 0 increases the readability of the code.

Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
Signed-off-by: Tobias Baumeister <tobias.baumeister@fau.de>
---
 kernel/printk/printk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 5028f4f..fe3fec1 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -1186,7 +1186,7 @@ static size_t print_time(u64 ts, char *buf)
 	rem_nsec = do_div(ts, 1000000000);
 
 	if (!buf)
-		return snprintf(NULL, 0, "[%5lu.000000] ", (unsigned long)ts);
+		return 0;
 
 	return sprintf(buf, "[%5lu.%06lu] ",
 		       (unsigned long)ts, rem_nsec / 1000);
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread