* [PATCH 0/5] arm64: dts: ls1012a: add the DTS node for QSPI/DSPI support
@ 2016-12-08 9:22 Yuan Yao
2016-12-08 9:23 ` [PATCH 1/5] arm64: dts: ls1012a: add the DTS node for DSPI support Yuan Yao
` (4 more replies)
0 siblings, 5 replies; 13+ messages in thread
From: Yuan Yao @ 2016-12-08 9:22 UTC (permalink / raw)
To: shawnguo, robh+dt, mark.rutland, computersforpeace, dwmw2
Cc: yao.yuan, linux-arm-kernel, linux-kernel, devicetree
From: Yuan Yao <yao.yuan@nxp.com>
LS1012A also support QSPI and DSPI.
This patch set is used to add the QSPI/DSPI node for LS1012A.
This patch set is depend on the patch for add LS1012A platform dts support:
arm64: Add DTS support for FSL's LS1012A SoC
The patchwork link:
https://patchwork.kernel.org/patch/9462399/
Yuan Yao (5):
arm64: dts: ls1012a: add the DTS node for DSPI support
Documentation: fsl: dspi: Add fsl,ls1012a-dspi compatible string
Documentation: dt: mtd: add chip support for "jedec, spi-nor"
arm64: dts: ls1012a: add the DTS node for QSPI support
Documentation: fsl-quadspi: Add fsl,ls1012a-qspi compatible string
.../devicetree/bindings/mtd/fsl-quadspi.txt | 1 +
.../devicetree/bindings/mtd/jedec,spi-nor.txt | 2 +
.../devicetree/bindings/spi/spi-fsl-dspi.txt | 1 +
arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts | 14 +++++++
arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts | 48 ++++++++++++++++++++++
arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts | 15 +++++++
arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 28 +++++++++++++
7 files changed, 109 insertions(+)
--
2.1.0.27.g96db324
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/5] arm64: dts: ls1012a: add the DTS node for DSPI support
2016-12-08 9:22 [PATCH 0/5] arm64: dts: ls1012a: add the DTS node for QSPI/DSPI support Yuan Yao
@ 2016-12-08 9:23 ` Yuan Yao
2016-12-08 9:23 ` [PATCH 2/5] Documentation: fsl: dspi: Add fsl,ls1012a-dspi compatible string Yuan Yao
` (3 subsequent siblings)
4 siblings, 0 replies; 13+ messages in thread
From: Yuan Yao @ 2016-12-08 9:23 UTC (permalink / raw)
To: shawnguo, robh+dt, mark.rutland, computersforpeace, dwmw2
Cc: yao.yuan, linux-arm-kernel, linux-kernel, devicetree
From: Yuan Yao <yao.yuan@nxp.com>
Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
---
arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts | 33 +++++++++++++++++++++++
arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 13 +++++++++
2 files changed, 46 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
index b841251..3d32c76 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
@@ -93,6 +93,39 @@
};
};
+&dspi {
+ bus-num = <0>;
+ status = "okay";
+
+ flash@0 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "n25q128a11", "jedec,spi-nor";
+ reg = <0>;
+ spi-max-frequency = <10000000>;
+ };
+
+ flash@1 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "sst25wf040b", "jedec,spi-nor";
+ spi-cpol;
+ spi-cpha;
+ reg = <1>;
+ spi-max-frequency = <10000000>;
+ };
+
+ flash@2 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "en25s64", "jedec,spi-nor";
+ spi-cpol;
+ spi-cpha;
+ reg = <2>;
+ spi-max-frequency = <10000000>;
+ };
+};
+
&duart0 {
status = "okay";
};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
index 92e64f3..c917a87 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
@@ -148,6 +148,19 @@
status = "disabled";
};
+ dspi: dspi@2100000 {
+ compatible = "fsl,ls1012a-dspi", "fsl,ls1021a-v1.0-dspi";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x0 0x2100000 0x0 0x10000>;
+ interrupts = <0 64 IRQ_TYPE_LEVEL_HIGH>;
+ clock-names = "dspi";
+ clocks = <&clockgen 4 0>;
+ spi-num-chipselects = <5>;
+ big-endian;
+ status = "disabled";
+ };
+
duart0: serial@21c0500 {
compatible = "fsl,ns16550", "ns16550a";
reg = <0x00 0x21c0500 0x0 0x100>;
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 2/5] Documentation: fsl: dspi: Add fsl,ls1012a-dspi compatible string
2016-12-08 9:22 [PATCH 0/5] arm64: dts: ls1012a: add the DTS node for QSPI/DSPI support Yuan Yao
2016-12-08 9:23 ` [PATCH 1/5] arm64: dts: ls1012a: add the DTS node for DSPI support Yuan Yao
@ 2016-12-08 9:23 ` Yuan Yao
2016-12-12 17:08 ` [PATCH 2/5] Documentation: fsl: dspi: Add fsl, ls1012a-dspi " Rob Herring
2016-12-08 9:23 ` [PATCH 3/5] Documentation: dt: mtd: add chip support for "jedec, spi-nor" Yuan Yao
` (2 subsequent siblings)
4 siblings, 1 reply; 13+ messages in thread
From: Yuan Yao @ 2016-12-08 9:23 UTC (permalink / raw)
To: shawnguo, robh+dt, mark.rutland, computersforpeace, dwmw2
Cc: yao.yuan, linux-arm-kernel, linux-kernel, devicetree
From: Yuan Yao <yao.yuan@nxp.com>
new compatible string: "fsl,ls1012a-dspi".
Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
---
Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt b/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt
index ff5893d..800c483 100644
--- a/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt
+++ b/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt
@@ -5,6 +5,7 @@ Required properties:
"fsl,ls2085a-dspi"
or
"fsl,ls2080a-dspi" followed by "fsl,ls2085a-dspi"
+ "fsl,ls1012a-dspi" followed by "fsl,ls1021a-v1.0-dspi"
- reg : Offset and length of the register set for the device
- interrupts : Should contain SPI controller interrupt
- clocks: from common clock binding: handle to dspi clock.
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 3/5] Documentation: dt: mtd: add chip support for "jedec, spi-nor"
2016-12-08 9:22 [PATCH 0/5] arm64: dts: ls1012a: add the DTS node for QSPI/DSPI support Yuan Yao
2016-12-08 9:23 ` [PATCH 1/5] arm64: dts: ls1012a: add the DTS node for DSPI support Yuan Yao
2016-12-08 9:23 ` [PATCH 2/5] Documentation: fsl: dspi: Add fsl,ls1012a-dspi compatible string Yuan Yao
@ 2016-12-08 9:23 ` Yuan Yao
2016-12-12 17:09 ` Rob Herring
2016-12-08 9:23 ` [PATCH 4/5] arm64: dts: ls1012a: add the DTS node for QSPI support Yuan Yao
2016-12-08 9:23 ` [PATCH 5/5] Documentation: fsl-quadspi: Add fsl,ls1012a-qspi compatible string Yuan Yao
4 siblings, 1 reply; 13+ messages in thread
From: Yuan Yao @ 2016-12-08 9:23 UTC (permalink / raw)
To: shawnguo, robh+dt, mark.rutland, computersforpeace, dwmw2
Cc: yao.yuan, linux-arm-kernel, linux-kernel, devicetree
From: Yuan Yao <yao.yuan@nxp.com>
"sst25wf040b" and "en25s64" are also chip compatible with SPI NOR flash.
Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
---
Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt
index 2c91c03..86614ee 100644
--- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt
+++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt
@@ -13,6 +13,7 @@ Required properties:
at25df321a
at25df641
at26df081a
+ en25s64
mr25h256
mx25l4005a
mx25l1606e
@@ -29,6 +30,7 @@ Required properties:
s25fl008k
s25fl064k
sst25vf040b
+ sst25wf040b
m25p40
m25p80
m25p16
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 4/5] arm64: dts: ls1012a: add the DTS node for QSPI support
2016-12-08 9:22 [PATCH 0/5] arm64: dts: ls1012a: add the DTS node for QSPI/DSPI support Yuan Yao
` (2 preceding siblings ...)
2016-12-08 9:23 ` [PATCH 3/5] Documentation: dt: mtd: add chip support for "jedec, spi-nor" Yuan Yao
@ 2016-12-08 9:23 ` Yuan Yao
2016-12-08 9:23 ` [PATCH 5/5] Documentation: fsl-quadspi: Add fsl,ls1012a-qspi compatible string Yuan Yao
4 siblings, 0 replies; 13+ messages in thread
From: Yuan Yao @ 2016-12-08 9:23 UTC (permalink / raw)
To: shawnguo, robh+dt, mark.rutland, computersforpeace, dwmw2
Cc: yao.yuan, linux-arm-kernel, linux-kernel, devicetree
From: Yuan Yao <yao.yuan@nxp.com>
There is a s25fs512s qspi flash on QDS, RDB and FRDM board.
Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
---
arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts | 14 ++++++++++++++
arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts | 15 +++++++++++++++
arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts | 15 +++++++++++++++
arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 15 +++++++++++++++
4 files changed, 59 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
index 81bd689..34f9e76 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts
@@ -110,6 +110,20 @@
};
};
+&qspi {
+ num-cs = <2>;
+ bus-num = <0>;
+ status = "okay";
+
+ qflash0: s25fs512s@0 {
+ compatible = "spansion,m25p80";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ spi-max-frequency = <20000000>;
+ reg = <0>;
+ };
+};
+
&sai2 {
status = "okay";
};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
index 3d32c76..0e5befa 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
@@ -156,6 +156,21 @@
};
};
+&qspi {
+ num-cs = <2>;
+ bus-num = <0>;
+ status = "okay";
+
+ qflash0: s25fs512s@0 {
+ compatible = "spansion,m25p80";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ spi-max-frequency = <20000000>;
+ m25p,fast-read;
+ reg = <0>;
+ };
+};
+
&sai2 {
status = "okay";
};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
index 62c5c71..c20bfd3 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
@@ -57,3 +57,18 @@
&i2c0 {
status = "okay";
};
+
+&qspi {
+ num-cs = <2>;
+ bus-num = <0>;
+ status = "okay";
+
+ qflash0: s25fs512s@0 {
+ compatible = "spansion,m25p80";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ spi-max-frequency = <20000000>;
+ m25p,fast-read;
+ reg = <0>;
+ };
+};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
index c917a87..72e61c5 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
@@ -195,6 +195,21 @@
#interrupt-cells = <2>;
};
+ qspi: quadspi@1550000 {
+ compatible = "fsl,ls1012a-qspi", "fsl,ls1021a-qspi";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x0 0x1550000 0x0 0x10000>,
+ <0x0 0x40000000 0x0 0x10000000>;
+ reg-names = "QuadSPI", "QuadSPI-memory";
+ interrupts = <0 99 IRQ_TYPE_LEVEL_HIGH>;
+ clock-names = "qspi_en", "qspi";
+ clocks = <&clockgen 4 0>, <&clockgen 4 0>;
+ big-endian;
+ fsl,qspi-has-second-chip;
+ status = "disabled";
+ };
+
wdog0: wdog@2ad0000 {
compatible = "fsl,ls1012a-wdt",
"fsl,imx21-wdt";
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 5/5] Documentation: fsl-quadspi: Add fsl,ls1012a-qspi compatible string
2016-12-08 9:22 [PATCH 0/5] arm64: dts: ls1012a: add the DTS node for QSPI/DSPI support Yuan Yao
` (3 preceding siblings ...)
2016-12-08 9:23 ` [PATCH 4/5] arm64: dts: ls1012a: add the DTS node for QSPI support Yuan Yao
@ 2016-12-08 9:23 ` Yuan Yao
2016-12-12 17:09 ` [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi " Rob Herring
4 siblings, 1 reply; 13+ messages in thread
From: Yuan Yao @ 2016-12-08 9:23 UTC (permalink / raw)
To: shawnguo, robh+dt, mark.rutland, computersforpeace, dwmw2
Cc: yao.yuan, linux-arm-kernel, linux-kernel, devicetree
From: Yuan Yao <yao.yuan@nxp.com>
new compatible string: "fsl,ls1012a-qspi".
Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
---
Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt b/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt
index c34aa6f..a2ed621 100644
--- a/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt
+++ b/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt
@@ -7,6 +7,7 @@ Required properties:
or
"fsl,ls2080a-qspi" followed by "fsl,ls1021a-qspi",
"fsl,ls1043a-qspi" followed by "fsl,ls1021a-qspi"
+ "fsl,ls1012a-qspi" followed by "fsl,ls1021a-qspi"
- reg : the first contains the register location and length,
the second contains the memory mapping address and length
- reg-names: Should contain the reg names "QuadSPI" and "QuadSPI-memory"
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 2/5] Documentation: fsl: dspi: Add fsl, ls1012a-dspi compatible string
2016-12-08 9:23 ` [PATCH 2/5] Documentation: fsl: dspi: Add fsl,ls1012a-dspi compatible string Yuan Yao
@ 2016-12-12 17:08 ` Rob Herring
0 siblings, 0 replies; 13+ messages in thread
From: Rob Herring @ 2016-12-12 17:08 UTC (permalink / raw)
To: Yuan Yao
Cc: shawnguo, mark.rutland, computersforpeace, dwmw2, devicetree,
yao.yuan, linux-arm-kernel, linux-kernel
On Thu, Dec 08, 2016 at 05:23:01PM +0800, Yuan Yao wrote:
> From: Yuan Yao <yao.yuan@nxp.com>
>
> new compatible string: "fsl,ls1012a-dspi".
>
> Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
> ---
> Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 3/5] Documentation: dt: mtd: add chip support for "jedec, spi-nor"
2016-12-08 9:23 ` [PATCH 3/5] Documentation: dt: mtd: add chip support for "jedec, spi-nor" Yuan Yao
@ 2016-12-12 17:09 ` Rob Herring
2016-12-13 2:46 ` Yao Yuan
0 siblings, 1 reply; 13+ messages in thread
From: Rob Herring @ 2016-12-12 17:09 UTC (permalink / raw)
To: Yuan Yao
Cc: shawnguo, mark.rutland, computersforpeace, dwmw2, devicetree,
yao.yuan, linux-arm-kernel, linux-kernel
On Thu, Dec 08, 2016 at 05:23:02PM +0800, Yuan Yao wrote:
> From: Yuan Yao <yao.yuan@nxp.com>
The compatible string is wrong in the subject.
>
> "sst25wf040b" and "en25s64" are also chip compatible with SPI NOR flash.
>
> Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
> ---
> Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt | 2 ++
> 1 file changed, 2 insertions(+)
Otherwise,
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi compatible string
2016-12-08 9:23 ` [PATCH 5/5] Documentation: fsl-quadspi: Add fsl,ls1012a-qspi compatible string Yuan Yao
@ 2016-12-12 17:09 ` Rob Herring
2016-12-13 2:47 ` Yao Yuan
0 siblings, 1 reply; 13+ messages in thread
From: Rob Herring @ 2016-12-12 17:09 UTC (permalink / raw)
To: Yuan Yao
Cc: shawnguo, mark.rutland, computersforpeace, dwmw2, devicetree,
yao.yuan, linux-arm-kernel, linux-kernel
On Thu, Dec 08, 2016 at 05:23:04PM +0800, Yuan Yao wrote:
> From: Yuan Yao <yao.yuan@nxp.com>
Same problem in this subject too.
>
> new compatible string: "fsl,ls1012a-qspi".
>
> Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
> ---
> Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH 3/5] Documentation: dt: mtd: add chip support for "jedec, spi-nor"
2016-12-12 17:09 ` Rob Herring
@ 2016-12-13 2:46 ` Yao Yuan
0 siblings, 0 replies; 13+ messages in thread
From: Yao Yuan @ 2016-12-13 2:46 UTC (permalink / raw)
To: Rob Herring
Cc: shawnguo, mark.rutland, computersforpeace, dwmw2, devicetree,
linux-arm-kernel, linux-kernel
On Thu, Dec 13, 2016 at 05:23:02PM +0800, Rob Herring wrote:
> On Thu, Dec 08, 2016 at 05:23:02PM +0800, Yuan Yao wrote:
> > From: Yuan Yao <yao.yuan@nxp.com>
>
> The compatible string is wrong in the subject.
>
> >
> > "sst25wf040b" and "en25s64" are also chip compatible with SPI NOR flash.
> >
> > Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
> > ---
> > Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt | 2 ++
> > 1 file changed, 2 insertions(+)
>
> Otherwise,
>
> Acked-by: Rob Herring <robh@kernel.org>
Thanks for your review.
I will update the subject and send v2 soon.
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi compatible string
2016-12-12 17:09 ` [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi " Rob Herring
@ 2016-12-13 2:47 ` Yao Yuan
2016-12-13 21:14 ` Rob Herring
0 siblings, 1 reply; 13+ messages in thread
From: Yao Yuan @ 2016-12-13 2:47 UTC (permalink / raw)
To: Rob Herring, Yuan Yao
Cc: shawnguo, mark.rutland, computersforpeace, dwmw2, devicetree,
linux-arm-kernel, linux-kernel
On Thu, Dec 13, 2016 at 05:23:02PM +0800, Rob Herring wrote:
> On Thu, Dec 08, 2016 at 05:23:04PM +0800, Yuan Yao wrote:
> > From: Yuan Yao <yao.yuan@nxp.com>
>
> Same problem in this subject too.
>
> >
> > new compatible string: "fsl,ls1012a-qspi".
> >
> > Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
> > ---
> > Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 1 +
> > 1 file changed, 1 insertion(+)
>
> Acked-by: Rob Herring <robh@kernel.org>
Thanks for your review.
And do you have any suggestion for this subject?
I will update the subject and send v2 soon.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi compatible string
2016-12-13 2:47 ` Yao Yuan
@ 2016-12-13 21:14 ` Rob Herring
2016-12-14 7:52 ` Yao Yuan
0 siblings, 1 reply; 13+ messages in thread
From: Rob Herring @ 2016-12-13 21:14 UTC (permalink / raw)
To: Yao Yuan
Cc: Yuan Yao, shawnguo, mark.rutland, computersforpeace, dwmw2,
devicetree, linux-arm-kernel, linux-kernel
On Mon, Dec 12, 2016 at 8:47 PM, Yao Yuan <yao.yuan@nxp.com> wrote:
> On Thu, Dec 13, 2016 at 05:23:02PM +0800, Rob Herring wrote:
>> On Thu, Dec 08, 2016 at 05:23:04PM +0800, Yuan Yao wrote:
>> > From: Yuan Yao <yao.yuan@nxp.com>
>>
>> Same problem in this subject too.
>>
>> >
>> > new compatible string: "fsl,ls1012a-qspi".
>> >
>> > Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
>> > ---
>> > Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 1 +
>> > 1 file changed, 1 insertion(+)
>>
>> Acked-by: Rob Herring <robh@kernel.org>
>
> Thanks for your review.
> And do you have any suggestion for this subject?
The problem is you have a space in the compatible string: "fsl,
ls1012a-qspi" rather than "fsl,ls1012a-qspi"
Also, I prefer "dt/bindings: " as the beginning of binding patch subjects.
Rob
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi compatible string
2016-12-13 21:14 ` Rob Herring
@ 2016-12-14 7:52 ` Yao Yuan
0 siblings, 0 replies; 13+ messages in thread
From: Yao Yuan @ 2016-12-14 7:52 UTC (permalink / raw)
To: Rob Herring
Cc: Yuan Yao, shawnguo, mark.rutland, computersforpeace, dwmw2,
devicetree, linux-arm-kernel, linux-kernel
On Thu, Dec 14, 2016 at 05:23:02PM +0800, Rob Herring wrote:
> On Mon, Dec 12, 2016 at 8:47 PM, Yao Yuan <yao.yuan@nxp.com> wrote:
> > On Thu, Dec 13, 2016 at 05:23:02PM +0800, Rob Herring wrote:
> >> On Thu, Dec 08, 2016 at 05:23:04PM +0800, Yuan Yao wrote:
> >> > From: Yuan Yao <yao.yuan@nxp.com>
> >>
> >> Same problem in this subject too.
> >>
> >> >
> >> > new compatible string: "fsl,ls1012a-qspi".
> >> >
> >> > Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
> >> > ---
> >> > Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 1 +
> >> > 1 file changed, 1 insertion(+)
> >>
> >> Acked-by: Rob Herring <robh@kernel.org>
> >
> > Thanks for your review.
> > And do you have any suggestion for this subject?
>
> The problem is you have a space in the compatible string: "fsl, ls1012a-qspi"
> rather than "fsl,ls1012a-qspi"
>
> Also, I prefer "dt/bindings: " as the beginning of binding patch subjects.
>
Ok, Get it.
Thanks for your comments.
I will send v2 soon.
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2016-12-14 7:52 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-08 9:22 [PATCH 0/5] arm64: dts: ls1012a: add the DTS node for QSPI/DSPI support Yuan Yao
2016-12-08 9:23 ` [PATCH 1/5] arm64: dts: ls1012a: add the DTS node for DSPI support Yuan Yao
2016-12-08 9:23 ` [PATCH 2/5] Documentation: fsl: dspi: Add fsl,ls1012a-dspi compatible string Yuan Yao
2016-12-12 17:08 ` [PATCH 2/5] Documentation: fsl: dspi: Add fsl, ls1012a-dspi " Rob Herring
2016-12-08 9:23 ` [PATCH 3/5] Documentation: dt: mtd: add chip support for "jedec, spi-nor" Yuan Yao
2016-12-12 17:09 ` Rob Herring
2016-12-13 2:46 ` Yao Yuan
2016-12-08 9:23 ` [PATCH 4/5] arm64: dts: ls1012a: add the DTS node for QSPI support Yuan Yao
2016-12-08 9:23 ` [PATCH 5/5] Documentation: fsl-quadspi: Add fsl,ls1012a-qspi compatible string Yuan Yao
2016-12-12 17:09 ` [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi " Rob Herring
2016-12-13 2:47 ` Yao Yuan
2016-12-13 21:14 ` Rob Herring
2016-12-14 7:52 ` Yao Yuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).