* [PATCH] cfg80211 debugfs: Cleanup some checkpatch issues
@ 2017-01-27 19:26 Pichugin Dmitry
2017-01-27 19:48 ` Joe Perches
2017-01-27 21:00 ` Johannes Berg
0 siblings, 2 replies; 5+ messages in thread
From: Pichugin Dmitry @ 2017-01-27 19:26 UTC (permalink / raw)
To: johannes, davem; +Cc: linux-wireless, netdev, linux-kernel
This fixes the checkpatch.pl warnings:
* Macros should not use a trailing semicolon.
* Spaces required around that '='.
* Symbolic permissions 'S_IRUGO' are not preferred.
* Macro argument reuse 'buflen' - possible side-effects
Signed-off-by: Pichugin Dmitry <smokeman85@gmail.com>
---
net/wireless/debugfs.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/net/wireless/debugfs.c b/net/wireless/debugfs.c
index 5d45391..96e3cff 100644
--- a/net/wireless/debugfs.c
+++ b/net/wireless/debugfs.c
@@ -17,11 +17,12 @@
static ssize_t name## _read(struct file *file, char __user *userbuf, \
size_t count, loff_t *ppos) \
{ \
- struct wiphy *wiphy= file->private_data; \
- char buf[buflen]; \
+ struct wiphy *wiphy = file->private_data; \
+ int __buflen = __builtin_constant_p(buflen) ? buflen : -1; \
+ char buf[__buflen]; \
int res; \
\
- res = scnprintf(buf, buflen, fmt "\n", ##value); \
+ res = scnprintf(buf, __buflen, fmt "\n", ##value); \
return simple_read_from_buffer(userbuf, count, ppos, buf, res); \
} \
\
@@ -29,14 +30,14 @@ static const struct file_operations name## _ops = { \
.read = name## _read, \
.open = simple_open, \
.llseek = generic_file_llseek, \
-};
+}
DEBUGFS_READONLY_FILE(rts_threshold, 20, "%d",
- wiphy->rts_threshold)
+ wiphy->rts_threshold);
DEBUGFS_READONLY_FILE(fragmentation_threshold, 20, "%d",
wiphy->frag_threshold);
DEBUGFS_READONLY_FILE(short_retry_limit, 20, "%d",
- wiphy->retry_short)
+ wiphy->retry_short);
DEBUGFS_READONLY_FILE(long_retry_limit, 20, "%d",
wiphy->retry_long);
@@ -103,7 +104,7 @@ static const struct file_operations ht40allow_map_ops = {
};
#define DEBUGFS_ADD(name) \
- debugfs_create_file(#name, S_IRUGO, phyd, &rdev->wiphy, &name## _ops);
+ debugfs_create_file(#name, 0444, phyd, &rdev->wiphy, &name## _ops)
void cfg80211_debugfs_rdev_add(struct cfg80211_registered_device *rdev)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] cfg80211 debugfs: Cleanup some checkpatch issues
2017-01-27 19:26 [PATCH] cfg80211 debugfs: Cleanup some checkpatch issues Pichugin Dmitry
@ 2017-01-27 19:48 ` Joe Perches
2017-01-28 11:49 ` Dmitriy Pichugin
2017-01-27 21:00 ` Johannes Berg
1 sibling, 1 reply; 5+ messages in thread
From: Joe Perches @ 2017-01-27 19:48 UTC (permalink / raw)
To: Pichugin Dmitry, johannes, davem; +Cc: linux-wireless, netdev, linux-kernel
On Fri, 2017-01-27 at 22:26 +0300, Pichugin Dmitry wrote:
> This fixes the checkpatch.pl warnings:
> * Macros should not use a trailing semicolon.
> * Spaces required around that '='.
> * Symbolic permissions 'S_IRUGO' are not preferred.
OK
> * Macro argument reuse 'buflen' - possible side-effects
Not all checkpatch messages need fixing.
This is one of them.
> diff --git a/net/wireless/debugfs.c b/net/wireless/debugfs.c
[]
> @@ -17,11 +17,12 @@
> static ssize_t name## _read(struct file *file, char __user *userbuf, \
> size_t count, loff_t *ppos) \
> { \
> - struct wiphy *wiphy= file->private_data; \
> - char buf[buflen]; \
> + struct wiphy *wiphy = file->private_data; \
> + int __buflen = __builtin_constant_p(buflen) ? buflen : -1; \
> + char buf[__buflen]; \
That's rather an odd change too
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] cfg80211 debugfs: Cleanup some checkpatch issues
2017-01-27 19:48 ` Joe Perches
@ 2017-01-28 11:49 ` Dmitriy Pichugin
0 siblings, 0 replies; 5+ messages in thread
From: Dmitriy Pichugin @ 2017-01-28 11:49 UTC (permalink / raw)
To: Joe Perches; +Cc: johannes, davem, linux-wireless, netdev, linux-kernel
On Fri, Jan 27, 2017 at 11:48:35AM -0800, Joe Perches wrote:
> On Fri, 2017-01-27 at 22:26 +0300, Pichugin Dmitry wrote:
> > This fixes the checkpatch.pl warnings:
> > * Macros should not use a trailing semicolon.
> > * Spaces required around that '='.
> > * Symbolic permissions 'S_IRUGO' are not preferred.
>
> OK
>
> > * Macro argument reuse 'buflen' - possible side-effects
>
> Not all checkpatch messages need fixing.
> This is one of them.
>
> > diff --git a/net/wireless/debugfs.c b/net/wireless/debugfs.c
> []
> > @@ -17,11 +17,12 @@
> > static ssize_t name## _read(struct file *file, char __user *userbuf, \
> > size_t count, loff_t *ppos) \
> > { \
> > - struct wiphy *wiphy= file->private_data; \
> > - char buf[buflen]; \
> > + struct wiphy *wiphy = file->private_data; \
> > + int __buflen = __builtin_constant_p(buflen) ? buflen : -1; \
> > + char buf[__buflen]; \
>
> That's rather an odd change too
>
OK. I will update the patch.
Best Regards,
Dmitriy.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] cfg80211 debugfs: Cleanup some checkpatch issues
2017-01-27 19:26 [PATCH] cfg80211 debugfs: Cleanup some checkpatch issues Pichugin Dmitry
2017-01-27 19:48 ` Joe Perches
@ 2017-01-27 21:00 ` Johannes Berg
2017-01-27 21:10 ` Joe Perches
1 sibling, 1 reply; 5+ messages in thread
From: Johannes Berg @ 2017-01-27 21:00 UTC (permalink / raw)
To: Pichugin Dmitry, davem; +Cc: linux-wireless, netdev, linux-kernel
On Fri, 2017-01-27 at 22:26 +0300, Pichugin Dmitry wrote:
> This fixes the checkpatch.pl warnings:
> * Macros should not use a trailing semicolon.
> * Spaces required around that '='.
> * Symbolic permissions 'S_IRUGO' are not preferred.
> * Macro argument reuse 'buflen' - possible side-effects
I really see no point in any of this.
johannes
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] cfg80211 debugfs: Cleanup some checkpatch issues
2017-01-27 21:00 ` Johannes Berg
@ 2017-01-27 21:10 ` Joe Perches
0 siblings, 0 replies; 5+ messages in thread
From: Joe Perches @ 2017-01-27 21:10 UTC (permalink / raw)
To: Johannes Berg, Pichugin Dmitry, davem
Cc: linux-wireless, netdev, linux-kernel
On Fri, 2017-01-27 at 22:00 +0100, Johannes Berg wrote:
> On Fri, 2017-01-27 at 22:26 +0300, Pichugin Dmitry wrote:
> > This fixes the checkpatch.pl warnings:
> > * Macros should not use a trailing semicolon.
> > * Spaces required around that '='.
> > * Symbolic permissions 'S_IRUGO' are not preferred.
> > * Macro argument reuse 'buflen' - possible side-effects
>
> I really see no point in any of this.
Look at the uses of DEBUGFS_READONLY_FILE and
see if they are consistent before and after.
DEBUGFS_READONLY_FILE(rts_threshold, 20, "%d",
- wiphy->rts_threshold)
+ wiphy->rts_threshold);
DEBUGFS_READONLY_FILE(fragmentation_threshold, 20, "%d",
wiphy->frag_threshold);
DEBUGFS_READONLY_FILE(short_retry_limit, 20, "%d",
- wiphy->retry_short)
+ wiphy->retry_short);
DEBUGFS_READONLY_FILE(long_retry_limit, 20, "%d",
wiphy->retry_long);
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-01-28 11:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-27 19:26 [PATCH] cfg80211 debugfs: Cleanup some checkpatch issues Pichugin Dmitry
2017-01-27 19:48 ` Joe Perches
2017-01-28 11:49 ` Dmitriy Pichugin
2017-01-27 21:00 ` Johannes Berg
2017-01-27 21:10 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).