* [PATCH 1/2] usb: dwc2: Remove unnecessary debug prints
@ 2017-04-19 11:16 Razmik Karapetyan
2017-04-19 21:55 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Razmik Karapetyan @ 2017-04-19 11:16 UTC (permalink / raw)
To: John Youn, Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-kernel
Cc: Razmik Karapetyan
Removed unnecessary debug prints about DMA mode for host side
from dwc2_gahbcfg_init() function.
Signed-off-by: Razmik Karapetyan <razmik@synopsys.com>
---
drivers/usb/dwc2/hcd.c | 16 ++--------------
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index f4ef159..6da1a1e 100644
--- a/drivers/usb/dwc2/hcd.c
+++ b/drivers/usb/dwc2/hcd.c
@@ -302,22 +302,10 @@ static int dwc2_gahbcfg_init(struct dwc2_hsotg *hsotg)
break;
}
- dev_dbg(hsotg->dev, "host_dma:%d dma_desc_enable:%d\n",
- hsotg->params.host_dma,
- hsotg->params.dma_desc_enable);
-
- if (hsotg->params.host_dma) {
- if (hsotg->params.dma_desc_enable)
- dev_dbg(hsotg->dev, "Using Descriptor DMA mode\n");
- else
- dev_dbg(hsotg->dev, "Using Buffer DMA mode\n");
- } else {
- dev_dbg(hsotg->dev, "Using Slave mode\n");
- hsotg->params.dma_desc_enable = false;
- }
-
if (hsotg->params.host_dma)
ahbcfg |= GAHBCFG_DMA_EN;
+ else
+ hsotg->params.dma_desc_enable = false;
dwc2_writel(ahbcfg, hsotg->regs + GAHBCFG);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] usb: dwc2: Remove unnecessary debug prints
2017-04-19 11:16 [PATCH 1/2] usb: dwc2: Remove unnecessary debug prints Razmik Karapetyan
@ 2017-04-19 21:55 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2017-04-19 21:55 UTC (permalink / raw)
To: Razmik Karapetyan, John Youn, Felipe Balbi, Greg Kroah-Hartman,
linux-usb, linux-kernel
On Wed, 2017-04-19 at 15:16 +0400, Razmik Karapetyan wrote:
> Removed unnecessary debug prints about DMA mode for host side
> from dwc2_gahbcfg_init() function.
Why are these unnecessary? Are these emitted elsewhere?
and...
> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
[]
> @@ -302,22 +302,10 @@ static int dwc2_gahbcfg_init(struct dwc2_hsotg *hsotg)
[]
> if (hsotg->params.host_dma)
> ahbcfg |= GAHBCFG_DMA_EN;
> + else
> + hsotg->params.dma_desc_enable = false;
This change isn't mentioned in the commit message.
Why is is useful?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-19 21:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-19 11:16 [PATCH 1/2] usb: dwc2: Remove unnecessary debug prints Razmik Karapetyan
2017-04-19 21:55 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).