From: Joe Perches <joe@perches.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Michal Kalderon <mkalderon@marvell.com>,
"apw@canonical.com" <apw@canonical.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: [EXT] Re: [PATCH] checkpatch: add test for empty line after Fixes statement
Date: Mon, 20 May 2019 17:07:22 -0700 [thread overview]
Message-ID: <1522228b6c9c7ec89ce14f3f3cf1fe221a315371.camel@perches.com> (raw)
In-Reply-To: <20190520135214.GM4573@mtr-leonro.mtl.com>
On Mon, 2019-05-20 at 16:52 +0300, Leon Romanovsky wrote:
> On Mon, May 20, 2019 at 06:34:49AM -0700, Joe Perches wrote:
> > On Mon, 2019-05-20 at 13:16 +0000, Michal Kalderon wrote:
> > > > From: Joe Perches <joe@perches.com>
> > > > Sent: Monday, May 20, 2019 3:57 PM
> > > > Subject: [EXT] Re: [PATCH] checkpatch: add test for empty line after Fixes
> > > > statement
> > > >
> > > > External Email
> > > >
> > > > ----------------------------------------------------------------------
> > > > On Mon, 2019-05-20 at 15:42 +0300, Michal Kalderon wrote:
> > > > > Check that there is no empty line after a fixes statement
> > > >
> > > > why?
> > > >
> > > This comment is given a lot on the netdev and rdma mailing lists when patches are submitted with
> > > an empty line between Fixes: tag and SOB tags. Since "Fixes:" is just another tag and should be kept
> > > together with the other ones.
> >
> > So test that all signature blocks and Fixes do not have
> > blank lines between them instead of just the "Fixes:" line.
> >
> > And if there is some specific ordering required, perhaps a
> > test for that ordering should be added as well.
>
> I'm aware of only one request - Fixes above SOB.
Well, nack for the suggested patch.
If there are signature blocks, then there should not be blank lines
between entries and there should be a blank line before the
signature block.
The current documentation in Documentation/process/submitting-patches.rst
doesn't state anything about blank lines above or below Fixes: lines.
prev parent reply other threads:[~2019-05-21 0:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 12:42 [PATCH] checkpatch: add test for empty line after Fixes statement Michal Kalderon
2019-05-20 12:56 ` Joe Perches
2019-05-20 13:16 ` Leon Romanovsky
2019-05-20 13:16 ` [EXT] " Michal Kalderon
2019-05-20 13:34 ` Joe Perches
2019-05-20 13:52 ` Leon Romanovsky
2019-05-21 0:07 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522228b6c9c7ec89ce14f3f3cf1fe221a315371.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=davem@davemloft.net \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkalderon@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).