From: Michal Kalderon <mkalderon@marvell.com>
To: Joe Perches <joe@perches.com>,
"leon@kernel.org" <leon@kernel.org>,
"apw@canonical.com" <apw@canonical.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"David Miller" <davem@davemloft.net>
Subject: RE: [EXT] Re: [PATCH] checkpatch: add test for empty line after Fixes statement
Date: Mon, 20 May 2019 13:16:23 +0000 [thread overview]
Message-ID: <MN2PR18MB318292E37F3AB9383D9FBE0FA1060@MN2PR18MB3182.namprd18.prod.outlook.com> (raw)
In-Reply-To: <ed26df86d7d0e12263404842895460b1611def61.camel@perches.com>
> From: Joe Perches <joe@perches.com>
> Sent: Monday, May 20, 2019 3:57 PM
> Subject: [EXT] Re: [PATCH] checkpatch: add test for empty line after Fixes
> statement
>
> External Email
>
> ----------------------------------------------------------------------
> On Mon, 2019-05-20 at 15:42 +0300, Michal Kalderon wrote:
> > Check that there is no empty line after a fixes statement
>
> why?
>
This comment is given a lot on the netdev and rdma mailing lists when patches are submitted with
an empty line between Fixes: tag and SOB tags. Since "Fixes:" is just another tag and should be kept
together with the other ones.
thanks,
Michal
next prev parent reply other threads:[~2019-05-20 13:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 12:42 [PATCH] checkpatch: add test for empty line after Fixes statement Michal Kalderon
2019-05-20 12:56 ` Joe Perches
2019-05-20 13:16 ` Leon Romanovsky
2019-05-20 13:16 ` Michal Kalderon [this message]
2019-05-20 13:34 ` [EXT] " Joe Perches
2019-05-20 13:52 ` Leon Romanovsky
2019-05-21 0:07 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR18MB318292E37F3AB9383D9FBE0FA1060@MN2PR18MB3182.namprd18.prod.outlook.com \
--to=mkalderon@marvell.com \
--cc=apw@canonical.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).