linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: Michal Kalderon <mkalderon@marvell.com>,
	"apw@canonical.com" <apw@canonical.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	David Miller <davem@davemloft.net>
Subject: Re: [EXT] Re: [PATCH] checkpatch: add test for empty line after Fixes statement
Date: Mon, 20 May 2019 16:52:14 +0300	[thread overview]
Message-ID: <20190520135214.GM4573@mtr-leonro.mtl.com> (raw)
In-Reply-To: <60717bc4cdf327ffe671c328d47c315eefd385c8.camel@perches.com>

On Mon, May 20, 2019 at 06:34:49AM -0700, Joe Perches wrote:
> On Mon, 2019-05-20 at 13:16 +0000, Michal Kalderon wrote:
> > > From: Joe Perches <joe@perches.com>
> > > Sent: Monday, May 20, 2019 3:57 PM
> > > Subject: [EXT] Re: [PATCH] checkpatch: add test for empty line after Fixes
> > > statement
> > >
> > > External Email
> > >
> > > ----------------------------------------------------------------------
> > > On Mon, 2019-05-20 at 15:42 +0300, Michal Kalderon wrote:
> > > > Check that there is no empty line after a fixes statement
> > >
> > > why?
> > >
> > This comment is given a lot on the netdev and rdma mailing lists when patches are submitted with
> > an empty line between Fixes: tag and SOB tags. Since "Fixes:" is just another tag and should be kept
> > together with the other ones.
>
> So test that all signature blocks and Fixes do not have
> blank lines between them instead of just the "Fixes:" line.
>
> And if there is some specific ordering required, perhaps a
> test for that ordering should be added as well.

I'm aware of only one request - Fixes above SOB.

Thanks

>

  reply	other threads:[~2019-05-20 13:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20 12:42 [PATCH] checkpatch: add test for empty line after Fixes statement Michal Kalderon
2019-05-20 12:56 ` Joe Perches
2019-05-20 13:16   ` Leon Romanovsky
2019-05-20 13:16   ` [EXT] " Michal Kalderon
2019-05-20 13:34     ` Joe Perches
2019-05-20 13:52       ` Leon Romanovsky [this message]
2019-05-21  0:07         ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190520135214.GM4573@mtr-leonro.mtl.com \
    --to=leon@kernel.org \
    --cc=apw@canonical.com \
    --cc=davem@davemloft.net \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkalderon@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).