linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: Michal Kalderon <michal.kalderon@marvell.com>,
	apw@canonical.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: add test for empty line after Fixes statement
Date: Mon, 20 May 2019 16:16:10 +0300	[thread overview]
Message-ID: <20190520131610.GK4573@mtr-leonro.mtl.com> (raw)
In-Reply-To: <ed26df86d7d0e12263404842895460b1611def61.camel@perches.com>

On Mon, May 20, 2019 at 05:56:36AM -0700, Joe Perches wrote:
> On Mon, 2019-05-20 at 15:42 +0300, Michal Kalderon wrote:
> > Check that there is no empty line after a fixes statement
>
> why?

It is common mistake for Gerrit users, they are removing
their ChangeID crap with some wrong sed command which leaves
empty line.

You can argue that this should be fixed on the client side and I agree,
nut because the checkpatch check is so easy, it is worth to add it and
save reviewers time.

Thanks

>
>

  reply	other threads:[~2019-05-20 13:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20 12:42 [PATCH] checkpatch: add test for empty line after Fixes statement Michal Kalderon
2019-05-20 12:56 ` Joe Perches
2019-05-20 13:16   ` Leon Romanovsky [this message]
2019-05-20 13:16   ` [EXT] " Michal Kalderon
2019-05-20 13:34     ` Joe Perches
2019-05-20 13:52       ` Leon Romanovsky
2019-05-21  0:07         ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190520131610.GK4573@mtr-leonro.mtl.com \
    --to=leon@kernel.org \
    --cc=apw@canonical.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.kalderon@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).