[PATCH] arm64: allowing mmap to be traced

[PATCH] arm64: allowing mmap to be traced

[Christian Hansen]

Adding missing macro which is present all other system calls to
to mmap declaration for ARM.  This allows it to appear as a kernel
tracing target.

Signed-off-by: Christian Hansen <chansen3@cisco.com>
---
 arch/arm64/kernel/sys.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/kernel/sys.c b/arch/arm64/kernel/sys.c
index 72981ba..1ccdbfc 100644
--- a/arch/arm64/kernel/sys.c
+++ b/arch/arm64/kernel/sys.c
@@ -27,9 +27,9 @@
 #include <linux/syscalls.h>
 #include <asm/cpufeature.h>
 
-asmlinkage long sys_mmap(unsigned long addr, unsigned long len,
-			 unsigned long prot, unsigned long flags,
-			 unsigned long fd, off_t off)
+SYSCALL_DEFINE6(mmap, unsigned long, addr, unsigned long, len,
+		unsigned long, prot, unsigned long, flags,
+		unsigned long, fd, off_t, off)
 {
 	if (offset_in_page(off) != 0)
 		return -EINVAL;
-- 
2.5.0

Re: [PATCH] arm64: allowing mmap to be traced

[Mark Rutland]

On Mon, May 14, 2018 at 02:32:42PM +0000, Christian Hansen wrote:
> Adding missing macro which is present all other system calls to
> to mmap declaration for ARM.  This allows it to appear as a kernel
> tracing target.
> 
> Signed-off-by: Christian Hansen <chansen3@cisco.com>

FWIW, I sent out a patch doing this earlier today [1], which is
identical modulo some spacing.

Mark.

[1] https://lkml.kernel.org/r/20180514094640.27569-17-mark.rutland@arm.com

> ---
>  arch/arm64/kernel/sys.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/kernel/sys.c b/arch/arm64/kernel/sys.c
> index 72981ba..1ccdbfc 100644
> --- a/arch/arm64/kernel/sys.c
> +++ b/arch/arm64/kernel/sys.c
> @@ -27,9 +27,9 @@
>  #include <linux/syscalls.h>
>  #include <asm/cpufeature.h>
>  
> -asmlinkage long sys_mmap(unsigned long addr, unsigned long len,
> -			 unsigned long prot, unsigned long flags,
> -			 unsigned long fd, off_t off)
> +SYSCALL_DEFINE6(mmap, unsigned long, addr, unsigned long, len,
> +		unsigned long, prot, unsigned long, flags,
> +		unsigned long, fd, off_t, off)
>  {
>  	if (offset_in_page(off) != 0)
>  		return -EINVAL;
> -- 
> 2.5.0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] arm64: allowing mmap to be traced

[Christian Hansen (chansen3)]

Indeed, you have the quicker draw.  I concede to your patch.

On 2018-05-14, 10:32 AM, "Christian Hansen (chansen3)" <chansen3@cisco.com> wrote:

    Adding missing macro which is present all other system calls to
    to mmap declaration for ARM.  This allows it to appear as a kernel
    tracing target.
    
    Signed-off-by: Christian Hansen <chansen3@cisco.com>
    ---
     arch/arm64/kernel/sys.c | 6 +++---
     1 file changed, 3 insertions(+), 3 deletions(-)
    
    diff --git a/arch/arm64/kernel/sys.c b/arch/arm64/kernel/sys.c
    index 72981ba..1ccdbfc 100644
    --- a/arch/arm64/kernel/sys.c
    +++ b/arch/arm64/kernel/sys.c
    @@ -27,9 +27,9 @@
     #include <linux/syscalls.h>
     #include <asm/cpufeature.h>
     
    -asmlinkage long sys_mmap(unsigned long addr, unsigned long len,
    -			 unsigned long prot, unsigned long flags,
    -			 unsigned long fd, off_t off)
    +SYSCALL_DEFINE6(mmap, unsigned long, addr, unsigned long, len,
    +		unsigned long, prot, unsigned long, flags,
    +		unsigned long, fd, off_t, off)
     {
     	if (offset_in_page(off) != 0)
     		return -EINVAL;
    -- 
    2.5.0